From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Guthro Subject: Re: S3 is broken again in xen-unstable Date: Tue, 7 May 2013 05:18:45 -0400 Message-ID: <-2313368536701448454@unknownmsgid> References: <20130426204758.GT11427@reaktio.net> <20130507083447.GE11427@reaktio.net> <26100746.41126.1367916036066.JavaMail.mobile-sync@vcin11> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <26100746.41126.1367916036066.JavaMail.mobile-sync@vcin11> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ben Guthro , xen-devel List-Id: xen-devel@lists.xenproject.org On May 7, 2013, at 4:40 AM, Jan Beulich wrote: >>>> On 07.05.13 at 10:34, Pasi K=E4rkk=E4inen wrote: >> On Fri, Apr 26, 2013 at 07:41:07PM -0400, Ben Guthro wrote: >>> Then, also the ns16550 change. >>> While strictly not necessary to fix S3 in the normal path, it does fix >>> a bug that can lead to S3 not working if you >>> a. have one of these SuperIO controllers on the LPC bus. >>> b. have serial enabled. >> http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;hn96c186d238735978= 96051b0 >> 43cfeb119c4a7d5 >> >> Jan: I think this ns16550 patch should be backported to 4.2 branch aswel= l.. > > Yeah, as being secondary I left this off until we know that this > really is the only thing known to break resume (i.e. I saw no point > in backporting this when in the end S3 still wouldn't work anyway). > > Ben - am I right in understanding your earlier summary in this > thread to mean that the 4.2 branch, according to your testing, > is now is such a state? > Yea, S3 works on the 4.2.3 branch without this patch. This fixes a specific corner case on some machines with the SuperIO hardware.