All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: tools@kernel.org
Subject: [PATCH b4] review-tui: show no-reply preview for note-only reviews
Date: Tue, 25 Aug 2026 15:08:38 -0300	[thread overview]
Message-ID: <0-v1-0c2c3c276e04+ce2-note_email_jgg@nvidia.com> (raw)

If a note is attached and nothing else is placed in the review then the
email screen says:

   No email to preview (missing message-id?).

Which sounds like an error, really there is no message to send so it
should say:

   No reply will be sent for this patch.

Remove note from the condition.

Assisted-by: LLM
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
 src/b4/review_tui/_review_app.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/b4/review_tui/_review_app.py b/src/b4/review_tui/_review_app.py
index 7fe707bb8995f1..d73fe057b5d499 100644
--- a/src/b4/review_tui/_review_app.py
+++ b/src/b4/review_tui/_review_app.py
@@ -854,10 +854,7 @@ class ReviewApp(LoreNodeShutdownMixin, CheckRunnerMixin, App[None]):
             return
 
         if not review or not (
-            review.get('trailers')
-            or review.get('reply', '')
-            or review.get('comments')
-            or review.get('note', '')
+            review.get('trailers') or review.get('reply', '') or review.get('comments')
         ):
             viewer.write('[dim]No reply will be sent for this patch.[/dim]')
             return

base-commit: 064bdaa79218f23790cf5792ed87f961e8681555
-- 
2.43.0


             reply	other threads:[~2026-08-25 18:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 18:08 Jason Gunthorpe [this message]
2026-08-25 21:09 ` [PATCH b4] review-tui: show no-reply preview for note-only reviews Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0-v1-0c2c3c276e04+ce2-note_email_jgg@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.