From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9CFC47071 for ; Thu, 16 Nov 2023 10:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345019AbjKPKWL (ORCPT ); Thu, 16 Nov 2023 05:22:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbjKPKWJ (ORCPT ); Thu, 16 Nov 2023 05:22:09 -0500 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B50E519E for ; Thu, 16 Nov 2023 02:22:05 -0800 (PST) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-6c334d2fd4cso775960b3a.2 for ; Thu, 16 Nov 2023 02:22:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700130125; x=1700734925; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YKsco8Z2/A+IeZqsn85TvB1vB1q4DzD7UChREXpP29M=; b=kJy0UFjwh/+d1LBmekTqES3dX3zNTfZ8diKbtP3s2KsdHsRrc4x6S0QJhd1jBTm5xk DejCpvFz2vwmzMGCUpYNeyrA15bzn2xYk/p4UzFB5l/lz0Ld89Kn5mNDiE18TjpBgjh1 +6WnP3qh8Kg/MCFQYvn/FXowa2dUEwhCoosaFvxQlk+jBBGmpEOdEmw4Sd6bI85UewEj YQVafEXyNigUeO22Pw01IApWqv7sADF4cSn2Zl63imgCNDYvN8XTdDZ6UXXW6zz8zpw+ UkmkP9ImY+kENR9u3Qwmr/SN6ZGA8wRo2zW+3RH2l2NbJ7Q/IrRYQrF9Dym09YZhVt2u f22w== X-Gm-Message-State: AOJu0YxhHiEkiieJ+C85bcgQ4f/dea5P97wJ+3TGDERVYe5icd0UzgN6 LUxz/F4VpHuSxkAKog6fE0NE4Vzcfe9IwoFo2tF0H5+851+a X-Google-Smtp-Source: AGHT+IH6bYZLQh20TcXEywrOfK8UMbINU3BVMN+Wli1ochiJd1PBxFYQz+5cfwOtmU7X9Kr3gIab8KVBHpyOv8SnrAnPnquK0Uri MIME-Version: 1.0 X-Received: by 2002:aa7:8f8b:0:b0:6c3:38e5:e59 with SMTP id t11-20020aa78f8b000000b006c338e50e59mr3678017pfs.6.1700130125266; Thu, 16 Nov 2023 02:22:05 -0800 (PST) Date: Thu, 16 Nov 2023 02:22:05 -0800 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000003048a9060a42649f@google.com> Subject: Re: [syzbot] [btrfs?] memory leak in btrfs_ref_tree_mod From: syzbot To: bragathemanick0908@gmail.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: memory leak in add_tree_block BUG: memory leak unreferenced object 0xffff88812611f380 (size 64): comm "syz-executor.5", pid 7474, jiffies 4294960257 (age 171.960s) hex dump (first 32 bytes): 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1076 [] kmalloc include/linux/slab.h:582 [inline] [] add_tree_block+0x39/0x240 fs/btrfs/ref-verify.c:319 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:521 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:573 [inline] [] btrfs_build_ref_tree+0x589/0x850 fs/btrfs/ref-verify.c:1008 [] open_ctree+0x1890/0x2270 fs/btrfs/disk-io.c:3471 [] btrfs_fill_super fs/btrfs/super.c:1154 [inline] [] btrfs_mount_root+0x5af/0x750 fs/btrfs/super.c:1519 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] fc_mount fs/namespace.c:1112 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1142 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1129 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1579 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] do_new_mount fs/namespace.c:3335 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3662 [] do_mount fs/namespace.c:3675 [inline] [] __do_sys_mount fs/namespace.c:3884 [inline] [] __se_sys_mount fs/namespace.c:3861 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3861 [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 [] entry_SYSCALL_64_after_hwframe+0x63/0xcd BUG: memory leak unreferenced object 0xffff88812611f500 (size 64): comm "syz-executor.5", pid 7474, jiffies 4294960257 (age 171.960s) hex dump (first 32 bytes): 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................ 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1076 [] kmalloc include/linux/slab.h:582 [inline] [] kzalloc include/linux/slab.h:703 [inline] [] add_block_entry+0x35/0x320 fs/btrfs/ref-verify.c:270 [] add_tree_block+0x96/0x240 fs/btrfs/ref-verify.c:332 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:521 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:573 [inline] [] btrfs_build_ref_tree+0x589/0x850 fs/btrfs/ref-verify.c:1008 [] open_ctree+0x1890/0x2270 fs/btrfs/disk-io.c:3471 [] btrfs_fill_super fs/btrfs/super.c:1154 [inline] [] btrfs_mount_root+0x5af/0x750 fs/btrfs/super.c:1519 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] fc_mount fs/namespace.c:1112 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1142 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1129 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1579 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] do_new_mount fs/namespace.c:3335 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3662 [] do_mount fs/namespace.c:3675 [inline] [] __do_sys_mount fs/namespace.c:3884 [inline] [] __se_sys_mount fs/namespace.c:3861 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3861 [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 BUG: memory leak unreferenced object 0xffff8881260d4300 (size 96): comm "syz-executor.5", pid 7474, jiffies 4294960257 (age 171.960s) hex dump (first 32 bytes): 00 10 10 00 00 00 00 00 00 10 00 00 00 00 00 00 ................ 01 00 00 00 00 00 00 00 01 00 00 00 01 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1076 [] kmalloc include/linux/slab.h:582 [inline] [] kzalloc include/linux/slab.h:703 [inline] [] add_block_entry+0x4e/0x320 fs/btrfs/ref-verify.c:271 [] add_tree_block+0x96/0x240 fs/btrfs/ref-verify.c:332 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:521 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:573 [inline] [] btrfs_build_ref_tree+0x589/0x850 fs/btrfs/ref-verify.c:1008 [] open_ctree+0x1890/0x2270 fs/btrfs/disk-io.c:3471 [] btrfs_fill_super fs/btrfs/super.c:1154 [inline] [] btrfs_mount_root+0x5af/0x750 fs/btrfs/super.c:1519 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] fc_mount fs/namespace.c:1112 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1142 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1129 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1579 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:611 [] vfs_get_tree+0x2a/0x110 fs/super.c:1519 [] do_new_mount fs/namespace.c:3335 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3662 [] do_mount fs/namespace.c:3675 [inline] [] __do_sys_mount fs/namespace.c:3884 [inline] [] __se_sys_mount fs/namespace.c:3861 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3861 [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 Tested on: commit: 25aa0beb Merge tag 'net-6.5-rc6' of git://git.kernel.o.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git console output: https://syzkaller.appspot.com/x/log.txt?x=11a0c5b7680000 kernel config: https://syzkaller.appspot.com/x/.config?x=2bf8962e4f7984f4 dashboard link: https://syzkaller.appspot.com/bug?extid=d66de4cbf532749df35f compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 patch: https://syzkaller.appspot.com/x/patch.diff?x=1799b938e80000