From: syzbot <syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com>
To: jack@suse.com, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, tytso@mit.edu
Subject: [syzbot] [ext4?] possible deadlock in jbd2_log_wait_commit
Date: Tue, 28 Feb 2023 13:04:51 -0800 [thread overview]
Message-ID: <00000000000052865105f5c8f2c8@google.com> (raw)
Hello,
syzbot found the following issue on:
HEAD commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1306a9acc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2a637f17a777/disk-e492250d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a9bfdbca6f2d/vmlinux-e492250d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/dc120ec8d398/bzImage-e492250d.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-12944-ge492250d5252 #0 Not tainted
------------------------------------------------------
syz-executor.5/13484 is trying to acquire lock:
ffff88814c5be990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x153/0x4a0 fs/jbd2/journal.c:692
but task is already holding lock:
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline]
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}:
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
inode_lock_nested include/linux/fs.h:793 [inline]
ext4_rename fs/ext4/namei.c:3879 [inline]
ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (jbd2_handle){++++}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692
jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133
ext4_rename fs/ext4/namei.c:4014 [inline]
ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);
*** DEADLOCK ***
3 locks held by syz-executor.5/13484:
#0: ffff88814c5ba460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:394
#1: ffff8880764b5440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x186/0x1a0
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline]
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193
stack backtrace:
CPU: 0 PID: 13484 Comm: syz-executor.5 Not tainted 6.2.0-syzkaller-12944-ge492250d5252 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692
jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133
ext4_rename fs/ext4/namei.c:4014 [inline]
ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd61e08c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd61ee4f168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007fd61e1abf80 RCX: 00007fd61e08c0f9
RDX: 0000000000000003 RSI: 0000000020005780 RDI: 0000000000000004
RBP: 00007fd61e0e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000200016c0 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fffc899a5ef R14: 00007fd61ee4f300 R15: 0000000000022000
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
next reply other threads:[~2023-02-28 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:04 syzbot [this message]
2023-03-01 1:46 ` [syzbot] [ext4?] possible deadlock in jbd2_log_wait_commit syzbot
2023-03-01 10:08 ` syzbot
2023-03-01 12:42 ` Jan Kara
[not found] <20230301025550.2322-1-hdanton@sina.com>
2023-03-01 9:46 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000000000052865105f5c8f2c8@google.com \
--to=syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.