From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9512C3DA63 for ; Wed, 24 Jul 2024 14:10:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0485A6B007B; Wed, 24 Jul 2024 10:10:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3A566B0082; Wed, 24 Jul 2024 10:10:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A166B0085; Wed, 24 Jul 2024 10:10:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C41156B007B for ; Wed, 24 Jul 2024 10:10:38 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 70C46C0A15 for ; Wed, 24 Jul 2024 14:10:38 +0000 (UTC) X-FDA: 82374831756.15.CCB3E69 Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by imf02.hostedemail.com (Postfix) with ESMTP id BE17C80018 for ; Wed, 24 Jul 2024 14:10:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of 3WQuhZgkbADAeklWMXXQdMbbUP.SaaSXQgeQdOaZfQZf.OaY@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.197 as permitted sender) smtp.mailfrom=3WQuhZgkbADAeklWMXXQdMbbUP.SaaSXQgeQdOaZfQZf.OaY@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721830211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=Rke9SrdPSSHVahZflKTJUGygjJ7frSja8B/83dVEu70=; b=2eKNEXl9w1ZCxi8wX1yelz4YPuaRHeEYkfch+ju4XYgfAAyRfBZhQP/JAx5daAc6++14BP tPR+Y7ZChcEN+sQR90RWC0GYuwecLneEH60DG9yaD3DnK8KESsOIgY94WIhuFg21aQ3PRz Ix8Bm/ePutP4wluBJhvyMd7UQkCFyAI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of 3WQuhZgkbADAeklWMXXQdMbbUP.SaaSXQgeQdOaZfQZf.OaY@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.197 as permitted sender) smtp.mailfrom=3WQuhZgkbADAeklWMXXQdMbbUP.SaaSXQgeQdOaZfQZf.OaY@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721830211; a=rsa-sha256; cv=none; b=3TKlaBFcJdVgrj37BrajNbbDFB+FUnc/EXNDzMOKoClIWpCe+8Zdz9ehKW72i32VM3Ugzy JXz/wzcFyvXetV+R545KWopjBcf0FAQObFvQTw2xQfyz7mZ2w/MKqcbHcHrRQBQIORgeeF Z2e0cVEAAHj5aPEsZXF+HedqSZs3T1k= Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-39a1d269982so7653835ab.1 for ; Wed, 24 Jul 2024 07:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721830235; x=1722435035; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rke9SrdPSSHVahZflKTJUGygjJ7frSja8B/83dVEu70=; b=b88D83/9n4g+wo5ps4R9CQXzUlV2Cx6swtw3aK9DCKaoH0NvNtC6XbaiOG3gpoI51y n6T0r+Cc+xMFjicz+5MY/S/ykC78vRheaCgjcgOfKWfoTY8Zcp0TOzCpZNNXG/EfMRqp zPA918ex4PWTAe3JLLeh3HFa1lxHGT4Iw2yPfeEpLEWRmmB+eUxfd0Era04hXxozyl86 w04Fq+KD+XurQmyEO6l5rKQnRblgiKN2rFsv733uf/pXMtvoXfx7efXEOWh0njCt+Oz5 T7lYpspSHgbWCg1V+ho1ulHeWXJvn2T5rJaxiJgscqnPbZvwgg8iOm9NQrdIC584c7In QB4g== X-Forwarded-Encrypted: i=1; AJvYcCVTz4gtvcTxXAH3N2hRVUyy1BND18gXRseEoVk8NX2EmenU5hR6AW2W0IvAnVdLFebgs389KHW5YFtM3xm71BIAgrk= X-Gm-Message-State: AOJu0YyehVTSIJztzPdEPm5PuWtqXGbKQPiJ3kJpbpxe09DgzHrMch5a Jh3ccEg7qGLOKP6noEcisyZkOgMoE3JS0Cbrant3yimV7FZnmivmfMR6yS51zRxfhJcjoQ7i6Mx A/XBp9O463LQF72iL0B28WVHzM3fmnN8oLzw+pKCo17+P94skRS6wqoM= X-Google-Smtp-Source: AGHT+IGA2MjPEBsrVDJ5Bo4PW3RlcJ5HqVSl0sz616yLVYq/Bw1N214YkMLBHbWEziJZm+rx912MO9KgzrXACgQzZfMG1+DzbwuJ MIME-Version: 1.0 X-Received: by 2002:a05:6638:831c:b0:4c0:9380:a260 with SMTP id 8926c6da1cb9f-4c28ef5e79dmr79435173.3.1721830233807; Wed, 24 Jul 2024 07:10:33 -0700 (PDT) Date: Wed, 24 Jul 2024 07:10:33 -0700 In-Reply-To: <0000000000006bca48061692b790@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000733373061dfed75d@google.com> Subject: Re: [syzbot] [mm?] possible deadlock in gup_fast_fallback From: syzbot To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BE17C80018 X-Stat-Signature: hdi36mexq8sj8hc57hc5mmsepyo61zdt X-Rspam-User: X-HE-Tag: 1721830235-545147 X-HE-Meta: U2FsdGVkX19PJLKI3Zi79dqaehrJD1ODd9/LBFFHDyJeLhZwkOb+7btqzj3UD+l4U7TmsSWp/OMJzT3a52JzlnEvDQMoo2D5WHCNFgO+25c4xPrIQFNDyMA9vNdoQGktMEWxuBDbIxs1ZIUnaZ1gEodkHmddu4aqnwEgBCx+tRreMPkwWulkJMUJGF6ZDPZ0jY6+UKM0KRpmz7Lpzbw3DNsyuMFD5cw6JSVM7a4BwpVPxlRbT5WiDsQh+IlNlrKnwKGMDQ58rchw3XukznuSNgHF8nEZy0Oc18o09yU2vG7+Cgp7arltfkBiokhZ6YoTE9Uskee3A1eA9Gpigztzg07yVexmWNlS0lDviaVbtSVCZmWbXLyKv3pVxUZt3GBfv9cjeeMurRc24ukBZ7cp/yvB1vpdEaAmG0g3MSnul+Nju0beYwLWmwzhRR1MPL+6jkqMm43xFD2ahrZZpq2Nx+JzxS8SQPAhSKNLdkvQrZz+bwjPpmS6J4Qed6hkKvDqu1Ke/MUf38bUqRcNzFvECfsh5uUg40aMNlRUFazwxOLDCErq3FhKNdAP/GItmQugw3JlRLcrLihilQmBAAwpS88CO1gsHCTt/cyBNVisQhT/pu/zYHGJw4gYIkYIm4yJ6nutT1EcIcVFZqFyn0OuwOh//PEMeF3QSSw3zkvQJ7jLkobm2ML0xeoT2+sIcBuZzmGu5tlYwbKCL6lVokA6fnpzbup+wRjbqiG2fRl+9j9FTu5DnN9DzmNb2zxQjljt2Ztn9Av2q04SdaeqGzDuLkwIy9w4ZIU23y1ZZQM2Bgod3IIvx2vb3YTNDwR5QIbaE7M9oVtXRaHzfEZ+W32Ble203SpF9030y16N6kUgyIRcfwQWwrDyA82+AO3/uNbFAPUe5pECbEfqOOpgadrY6HTo/7dqZu/JYSTV7U1xnOFTb1OHtXdiWCd07+wA+Ms39tnOzhGulPPa0iQlfKb c3gmZCxS k22lSlCQkHNmNO+vaiYb3TobPcTolYphJTH4p0lPEvMGesqzLNP368ZEARtFDt2s0YYLt0qfKjSJQgAthkZX2SmB2a4UPt6oz40Wok8Rckk6Z3TJnkFd91xLxtkH+nieCbTZR/KYzfp03nxpDhkhBqKSqEcjgjwyE+RieKSloX69acsFkFDVNlTkMlbDELhZSGvb2+6oYN+U098EZ7aZ9cHwEXn0VWhFG/pTv125bLR2jVY43kCkZjes0eO3yP70r0BFnz5Au5lYvt54ALSii1yp7LgFtZ2ts4tkMNZIQyE8ymnrWamOP/tGBcq4PIHvOXCV/KwgwUJ3NdHHKQJIgWfb+DFZC0/xjHVtCuF9fvI++H52LmjRXM61X5EFcxg8Ug54O+5aUI+EDNMBC3A8JvkIQB0WX+ZTxoWHEoryrm+H6TQHRzPlrVZWtz2AeFTGgrE/VgXv+7pXgNns0tDw3P1j1XwyX4ofAnFdlH5a72DSDaGKxUZublaMzfPM0qZbAZU00PRYXrk3kP/VsT8FUvVIkifc4T2HsFKyCWxlq60AmamU+cHeJqRs9eNCdndN+NYvhgvl6mqqz25UibvOXfUfhbUOjGCC94J7N52j+fbjHv5WtaefmcFP4KlWgZVylXsGJ7c2UWDatuW086/aJfWs5XW8x7OcMTphf+9MSnTEQNcIpTu/MGV9YZ+N4/Z2WyeB09Bz6kV+wQQMTQAs06CsN22dvB4kVyQTs0MPf0aNcY8idNXFN3/2VIpiSvbHrMyoppKCHfVE/seq53Oy8q7Q/Qn+D8LZG2Y9mZ43dI7vf6anRCvug/inARimsBQHAdF+dD5UJkT6+gkmK863Mvx33BuhcfKxaTswtPnkVM2NXI5VhmXmuliaJ3kq30p0eg/FyAi/SsPvrkRsRtph5EvXGnWZC0TjEHhXAmg4p4NYjlcjmZ5HSZfoWu0421wxVLqC6YmT7p/jlYB8GmuZbt+IN9H8d ciZpCC08 0ttHpT4gNMEVfRUAcVagZPmpOKOwB3LnT+b9qp9kkk7rF5CAprA2EtPvb1o3gFW3FCBfM3DOSxGGwIcgP8CkXg4tibCe5S31dod2k19rlEpwe0R15/4KRwb5Wu0gRARfnO4l3qwYppZytlGH8cGlnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: syzbot has found a reproducer for the following issue on: HEAD commit: 786c8248dbd3 Merge tag 'perf-tools-fixes-for-v6.11-2024-07.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=15009665980000 kernel config: https://syzkaller.appspot.com/x/.config?x=d732ba79a3d0331b dashboard link: https://syzkaller.appspot.com/bug?extid=63ba90b81c16b86379bd compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=162862e3980000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10d14ce3980000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/a022c722f874/disk-786c8248.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/860e2faa9749/vmlinux-786c8248.xz kernel image: https://storage.googleapis.com/syzbot-assets/518e4afe4ede/bzImage-786c8248.xz mounted in repro: https://storage.googleapis.com/syzbot-assets/09d1622c5e09/mount_0.gz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+63ba90b81c16b86379bd@syzkaller.appspotmail.com ntfs3: loop0: Mark volume as dirty due to NTFS errors ntfs3: loop0: Failed to load $Extend (-116). ntfs3: loop0: Failed to initialize $Extend. ====================================================== WARNING: possible circular locking dependency detected 6.10.0-syzkaller-12246-g786c8248dbd3 #0 Not tainted ------------------------------------------------------ syz-executor288/5099 is trying to acquire lock: ffff888063210b18 (&mm->mmap_lock){++++}-{3:3}, at: gup_fast_fallback+0x233/0x2b50 mm/gup.c:3367 but task is already holding lock: ffff88807a2be310 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:819 [inline] ffff88807a2be310 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: ntfs_file_write_iter+0x24a/0x740 fs/ntfs3/file.c:1166 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759 down_write+0x99/0x220 kernel/locking/rwsem.c:1579 inode_lock include/linux/fs.h:799 [inline] ntfs_file_mmap+0x5bf/0x850 fs/ntfs3/file.c:368 call_mmap include/linux/fs.h:2129 [inline] mmap_region+0xe8f/0x2090 mm/mmap.c:2927 do_mmap+0x8ad/0xfa0 mm/mmap.c:1438 vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:588 ksys_mmap_pgoff+0x4f1/0x720 mm/mmap.c:1484 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3133 [inline] check_prevs_add kernel/locking/lockdep.c:3252 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868 __lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759 gup_fast_fallback+0x24c/0x2b50 mm/gup.c:3367 pin_user_pages_fast+0xcc/0x160 mm/gup.c:3491 iov_iter_extract_user_pages lib/iov_iter.c:1583 [inline] iov_iter_extract_pages+0x3db/0x720 lib/iov_iter.c:1646 dio_refill_pages fs/direct-io.c:173 [inline] dio_get_page fs/direct-io.c:214 [inline] do_direct_IO fs/direct-io.c:916 [inline] __blockdev_direct_IO+0x144c/0x4890 fs/direct-io.c:1249 blockdev_direct_IO include/linux/fs.h:3212 [inline] ntfs_direct_IO+0x195/0x370 fs/ntfs3/inode.c:801 generic_file_direct_write+0x130/0x350 mm/filemap.c:3941 __generic_file_write_iter+0x129/0x230 mm/filemap.c:4107 ntfs_file_write_iter+0x663/0x740 fs/ntfs3/file.c:1193 do_iter_readv_writev+0x60a/0x890 vfs_writev+0x37c/0xbb0 fs/read_write.c:971 do_pwritev fs/read_write.c:1072 [inline] __do_sys_pwritev2 fs/read_write.c:1131 [inline] __se_sys_pwritev2+0x1ca/0x2d0 fs/read_write.c:1122 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#14); lock(&mm->mmap_lock); lock(&sb->s_type->i_mutex_key#14); rlock(&mm->mmap_lock); *** DEADLOCK *** 2 locks held by syz-executor288/5099: #0: ffff888023990420 (sb_writers#9){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2876 [inline] #0: ffff888023990420 (sb_writers#9){.+.+}-{0:0}, at: vfs_writev+0x2d4/0xbb0 fs/read_write.c:969 #1: ffff88807a2be310 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:819 [inline] #1: ffff88807a2be310 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: ntfs_file_write_iter+0x24a/0x740 fs/ntfs3/file.c:1166 stack backtrace: CPU: 0 UID: 0 PID: 5099 Comm: syz-executor288 Not tainted 6.10.0-syzkaller-12246-g786c8248dbd3 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call Trace: __dump_stack lib/dump_stack.c:93 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2186 check_prev_add kernel/locking/lockdep.c:3133 [inline] check_prevs_add kernel/locking/lockdep.c:3252 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868 __lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759 gup_fast_fallback+0x24c/0x2b50 mm/gup.c:3367 pin_user_pages_fast+0xcc/0x160 mm/gup.c:3491 iov_iter_extract_user_pages lib/iov_iter.c:1583 [inline] iov_iter_extract_pages+0x3db/0x720 lib/iov_iter.c:1646 dio_refill_pages fs/direct-io.c:173 [inline] dio_get_page fs/direct-io.c:214 [inline] do_direct_IO fs/direct-io.c:916 [inline] __blockdev_direct_IO+0x144c/0x4890 fs/direct-io.c:1249 blockdev_direct_IO include/linux/fs.h:3212 [inline] ntfs_direct_IO+0x195/0x370 fs/ntfs3/inode.c:801 generic_file_direct_write+0x130/0x350 mm/filemap.c:3941 __generic_file_write_iter+0x129/0x230 mm/filemap.c:4107 ntfs_file_write_iter+0x663/0x740 fs/ntfs3/file.c:1193 do_iter_readv_writev+0x60a/0x890 vfs_writev+0x37c/0xbb0 fs/read_write.c:971 do_pwritev fs/read_write.c:1072 [inline] __do_sys_pwritev2 fs/read_write.c:1131 [inline] __se_sys_pwritev2+0x1ca/0x2d0 fs/read_write.c:1122 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb9777dcb59 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffe15926128 EFLAGS: 00000246 ORIG_RAX: 0000000000000148 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fb9777dcb59 RDX: 0000000000000001 RSI: 0000000020000240 RDI: 0000000000000005 RBP: 00007fb97786f5f0 R08: 0000000000000000 R09: 0000000000000003 R10: 0000000000007000 R11: 0000000000000246 R12: 00007ffe15926160 R13: 00007ffe15926388 R14: 431bde82d7b634db R15: 00007fb97782503b --- If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing.