From: syzbot <syzbot+b4d54814b339b5c6bbd4@syzkaller.appspotmail.com>
To: andriy.shevchenko@linux.intel.com, ezequiel@vanguardiasur.com.ar,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-usb@vger.kernel.org, mchehab@kernel.org, royale@zerezo.com,
syzkaller-bugs@googlegroups.com
Subject: Re: memory leak in zr364xx_probe
Date: Thu, 31 Dec 2020 12:56:10 -0800 [thread overview]
Message-ID: <00000000000079b74605b7c8da15@google.com> (raw)
In-Reply-To: <CAAEAJfADBQpyfgBjWtnnF-y0g_jRryrcHQd_J-123KxSrid5=Q@mail.gmail.com>
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
BUG: unable to handle kernel NULL pointer dereference in __videobuf_free
zr364xx 4-1:0.0: model 06d6:003b detected
usb 4-1: 320x240 mode selected
zr364xx: start read pipe failed
BUG: kernel NULL pointer dereference, address: 0000000000000000
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 0 P4D 0
Oops: 0000 [#1] PREEMPT SMP
CPU: 1 PID: 8717 Comm: kworker/1:4 Not tainted 5.10.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:__videobuf_free+0x62/0x180 drivers/media/v4l2-core/videobuf-core.c:243
Code: 9d 70 01 00 00 31 ff 83 e3 03 89 de e8 b7 da 4a fe 84 db 0f 85 00 01 00 00 e8 2a e1 4a fe 48 8b 85 68 01 00 00 bf 03 10 26 12 <44> 8b 20 44 89 e6 e8 d3 da 4a fe 41 81 fc 03 10 26 12 0f 85 c4 2c
RSP: 0018:ffffc900024ef7b8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff82e82989
RDX: ffff88811813d040 RSI: ffffffff82e82996 RDI: 0000000012261003
RBP: ffff888125921780 R08: ffff888125ffe008 R09: 00000000000008fd
R10: 0000000000000000 R11: 3a7878343633727a R12: 0000000000000001
R13: ffff888125921000 R14: ffffc900032b1000 R15: 00000000ffffffa6
FS: 0000000000000000(0000) GS:ffff88813bd00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000109bb5000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
videobuf_mmap_free+0x1f/0x60 drivers/media/v4l2-core/videobuf-core.c:377
zr364xx_release+0x26/0xa0 drivers/media/usb/zr364xx/zr364xx.c:1192
v4l2_device_release drivers/media/v4l2-core/v4l2-device.c:51 [inline]
kref_put include/linux/kref.h:65 [inline]
v4l2_device_put+0x82/0xc0 drivers/media/v4l2-core/v4l2-device.c:56
zr364xx_probe+0x80c/0x823 drivers/media/usb/zr364xx/zr364xx.c:1536
usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
really_probe+0x159/0x480 drivers/base/dd.c:554
driver_probe_device+0x84/0x100 drivers/base/dd.c:738
__device_attach_driver+0xee/0x110 drivers/base/dd.c:844
bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
__device_attach+0x122/0x250 drivers/base/dd.c:912
bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
device_add+0x5ac/0xc30 drivers/base/core.c:2936
usb_set_configuration+0x9de/0xb90 drivers/usb/core/message.c:2159
usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
really_probe+0x159/0x480 drivers/base/dd.c:554
driver_probe_device+0x84/0x100 drivers/base/dd.c:738
__device_attach_driver+0xee/0x110 drivers/base/dd.c:844
bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
__device_attach+0x122/0x250 drivers/base/dd.c:912
bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
device_add+0x5ac/0xc30 drivers/base/core.c:2936
usb_new_device.cold+0x166/0x578 drivers/usb/core/hub.c:2554
hub_port_connect drivers/usb/core/hub.c:5222 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5362 [inline]
port_event drivers/usb/core/hub.c:5508 [inline]
hub_event+0x144a/0x20d0 drivers/usb/core/hub.c:5590
process_one_work+0x27d/0x590 kernel/workqueue.c:2272
worker_thread+0x59/0x5d0 kernel/workqueue.c:2418
kthread+0x178/0x1b0 kernel/kthread.c:292
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296
Modules linked in:
CR2: 0000000000000000
---[ end trace 90e0be95dcb7e0d1 ]---
RIP: 0010:__videobuf_free+0x62/0x180 drivers/media/v4l2-core/videobuf-core.c:243
Code: 9d 70 01 00 00 31 ff 83 e3 03 89 de e8 b7 da 4a fe 84 db 0f 85 00 01 00 00 e8 2a e1 4a fe 48 8b 85 68 01 00 00 bf 03 10 26 12 <44> 8b 20 44 89 e6 e8 d3 da 4a fe 41 81 fc 03 10 26 12 0f 85 c4 2c
RSP: 0018:ffffc900024ef7b8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff82e82989
RDX: ffff88811813d040 RSI: ffffffff82e82996 RDI: 0000000012261003
RBP: ffff888125921780 R08: ffff888125ffe008 R09: 00000000000008fd
R10: 0000000000000000 R11: 3a7878343633727a R12: 0000000000000001
R13: ffff888125921000 R14: ffffc900032b1000 R15: 00000000ffffffa6
FS: 0000000000000000(0000) GS:ffff88813bd00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000109bb5000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Tested on:
commit: a1714d22 media: zr364xx: Fix memory leak in ->probe()
git tree: https://gitlab.collabora.com/linux/0day.git
console output: https://syzkaller.appspot.com/x/log.txt?x=11415e0b500000
kernel config: https://syzkaller.appspot.com/x/.config?x=ec2338be23ae163e
dashboard link: https://syzkaller.appspot.com/bug?extid=b4d54814b339b5c6bbd4
compiler: gcc (GCC) 10.1.0-syz 20200507
next prev parent reply other threads:[~2020-12-31 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 15:25 memory leak in zr364xx_probe syzbot
2020-12-30 21:10 ` Andy Shevchenko
2020-12-31 20:47 ` Ezequiel Garcia
2020-12-31 20:56 ` syzbot [this message]
2021-01-05 15:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000000000079b74605b7c8da15@google.com \
--to=syzbot+b4d54814b339b5c6bbd4@syzkaller.appspotmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=royale@zerezo.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.