All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+ab134185af9ef88dfed5@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [syzbot] Re: [syzbot] [ocfs2?] WARNING: bad unlock balance in ocfs2_read_blocks
Date: Sun, 18 Aug 2024 19:01:08 -0700	[thread overview]
Message-ID: <000000000000b81092061fffae2b@google.com> (raw)
In-Reply-To: <0000000000007541d9061ff83615@google.com>

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.

***

Subject: Re: [syzbot] [ocfs2?] WARNING: bad unlock balance in ocfs2_read_blocks
Author: lizhi.xu@windriver.com

remove metadata io lock when sb getblk fail

#syz test: upstream c3f2d783a459

diff --git a/fs/ocfs2/buffer_head_io.c b/fs/ocfs2/buffer_head_io.c
index cdb9b9bdea1f..e62c7e1de4eb 100644
--- a/fs/ocfs2/buffer_head_io.c
+++ b/fs/ocfs2/buffer_head_io.c
@@ -235,7 +235,6 @@ int ocfs2_read_blocks(struct ocfs2_caching_info *ci, u64 block, int nr,
 		if (bhs[i] == NULL) {
 			bhs[i] = sb_getblk(sb, block++);
 			if (bhs[i] == NULL) {
-				ocfs2_metadata_cache_io_unlock(ci);
 				status = -ENOMEM;
 				mlog_errno(status);
 				/* Don't forget to put previous bh! */

  reply	other threads:[~2024-08-19  2:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-18 17:06 [syzbot] [ocfs2?] WARNING: bad unlock balance in ocfs2_read_blocks syzbot
2024-08-19  2:01 ` syzbot [this message]
2024-08-19  2:51 ` [PATCH] ocfs2: remove unreasonable unlock Lizhi Xu
2024-08-20  4:04   ` heming.zhao
2024-08-20  5:59     ` Lizhi Xu
2024-08-20  6:55     ` [PATCH V2 1/2] " Lizhi Xu
2024-08-20  6:55       ` [PATCH V2 2/2] ocfs2: Fix uaf in ocfs2_read_blocks Lizhi Xu
2024-08-20  7:15         ` Heming Zhao
2024-08-20  7:37           ` [PATCH V3] ocfs2: Fix uaf in ocfs2_set_buffer_uptodate Lizhi Xu
2024-08-20  8:32             ` Heming Zhao
2024-08-20  9:45               ` [PATCH V3 1/2] ocfs2: remove unreasonable unlock Lizhi Xu
2024-08-20  9:45                 ` [PATCH V3 2/2] ocfs2: Fix uaf in ocfs2_set_buffer_uptodate Lizhi Xu
2024-08-20 11:32                   ` Heming Zhao
2024-08-20 13:44                     ` [PATCH] ocfs2: remove unreasonable unlock Lizhi Xu
2024-08-21  0:08                   ` [PATCH V3 2/2] ocfs2: Fix uaf in ocfs2_set_buffer_uptodate Joseph Qi
2024-08-21  2:34                     ` Joseph Qi
2024-08-21  2:39                       ` Heming Zhao
2024-08-21  5:55                         ` Lizhi Xu
2024-08-21  6:14                           ` [PATCH V4 2/2] ocfs2: Fix possible null-ptr-deref " Lizhi Xu
2024-08-21  6:23                             ` heming.zhao
2024-08-21  6:55                               ` Lizhi Xu
2024-08-21  7:37                                 ` heming.zhao
2024-08-21  7:58                                   ` Joseph Qi
2024-08-21  9:14                                     ` Lizhi Xu
2024-08-21 11:40                                       ` Heming Zhao
2024-08-21 21:39                                         ` Andrew Morton
2024-09-02  0:54                                           ` Andrew Morton
2024-09-02  1:03                                             ` Heming Zhao
2024-09-02  2:20                                               ` Joseph Qi
2024-09-02 14:23                                                 ` Lizhi Xu
2024-08-21  7:59                             ` Joseph Qi
2024-08-20 23:55                 ` [PATCH V3 1/2] ocfs2: remove unreasonable unlock Joseph Qi
2024-08-20  7:28       ` [PATCH V2 " Heming Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000b81092061fffae2b@google.com \
    --to=syzbot+ab134185af9ef88dfed5@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.