From: syzbot <syzbot+97b4444a5bd7bf30b3a8@syzkaller.appspotmail.com>
To: n.zhandarovich@fintech.ru
Cc: linux-kernel@vger.kernel.org, n.zhandarovich@fintech.ru,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [crypto?] KMSAN: uninit-value in skcipher_walk_virt
Date: Fri, 03 May 2024 07:41:07 -0700 [thread overview]
Message-ID: <000000000000c1a36406178db530@google.com> (raw)
In-Reply-To: <20240503144055.3820-1-n.zhandarovich@fintech.ru>
> req->base.flags were not initialized, zero might suit in this case.
> Do it with skcipher_request_set_callback() as it's common practice.
>
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
This crash does not have a reproducer. I cannot test it.
>
> ---
> fs/bcachefs/checksum.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/bcachefs/checksum.c b/fs/bcachefs/checksum.c
> index 7ed779b411f6..088fd2e7bdf1 100644
> --- a/fs/bcachefs/checksum.c
> +++ b/fs/bcachefs/checksum.c
> @@ -102,6 +102,7 @@ static inline int do_encrypt_sg(struct crypto_sync_skcipher *tfm,
> int ret;
>
> skcipher_request_set_sync_tfm(req, tfm);
> + skcipher_request_set_callback(req, 0, NULL, NULL);
> skcipher_request_set_crypt(req, sg, sg, len, nonce.d);
>
> ret = crypto_skcipher_encrypt(req);
prev parent reply other threads:[~2024-05-03 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:24 [syzbot] [crypto?] KMSAN: uninit-value in skcipher_walk_virt syzbot
2024-05-03 12:34 ` Aleksandr Nogikh
2024-05-04 17:20 ` Kent Overstreet
2024-05-06 10:52 ` Ard Biesheuvel
2024-05-03 14:40 ` Nikita Zhandarovich
2024-05-03 14:41 ` syzbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000000000000c1a36406178db530@google.com \
--to=syzbot+97b4444a5bd7bf30b3a8@syzkaller.appspotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n.zhandarovich@fintech.ru \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.