All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+a2ff6fa45162a5ed4dd3@syzkaller.appspotmail.com>
To: coreteam@netfilter.org, davem@davemloft.net, fw@strlen.de,
	kadlec@netfilter.org, kuba@kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, pablo@netfilter.org,
	syzkaller-bugs@googlegroups.com
Subject: memory leak in nf_tables_parse_netdev_hooks (2)
Date: Mon, 02 Mar 2020 10:13:12 -0800	[thread overview]
Message-ID: <000000000000ebdc39059fe32327@google.com> (raw)

Hello,

syzbot found the following crash on:

HEAD commit:    63623fd4 Merge tag 'for-linus' of git://git.kernel.org/pub..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10060a2de00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6951e37c8d613538
dashboard link: https://syzkaller.appspot.com/bug?extid=a2ff6fa45162a5ed4dd3
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15acfa81e00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=172f9d09e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+a2ff6fa45162a5ed4dd3@syzkaller.appspotmail.com

executing program
BUG: memory leak
unreferenced object 0xffff88810b2b2080 (size 96):
  comm "syz-executor089", pid 7270, jiffies 4294941532 (age 13.520s)
  hex dump (first 32 bytes):
    00 21 2b 0b 81 88 ff ff 40 06 37 1a 81 88 ff ff  .!+.....@.7.....
    20 47 c7 82 ff ff ff ff 00 60 2e 2a 81 88 ff ff   G.......`.*....
  backtrace:
    [<00000000f3a29219>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
    [<00000000f3a29219>] slab_post_alloc_hook mm/slab.h:586 [inline]
    [<00000000f3a29219>] slab_alloc mm/slab.c:3320 [inline]
    [<00000000f3a29219>] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3549
    [<000000005471dca6>] kmalloc include/linux/slab.h:555 [inline]
    [<000000005471dca6>] nft_netdev_hook_alloc+0x3f/0xd0 net/netfilter/nf_tables_api.c:1653
    [<00000000547b3e6d>] nf_tables_parse_netdev_hooks+0xaa/0x220 net/netfilter/nf_tables_api.c:1702
    [<000000005c4bc909>] nf_tables_flowtable_parse_hook net/netfilter/nf_tables_api.c:6097 [inline]
    [<000000005c4bc909>] nf_tables_newflowtable+0x407/0x930 net/netfilter/nf_tables_api.c:6297
    [<000000004e57b3ed>] nfnetlink_rcv_batch+0x353/0x8c0 net/netfilter/nfnetlink.c:433
    [<0000000095bbce6c>] nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:543 [inline]
    [<0000000095bbce6c>] nfnetlink_rcv+0x189/0x1c0 net/netfilter/nfnetlink.c:561
    [<000000002a197f31>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
    [<000000002a197f31>] netlink_unicast+0x223/0x310 net/netlink/af_netlink.c:1329
    [<000000002fe97501>] netlink_sendmsg+0x2c0/0x570 net/netlink/af_netlink.c:1918
    [<0000000072a2eef7>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<0000000072a2eef7>] sock_sendmsg+0x54/0x70 net/socket.c:672
    [<0000000049691ba6>] ____sys_sendmsg+0x2d0/0x300 net/socket.c:2343
    [<00000000466e69b2>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2397
    [<0000000086270dd0>] __sys_sendmsg+0x80/0xf0 net/socket.c:2430
    [<000000001b2586e4>] __do_sys_sendmsg net/socket.c:2439 [inline]
    [<000000001b2586e4>] __se_sys_sendmsg net/socket.c:2437 [inline]
    [<000000001b2586e4>] __x64_sys_sendmsg+0x23/0x30 net/socket.c:2437
    [<0000000005b8b511>] do_syscall_64+0x73/0x220 arch/x86/entry/common.c:294
    [<000000005e09659b>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88810b2b2100 (size 96):
  comm "syz-executor089", pid 7270, jiffies 4294941532 (age 13.520s)
  hex dump (first 32 bytes):
    40 06 37 1a 81 88 ff ff 80 20 2b 0b 81 88 ff ff  @.7...... +.....
    20 47 c7 82 ff ff ff ff 00 e0 1d 25 81 88 ff ff   G.........%....
  backtrace:
    [<00000000f3a29219>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
    [<00000000f3a29219>] slab_post_alloc_hook mm/slab.h:586 [inline]
    [<00000000f3a29219>] slab_alloc mm/slab.c:3320 [inline]
    [<00000000f3a29219>] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3549
    [<000000005471dca6>] kmalloc include/linux/slab.h:555 [inline]
    [<000000005471dca6>] nft_netdev_hook_alloc+0x3f/0xd0 net/netfilter/nf_tables_api.c:1653
    [<00000000547b3e6d>] nf_tables_parse_netdev_hooks+0xaa/0x220 net/netfilter/nf_tables_api.c:1702
    [<000000005c4bc909>] nf_tables_flowtable_parse_hook net/netfilter/nf_tables_api.c:6097 [inline]
    [<000000005c4bc909>] nf_tables_newflowtable+0x407/0x930 net/netfilter/nf_tables_api.c:6297
    [<000000004e57b3ed>] nfnetlink_rcv_batch+0x353/0x8c0 net/netfilter/nfnetlink.c:433
    [<0000000095bbce6c>] nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:543 [inline]
    [<0000000095bbce6c>] nfnetlink_rcv+0x189/0x1c0 net/netfilter/nfnetlink.c:561
    [<000000002a197f31>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
    [<000000002a197f31>] netlink_unicast+0x223/0x310 net/netlink/af_netlink.c:1329
    [<000000002fe97501>] netlink_sendmsg+0x2c0/0x570 net/netlink/af_netlink.c:1918
    [<0000000072a2eef7>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<0000000072a2eef7>] sock_sendmsg+0x54/0x70 net/socket.c:672
    [<0000000049691ba6>] ____sys_sendmsg+0x2d0/0x300 net/socket.c:2343
    [<00000000466e69b2>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2397
    [<0000000086270dd0>] __sys_sendmsg+0x80/0xf0 net/socket.c:2430
    [<000000001b2586e4>] __do_sys_sendmsg net/socket.c:2439 [inline]
    [<000000001b2586e4>] __se_sys_sendmsg net/socket.c:2437 [inline]
    [<000000001b2586e4>] __x64_sys_sendmsg+0x23/0x30 net/socket.c:2437
    [<0000000005b8b511>] do_syscall_64+0x73/0x220 arch/x86/entry/common.c:294
    [<000000005e09659b>] entry_SYSCALL_64_after_hwframe+0x44/0xa9



---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

                 reply	other threads:[~2020-03-02 18:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000ebdc39059fe32327@google.com \
    --to=syzbot+a2ff6fa45162a5ed4dd3@syzkaller.appspotmail.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.