From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1603C678D5 for ; Sun, 5 Mar 2023 01:51:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE6D86B0072; Sat, 4 Mar 2023 20:51:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B97AA6B0073; Sat, 4 Mar 2023 20:51:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5ECF6B0074; Sat, 4 Mar 2023 20:51:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 98FE76B0072 for ; Sat, 4 Mar 2023 20:51:52 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6F630140440 for ; Sun, 5 Mar 2023 01:51:52 +0000 (UTC) X-FDA: 80533168464.01.06BB4CE Received: from mail-il1-f205.google.com (mail-il1-f205.google.com [209.85.166.205]) by imf05.hostedemail.com (Postfix) with ESMTP id AD797100009 for ; Sun, 5 Mar 2023 01:51:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf05.hostedemail.com: domain of 3tfUDZAkbANYKQRC2DD6J2HHA5.8GG8D6MK6J4GFL6FL.4GE@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.205 as permitted sender) smtp.mailfrom=3tfUDZAkbANYKQRC2DD6J2HHA5.8GG8D6MK6J4GFL6FL.4GE@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677981110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=iTziTqXdCyDEQVpm0FvaP+DeDKXthJOgseCF6qw6QTM=; b=f6+B2C1WT0y+HG0Y+5TgXbugPWIvts2CWuKXJlrqFYnxbz732HgEBse7wVs62bq3+h5JX7 N2frCb0EJ7dgQcFDX6wuMcJN++gSo5YQtJQHyBX0rCKNCP8/SLCZoQ0hv9s14A1G20a3uv lVpDLSnVls7UOdj4j4SVao9Nwn54/B8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf05.hostedemail.com: domain of 3tfUDZAkbANYKQRC2DD6J2HHA5.8GG8D6MK6J4GFL6FL.4GE@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.205 as permitted sender) smtp.mailfrom=3tfUDZAkbANYKQRC2DD6J2HHA5.8GG8D6MK6J4GFL6FL.4GE@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677981110; a=rsa-sha256; cv=none; b=qr0qyOUK+qTa6SoRVmly1nSc2K2WGlqQVoPub9mHUw/TEpQhuAlOjeEKMoKFGWhNVK6aMM TzSoaM4MxUvQN3F5QYUJxwiIlulaIT2kwtc2uG91kHQ3rsgCAg/vXv0UUOUCEoWDQpBL0F I40QvY+GjQqWG2+zJuc7OUJ57OmK5Ec= Received: by mail-il1-f205.google.com with SMTP id l5-20020a92d8c5000000b00316f26477d6so3458144ilo.10 for ; Sat, 04 Mar 2023 17:51:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iTziTqXdCyDEQVpm0FvaP+DeDKXthJOgseCF6qw6QTM=; b=bBhp7s7ycm6NU58O073UXEVXywcG+2980UdcFWlp36VEEbWnnq7Tu1OgTgtabwIHSk LDZauegaBuBMwomTe52JqhgAZSqzVaRJlIAb06N7NVORrUf5YSgbxYkyDKmMMAivwYDb folmCzNuGqXvkdy1bBsFVuK14wJUewJCq+tIcWdgsU8I5To58+YSb8N94I/ojXpg/H+G QSkMHFR4lkbcrjAeo6Yw2PteilakZpVxUrnxFwiVjOpzuXrR4233stjISJBdHmueTnzB FteinAYJVoTqY00P9nRsxEy7ZlsL78Lr9+2Udj0OwEkLA+QD4XCdAUi2Y0SKkO4yQIYL di9w== X-Gm-Message-State: AO0yUKV0uASR+4zP2ofqdHeIsiROwNIFUNbtuIcAHRegB3LXve37XC4V vQkCqP9KJSaD/5Wq19Kdio5qkzaYlf7jKabFrn9PFyvH7bjX X-Google-Smtp-Source: AK7set9eY+uimcfB5XASasChAWE37naA3E2jdveMW/CvQnP6KcsQQucph8Ybt4o0c1TBDjun6M67fjvvPofq8FOt7cqFKMgZYDv4 MIME-Version: 1.0 X-Received: by 2002:a02:7310:0:b0:3ca:61cc:4bbc with SMTP id y16-20020a027310000000b003ca61cc4bbcmr3210777jab.2.1677981109813; Sat, 04 Mar 2023 17:51:49 -0800 (PST) Date: Sat, 04 Mar 2023 17:51:49 -0800 X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000fd8abb05f61d6bb2@google.com> Subject: [syzbot] [mm?] possible deadlock in collapse_file From: syzbot To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AD797100009 X-Stat-Signature: i9txfydhtf3kjcejqfewro5xsnj6kizo X-HE-Tag: 1677981110-132929 X-HE-Meta: U2FsdGVkX18jj64nb2gRscChFtk6bZra0w03f2fj3C/J+1R7TUnRtfBEPOLb6RbsgcQgsc+ocsk2JHLUadRJsibiQ/P1L1Bs6R/iyU/0Clxtsk6f3kEXJJspT4uwCkJ3rGU7SElEo8tm6rWrspgVmXaNfAzkziAJnefjSmDu1lfcTOYU7bk1O1sPeSnkzayfzBaA8dG/NRDVXShOesrCoupnWxYTX1itwsw9VMn2NBJj6JBY9GVhUaoKsUZ8SjAHF6DB/LHMDzaoyldgCh7fl4JWnvSptOUoDW6+HH+uprUhomtAmdmOgIjRkaF2O2Riz2x0M1jYLl8IZ7H2gAuNUDeftSPRcwoE9zAXrQzEgMtbZTUg6ZqAEwXE0eMEWwCe2T6HJThSJwbL/j53LZZwg/ZZcmJBoxtX4Re/yCdFPSrfp6Vqxh0zJOGGFnkQRWvNg7utvPr0GD+xC5gFn48AHyteTvWrMoGpOKe9g+YD0sPxH81p+vusCWTA1f1LmHGq7GVte/+9WPu37huxQLL6TpYjXawiSIOT7x/E1DzdVCvOI4O1/8WyxC4o8mCwmPBt50C87hhQeJHAfAU2Z8L7Fs/uvzmOgD0c1r2wtMY3NuTx4O6LlmoL7tD1qmw2ls0pE5kGXBIy84j9+crAopskUUgVtbRxhOaS78uB9OaTQNgK169LTkYMkNnrZdDzUNIAXWbIBvcS8zoObxk+SgvT1SI0pxLyLCNOlovMqWFWhDqqbVjyMgpPpbxZIqfvXMw2a1GcnbINE5U4iJPTgEHy3RRE40BfIbPvMhVselO94VummiqPKTaXhONDj0QxhgSyQ8tfy6aUnQMDoBtv1LbE09TzYraNtZgbczGHq9OrzieXExHnOdpDwY1Wm0MxwsSAYwes0lbYDXFFzu9dtaGj9QFOrhMSMzacb1g/OtPAMf17mWpRuUUFpCA08ZWYlblG/P7fV+/4sx3GvHKa76L m9lfFnPm 8kZ6IMNJaLhumpd9Bcakew6GQovMxCxm4ZqDj13nYyHfqXZGr7MibI0hRydNJ2WwhlOd5oDjewTZrRqNx2Pr3Du7yJKn6D5za7CnFdrLIQ4sBc4fINGhGOz2uEvH383S0WcYjIuP6s3KSBkrGnPpe8vWshJsPudBv+yofmRxofL/cPHLdea3TqTm9lIP6h4tiV7GIBfEqM/Xj6KrAHf0TajuzEWHjD46YU8Iatk8KBU7kBXXaOboSyxQ9s+tywdMvCgSNcIattgch3dgnbv232OhcAgTYA2pX2J8+3WDCnnIT7tEH7jNkmyIPLQ0lajGV7kPSQkM3Yb75uVUbc2yoF9Uk6Gz5StHNoJuzbg9lDh9PiruV+QcKaiwHOUNkxxX/unwWsue5cXQtaVF1iwsEDCzvbk7Db3DHR1hJMVP2fK7vlh4j+wehvJu7Ex8nkCx4tAzOQQQmFVlgjYMnrxki1/wSxtKW+Dha3FPuXjLgcT3CAgLDJHzlTW2nZOiukbVCGjg2+ZWPIh2A1B8o831XE07f76WZSuHkUfT/UR2VyE//UnulrMFulSBdiwXLske7U9joSz034X8b94FFuCbRDLqNNpqX/LjFxuwbP4REc1GIUFgaM7A/t8WKMP4cKnJtoWidLdWLbRizKwjHCNk+C1sEur5i9HDvG9TnJyG1IjIpbr4OCMCxOykosw2EtrEi8eXqXNLIXq0cTNzlQpwgUB7froPu9mrctwAu0fDKMcYnXsTsJ3yN43oZ+9TBkVpRpPS5uwhXtPf9vGXbl00It12Joz60gwweKkaOgzHhzJJ24wPNR1E77zYwt8xAM2n1RnyPdqOXNaZBv8/6j0/3ISolCTuQrKgv9jAzVwT9TyozrgYLcBSgEeRVbydoJ6aCRfWyZNItMtMZsy1zvnPilhtsaYE31DoAeoUn/RNP3653CjybBzHo+eIp4ZAmC4Wdmsz7SOMFDdkcKTjQUzi+pSUHF/Cw fxaWPlkY M2c5FsbZJRfOhY0JkBsi6W751hmoOX5n7bcdZkZhulj/Q3enDnD9lHTrTHzKGyUe5DDqBCpTZ08BHjr7VA5HHvELtEskHEVRzPLfN8/MgPQPj1gqEm6tU5ZZZzcQZ+AHnBdaLwfRuFca7UnmHVvqVqf5fzJnDFWJlxSPB/kh3eF3eq+7Od1iU8V+nhBUAVk3B4am5q9Tc1PBRCp0LC/yx99/zRH/zsMMegfnQmlr8zNDoE2+FPUAtLXTRn01oO3kVlmhhv0jWRZNEtVF85Eych5ynnE+IfbdJPblF/i0+Dkb9RFa3mIWlGtam5s/zajFUqliV3nj7fVeG75lOYyfee3KZ+aMhFcXVw125uRnklS7E2wUnUJTYj8sDD9QRtqWv9xeYCgeDENNlu1qDN5P5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, syzbot found the following issue on: HEAD commit: 1716a175592a Add linux-next specific files for 20230301 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=1566c97f480000 kernel config: https://syzkaller.appspot.com/x/.config?x=e4da7f0aef5d2eb8 dashboard link: https://syzkaller.appspot.com/bug?extid=534d1c3c0c08473dc853 compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10f1717f480000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=130f6874c80000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/0745b94b7a1b/disk-1716a175.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/9a0be79f3fd5/vmlinux-1716a175.xz kernel image: https://storage.googleapis.com/syzbot-assets/438e9e5cf49a/bzImage-1716a175.xz The issue was bisected to: commit 3d7cb67369a08d4933713290acf458990a50b6f9 Author: Suren Baghdasaryan Date: Mon Feb 27 17:36:28 2023 +0000 x86/mm: try VMA lock-based page fault handling first bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10265502c80000 final oops: https://syzkaller.appspot.com/x/report.txt?x=12265502c80000 console output: https://syzkaller.appspot.com/x/log.txt?x=14265502c80000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+534d1c3c0c08473dc853@syzkaller.appspotmail.com Fixes: 3d7cb67369a0 ("x86/mm: try VMA lock-based page fault handling first") ====================================================== WARNING: possible circular locking dependency detected 6.2.0-next-20230301-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor115/5084 is trying to acquire lock: ffff888078307a90 (&vma->vm_lock->lock){++++}-{3:3}, at: vma_start_write include/linux/mm.h:678 [inline] ffff888078307a90 (&vma->vm_lock->lock){++++}-{3:3}, at: retract_page_tables mm/khugepaged.c:1826 [inline] ffff888078307a90 (&vma->vm_lock->lock){++++}-{3:3}, at: collapse_file+0x4fa5/0x5980 mm/khugepaged.c:2204 but task is already holding lock: ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: i_mmap_lock_write include/linux/fs.h:468 [inline] ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: retract_page_tables mm/khugepaged.c:1745 [inline] ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: collapse_file+0x3da6/0x5980 mm/khugepaged.c:2204 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&mapping->i_mmap_rwsem){++++}-{3:3}: down_write+0x92/0x200 kernel/locking/rwsem.c:1573 i_mmap_lock_write include/linux/fs.h:468 [inline] dma_resv_lockdep+0x26f/0x5f0 drivers/dma-buf/dma-resv.c:760 do_one_initcall+0x141/0x7d0 init/main.c:1306 do_initcall_level init/main.c:1379 [inline] do_initcalls init/main.c:1395 [inline] do_basic_setup init/main.c:1414 [inline] kernel_init_freeable+0x5ec/0x900 init/main.c:1634 kernel_init+0x1e/0x2c0 init/main.c:1522 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 -> #1 (fs_reclaim){+.+.}-{0:0}: __fs_reclaim_acquire mm/page_alloc.c:4647 [inline] fs_reclaim_acquire+0x11d/0x160 mm/page_alloc.c:4661 might_alloc include/linux/sched/mm.h:299 [inline] prepare_alloc_pages+0x159/0x570 mm/page_alloc.c:5293 __alloc_pages+0x149/0x5c0 mm/page_alloc.c:5511 __folio_alloc+0x16/0x40 mm/page_alloc.c:5554 vma_alloc_folio+0x155/0x850 mm/mempolicy.c:2244 do_anonymous_page mm/memory.c:4062 [inline] handle_pte_fault mm/memory.c:4917 [inline] __handle_mm_fault+0x1857/0x3e70 mm/memory.c:5061 handle_mm_fault+0x2c0/0x9c0 mm/memory.c:5207 do_user_addr_fault+0x2c1/0x1210 arch/x86/mm/fault.c:1349 handle_page_fault arch/x86/mm/fault.c:1534 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1590 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 -> #0 (&vma->vm_lock->lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669 down_write+0x92/0x200 kernel/locking/rwsem.c:1573 vma_start_write include/linux/mm.h:678 [inline] retract_page_tables mm/khugepaged.c:1826 [inline] collapse_file+0x4fa5/0x5980 mm/khugepaged.c:2204 hpage_collapse_scan_file+0xcd3/0x1680 mm/khugepaged.c:2358 madvise_collapse+0x53b/0xca0 mm/khugepaged.c:2818 madvise_vma_behavior+0x649/0x20e0 mm/madvise.c:1086 madvise_walk_vmas+0x1c7/0x2b0 mm/madvise.c:1260 do_madvise.part.0+0x31c/0x470 mm/madvise.c:1439 do_madvise mm/madvise.c:1452 [inline] __do_sys_madvise mm/madvise.c:1452 [inline] __se_sys_madvise mm/madvise.c:1450 [inline] __x64_sys_madvise+0x117/0x150 mm/madvise.c:1450 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &vma->vm_lock->lock --> fs_reclaim --> &mapping->i_mmap_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&mapping->i_mmap_rwsem); lock(fs_reclaim); lock(&mapping->i_mmap_rwsem); lock(&vma->vm_lock->lock); *** DEADLOCK *** 2 locks held by syz-executor115/5084: #0: ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: i_mmap_lock_write include/linux/fs.h:468 [inline] #0: ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: retract_page_tables mm/khugepaged.c:1745 [inline] #0: ffff88801f93efa8 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: collapse_file+0x3da6/0x5980 mm/khugepaged.c:2204 #1: ffff88807b06f098 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_trylock include/linux/mmap_lock.h:120 [inline] #1: ffff88807b06f098 (&mm->mmap_lock){++++}-{3:3}, at: retract_page_tables mm/khugepaged.c:1797 [inline] #1: ffff88807b06f098 (&mm->mmap_lock){++++}-{3:3}, at: collapse_file+0x4667/0x5980 mm/khugepaged.c:2204 stack backtrace: CPU: 0 PID: 5084 Comm: syz-executor115 Not tainted 6.2.0-next-20230301-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669 down_write+0x92/0x200 kernel/locking/rwsem.c:1573 vma_start_write include/linux/mm.h:678 [inline] retract_page_tables mm/khugepaged.c:1826 [inline] collapse_file+0x4fa5/0x5980 mm/khugepaged.c:2204 hpage_collapse_scan_file+0xcd3/0x1680 mm/khugepaged.c:2358 madvise_collapse+0x53b/0xca0 mm/khugepaged.c:2818 madvise_vma_behavior+0x649/0x20e0 mm/madvise.c:1086 madvise_walk_vmas+0x1c7/0x2b0 mm/madvise.c:1260 do_madvise.part.0+0x31c/0x470 mm/madvise.c:1439 do_madvise mm/madvise.c:1452 [inline] __do_sys_madvise mm/madvise.c:1452 [inline] __se_sys_madvise mm/madvise.c:1450 [inline] __x64_sys_madvise+0x117/0x150 mm/madvise.c:1450 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fcffa4a4b29 Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffe20f24e68 EFLAGS: 00000246 ORIG_RAX: 000000000000001c RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fcffa4a4b29 RDX: 0000000000000019 RSI: 0000000000600003 RDI: 0000000020000000 RBP: 00007fcffa468cd0 R08: 0000000000000000 R09: 0000000000000000 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches