All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhash Jadavani" <subhashj@codeaurora.org>
To: 'Chris Ball' <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: RE: Changing the way MMC block request ends
Date: Fri, 6 Apr 2012 19:38:01 +0530	[thread overview]
Message-ID: <000001cd13fe$af084c70$0d18e550$@codeaurora.org> (raw)
In-Reply-To: <87y5q92cg3.fsf@laptop.org>

Hi Chris,

> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> owner@vger.kernel.org] On Behalf Of Chris Ball
> Sent: Friday, April 06, 2012 7:24 PM
> To: Subhash Jadavani
> Cc: linux-mmc@vger.kernel.org; linux-arm-msm@vger.kernel.org
> Subject: Re: Changing the way MMC block request ends
> 
> Hi Subhash,
> 
> On Fri, Apr 06 2012, Subhash Jadavani wrote:
> > I looked into blk_update_bidi_request() function and it mainly updates
> > bio's of a request and doesn't look to do any manipulation with
> > request queue structure of block device. There are many block drivers
> > (SCSI, IDE etc .) other than MMC uses blk_end_request() rather than
> > __blk_end_request(). Was there any special reason we are using
> > __blk_end_request() in MMC block driver? If there is no specific
> > reason, I would like to post a patch which would make MMC driver to use
> blk_end_request().
> 
> It looks like we've been using __blk_end_request() since fd539832c in
2007,
> which is as long as we've been using the blk_end_request API.
> 
> I haven't looked into it more closely, but it seems so far like there is
no
> specific reason, and you should go ahead and post a patch along with your
> experimental results.  Thanks!

Thanks. Sure, will post the patch along with my test results.

Regards,
Subhash

> 
> - Chris.
> --
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2012-04-06 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05  5:46 Changing the way MMC block request ends Subhash Jadavani
2012-04-06  6:08 ` Subhash Jadavani
2012-04-06 13:54   ` Chris Ball
2012-04-06 14:08     ` Subhash Jadavani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001cd13fe$af084c70$0d18e550$@codeaurora.org' \
    --to=subhashj@codeaurora.org \
    --cc=cjb@laptop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.