From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata Date: Tue, 17 Oct 2017 19:42:38 -0400 Message-ID: <000001d347a1$9f11ffa0$dd35fee0$@gmail.com> References: <20171017080925.23763-1-jeffy.chen@rock-chips.com> <20171017080925.23763-4-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171017080925.23763-4-jeffy.chen@rock-chips.com> Content-language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'Jeffy Chen' , linux-kernel@vger.kernel.org Cc: 'Daniel Vetter' , dri-devel@lists.freedesktop.org, 'Laurent Pinchart' , 'Marek Szyprowski' , linux-samsung-soc@vger.kernel.org, briannorris@chromium.org, 'Krzysztof Kozlowski' , linux-rockchip@lists.infradead.org, 'Kukjin Kim' , 'Caesar Wang' , broonie@kernel.org, linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net, 'zain wang' , 'Tomeu Vizoso' , dmitry.torokhov@gmail.com, 'Seung-Woo Kim' , dianders@chromium.org, tfiga@chromium.org, 'Kyungmin Park' List-Id: linux-rockchip.vger.kernel.org T24gVHVlc2RheSwgT2N0b2JlciAxNywgMjAxNyA0OjA5IEFNLCBKZWZmeSBDaGVuIHdyb3RlOgo+ IAo+IEZyb206IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4gCj4gVGhlIGRyaXZl ciB0aGF0IGluc3RhbnRpYXRlcyB0aGUgYnJpZGdlIHNob3VsZCBvd24gdGhlIGRydmRhdGEsIGFz IGFsbAo+IGRyaXZlciBtb2RlbCBjYWxsYmFja3MgKHByb2JlLCByZW1vdmUsIHNodXRkb3duLCBQ TSBvcHMsIGV0Yy4pIGFyZSBhbHNvCj4gb3duZWQgYnkgaXRzIGRyaXZlciBzdHJ1Y3QuIE1vcmVv dmVyLCBzdG9yaW5nIHR3byBkaWZmZXJlbnQgcG9pbnRlcgo+IHR5cGVzIGluIGRyaXZlciBkYXRh IGRlcGVuZGluZyBvbiBkcml2ZXIgaW5pdGlhbGl6YXRpb24gc3RhdHVzIGlzIGJhcmVseQo+IGEg Z29vZCBwcmFjdGljZSBhbmQgaW4gZmFjdCBoYXMgbGVkIHRvIG1hbnkgYnVncyBpbiB0aGlzIGRy aXZlci4KPiAKPiBMZXQncyBjbGVhbiB1cCB0aGlzIG1lc3MgYW5kIGNoYW5nZSBBbmFsb2dpeCBl bnRyeSBwb2ludHMgdG8gc2ltcGx5Cj4gYWNjZXB0IHNvbWUgb3BhcXVlIHN0cnVjdCBwb2ludGVy LCBhZGp1c3RpbmcgdGhlaXIgdXNlcnMgYXQgdGhlIHNhbWUKPiB0aW1lIHRvIGF2b2lkIGJyZWFr aW5nIHRoZSBjb21waWxhdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUb21hc3ogRmlnYSA8dGZp Z2FAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEplZmZ5IENoZW4gPGplZmZ5LmNoZW5A cm9jay1jaGlwcy5jb20+Cj4gUmV2aWV3ZWQtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ft c3VuZy5jb20+CgpBY2tlZC1ieTogSmluZ29vIEhhbiA8amluZ29vaGFuMUBnbWFpbC5jb20+CgpC ZXN0IHJlZ2FyZHMsCkppbmdvbyBIYW4KCj4gLS0tCj4gCj4gQ2hhbmdlcyBpbiB2MzogTm9uZQo+ IENoYW5nZXMgaW4gdjI6IE5vbmUKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dp eC9hbmFsb2dpeF9kcF9jb3JlLmMgfCA1MCArKysrKysrKystLS0tLS0tLQo+IC0tLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwLmMgICAgICAgICAgICAgICAgIHwgMjYgKysr KysrLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlw LmMgICAgfCA0NworKysrKysrKysrKy0tLS0tLS0KPiAtLQo+ICBpbmNsdWRlL2RybS9icmlkZ2Uv YW5hbG9naXhfZHAuaCAgICAgICAgICAgICAgICAgICB8IDE5ICsrKystLS0tCj4gIDQgZmlsZXMg Y2hhbmdlZCwgNzMgaW5zZXJ0aW9ucygrKSwgNjkgZGVsZXRpb25zKC0pCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jingoohan1@gmail.com (Jingoo Han) Date: Tue, 17 Oct 2017 19:42:38 -0400 Subject: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata In-Reply-To: <20171017080925.23763-4-jeffy.chen@rock-chips.com> References: <20171017080925.23763-1-jeffy.chen@rock-chips.com> <20171017080925.23763-4-jeffy.chen@rock-chips.com> Message-ID: <000001d347a1$9f11ffa0$dd35fee0$@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, October 17, 2017 4:09 AM, Jeffy Chen wrote: > > From: Tomasz Figa > > The driver that instantiates the bridge should own the drvdata, as all > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also > owned by its driver struct. Moreover, storing two different pointer > types in driver data depending on driver initialization status is barely > a good practice and in fact has led to many bugs in this driver. > > Let's clean up this mess and change Analogix entry points to simply > accept some opaque struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Jeffy Chen > Reviewed-by: Andrzej Hajda Acked-by: Jingoo Han Best regards, Jingoo Han > --- > > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++-------- > ----- > drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++----- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47 +++++++++++------- > -- > include/drm/bridge/analogix_dp.h | 19 ++++---- > 4 files changed, 73 insertions(+), 69 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbdJQXmo (ORCPT ); Tue, 17 Oct 2017 19:42:44 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:53618 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdJQXmm (ORCPT ); Tue, 17 Oct 2017 19:42:42 -0400 X-Google-Smtp-Source: ABhQp+ROGcj/oYj4q9prd0cGQNs/hEtEUnWrTVMotj6SWmGk1vaNdKZMLbweVzxe+Bcfvwy8AdGhJg== From: "Jingoo Han" To: "'Jeffy Chen'" , Cc: , , , , , , , , "'Andrzej Hajda'" , , "'Caesar Wang'" , "'David Airlie'" , "'Laurent Pinchart'" , , "'Daniel Vetter'" , "'Seung-Woo Kim'" , "'Inki Dae'" , , "'Kyungmin Park'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Tomeu Vizoso'" , "'zain wang'" , "'Archit Taneja'" , "'Joonyoung Shim'" , , "'Marek Szyprowski'" , "'Mark Yao'" References: <20171017080925.23763-1-jeffy.chen@rock-chips.com> <20171017080925.23763-4-jeffy.chen@rock-chips.com> In-Reply-To: <20171017080925.23763-4-jeffy.chen@rock-chips.com> Subject: Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata Date: Tue, 17 Oct 2017 19:42:38 -0400 Message-ID: <000001d347a1$9f11ffa0$dd35fee0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-language: en-us Thread-Index: AQGpmNONJxxZsJD2R2n5/BXX7uv8YwJOr2hBoymbrdA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 17, 2017 4:09 AM, Jeffy Chen wrote: > > From: Tomasz Figa > > The driver that instantiates the bridge should own the drvdata, as all > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also > owned by its driver struct. Moreover, storing two different pointer > types in driver data depending on driver initialization status is barely > a good practice and in fact has led to many bugs in this driver. > > Let's clean up this mess and change Analogix entry points to simply > accept some opaque struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Jeffy Chen > Reviewed-by: Andrzej Hajda Acked-by: Jingoo Han Best regards, Jingoo Han > --- > > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++-------- > ----- > drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++----- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47 +++++++++++------- > -- > include/drm/bridge/analogix_dp.h | 19 ++++---- > 4 files changed, 73 insertions(+), 69 deletions(-) >