From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() Date: Mon, 27 Nov 2017 14:46:39 -0500 Message-ID: <000001d367b8$726bd7f0$574387d0$@gmail.com> References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-25-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1511801886-6753-25-git-send-email-okaya@codeaurora.org> Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org To: 'Sinan Kaya' , linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, intel-gfx@lists.freedesktop.org, 'Lee Jones' , 'Daniel Thompson' , 'Bartlomiej Zolnierkiewicz' , "'open list:FRAMEBUFFER LAYER'" , 'open list' List-Id: linux-arm-msm@vger.kernel.org On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi domains into ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose domain will be used later. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Hard-coding the domain as 0. > > Acked-by: Daniel Thompson > Signed-off-by: Sinan Kaya Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/apple_bl.c > b/drivers/video/backlight/apple_bl.c > index d843296..6a34ab9 100644 > --- a/drivers/video/backlight/apple_bl.c > +++ b/drivers/video/backlight/apple_bl.c > @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev) > struct pci_dev *host; > int intensity; > > - host = pci_get_bus_and_slot(0, 0); > + host = pci_get_domain_bus_and_slot(0, 0, 0); > > if (!host) { > pr_err("unable to find PCI host\n"); > -- > 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Date: Mon, 27 Nov 2017 19:46:39 +0000 Subject: Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() Message-Id: <000001d367b8$726bd7f0$574387d0$@gmail.com> List-Id: References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-25-git-send-email-okaya@codeaurora.org> In-Reply-To: <1511801886-6753-25-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Sinan Kaya' , linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, intel-gfx@lists.freedesktop.org, 'Lee Jones' , 'Daniel Thompson' , 'Bartlomiej Zolnierkiewicz' , "'open list:FRAMEBUFFER LAYER'" , 'open list' On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi domains into ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose domain will be used later. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Hard-coding the domain as 0. > > Acked-by: Daniel Thompson > Signed-off-by: Sinan Kaya Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/apple_bl.c > b/drivers/video/backlight/apple_bl.c > index d843296..6a34ab9 100644 > --- a/drivers/video/backlight/apple_bl.c > +++ b/drivers/video/backlight/apple_bl.c > @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev) > struct pci_dev *host; > int intensity; > > - host = pci_get_bus_and_slot(0, 0); > + host = pci_get_domain_bus_and_slot(0, 0, 0); > > if (!host) { > pr_err("unable to find PCI host\n"); > -- > 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: "Jingoo Han" To: "'Sinan Kaya'" , , References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-25-git-send-email-okaya@codeaurora.org> In-Reply-To: <1511801886-6753-25-git-send-email-okaya@codeaurora.org> Subject: Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() Date: Mon, 27 Nov 2017 14:46:39 -0500 Message-ID: <000001d367b8$726bd7f0$574387d0$@gmail.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Daniel Thompson' , 'Bartlomiej Zolnierkiewicz' , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, "'open list:FRAMEBUFFER LAYER'" , 'open list' , 'Lee Jones' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi domains into ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose domain will be used later. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Hard-coding the domain as 0. > > Acked-by: Daniel Thompson > Signed-off-by: Sinan Kaya Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/apple_bl.c > b/drivers/video/backlight/apple_bl.c > index d843296..6a34ab9 100644 > --- a/drivers/video/backlight/apple_bl.c > +++ b/drivers/video/backlight/apple_bl.c > @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev) > struct pci_dev *host; > int intensity; > > - host = pci_get_bus_and_slot(0, 0); > + host = pci_get_domain_bus_and_slot(0, 0, 0); > > if (!host) { > pr_err("unable to find PCI host\n"); > -- > 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: jingoohan1@gmail.com (Jingoo Han) Date: Mon, 27 Nov 2017 14:46:39 -0500 Subject: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() In-Reply-To: <1511801886-6753-25-git-send-email-okaya@codeaurora.org> References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-25-git-send-email-okaya@codeaurora.org> Message-ID: <000001d367b8$726bd7f0$574387d0$@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi domains into ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose domain will be used later. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Hard-coding the domain as 0. > > Acked-by: Daniel Thompson > Signed-off-by: Sinan Kaya Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/apple_bl.c > b/drivers/video/backlight/apple_bl.c > index d843296..6a34ab9 100644 > --- a/drivers/video/backlight/apple_bl.c > +++ b/drivers/video/backlight/apple_bl.c > @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev) > struct pci_dev *host; > int intensity; > > - host = pci_get_bus_and_slot(0, 0); > + host = pci_get_domain_bus_and_slot(0, 0, 0); > > if (!host) { > pr_err("unable to find PCI host\n"); > -- > 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbdK0Tqq (ORCPT ); Mon, 27 Nov 2017 14:46:46 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:41192 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450AbdK0Tqn (ORCPT ); Mon, 27 Nov 2017 14:46:43 -0500 X-Google-Smtp-Source: AGs4zMYYXOVsuPxyjnYV2SBBE5BtEX4ZXC78APP3B66m7YlQSsa8sJ4xVB2a5FL2EtDl8fYqoMnuzw== From: "Jingoo Han" To: "'Sinan Kaya'" , , Cc: , , , "'Lee Jones'" , "'Daniel Thompson'" , "'Bartlomiej Zolnierkiewicz'" , "'open list:FRAMEBUFFER LAYER'" , "'open list'" References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-25-git-send-email-okaya@codeaurora.org> In-Reply-To: <1511801886-6753-25-git-send-email-okaya@codeaurora.org> Subject: Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() Date: Mon, 27 Nov 2017 14:46:39 -0500 Message-ID: <000001d367b8$726bd7f0$574387d0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQE6NC/RWwy7C6ugI9klyFkGAQH0tAKLjgdCpEarF8A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi domains into ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose domain will be used later. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Hard-coding the domain as 0. > > Acked-by: Daniel Thompson > Signed-off-by: Sinan Kaya Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/apple_bl.c > b/drivers/video/backlight/apple_bl.c > index d843296..6a34ab9 100644 > --- a/drivers/video/backlight/apple_bl.c > +++ b/drivers/video/backlight/apple_bl.c > @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev) > struct pci_dev *host; > int intensity; > > - host = pci_get_bus_and_slot(0, 0); > + host = pci_get_domain_bus_and_slot(0, 0, 0); > > if (!host) { > pr_err("unable to find PCI host\n"); > -- > 1.9.1