From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
<linux-pci@vger.kernel.org>
Cc: "'Rob Herring'" <robh@kernel.org>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Linus Walleij'" <linus.walleij@linaro.org>,
"'Xiaowei Song'" <songxiaowei@hisilicon.com>,
"'Ray Jui'" <rjui@broadcom.com>,
"'Scott Branden'" <sbranden@broadcom.com>,
"'Jon Mason'" <jonmason@broadcom.com>,
"'Joao Pinto'" <Joao.Pinto@synopsys.com>,
"'Thomas Petazzoni'" <thomas.petazzoni@free-electrons.com>,
"'Tanmay Inamdar'" <tinamdar@apm.com>,
"'Shawn Lin'" <shawn.lin@rock-chips.com>,
"'Ley Foon Tan'" <lftan@altera.com>,
"'Fengguang Wu'" <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 09/10] PCI: dwc: Move CONFIG_PCI depends to menu
Date: Sat, 24 Mar 2018 10:03:37 -0400 [thread overview]
Message-ID: <000001d3c378$e83efbd0$b8bcf370$@gmail.com> (raw)
In-Reply-To: <20180321144254.7406-10-lorenzo.pieralisi@arm.com>
On Wednesday, March 21, 2018 10:43 AM, Lorenzo Pieralisi wrote:
>
> From: Rob Herring <robh@kernel.org>
>
> There's no need for every config option to explicitly depend on
> CONFIG_PCI, so move it out of individual option to the menu option.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
It looks good.
Best regards,
Jingoo Han
> ---
> drivers/pci/dwc/Kconfig | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig
> index 6f2b653146bb..2902544f5834 100644
> --- a/drivers/pci/dwc/Kconfig
> +++ b/drivers/pci/dwc/Kconfig
> @@ -1,13 +1,13 @@
> # SPDX-License-Identifier: GPL-2.0
>
> menu "DesignWare PCI Core Support"
> + depends on PCI
>
> config PCIE_DW
> bool
>
> config PCIE_DW_HOST
> bool
> - depends on PCI
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW
>
> @@ -22,7 +22,7 @@ config PCI_DRA7XX
> config PCI_DRA7XX_HOST
> bool "TI DRA7xx PCIe controller Host Mode"
> depends on SOC_DRA7XX || COMPILE_TEST
> - depends on PCI && PCI_MSI_IRQ_DOMAIN
> + depends on PCI_MSI_IRQ_DOMAIN
> depends on OF && HAS_IOMEM && TI_PIPE3
> select PCIE_DW_HOST
> select PCI_DRA7XX
> @@ -52,7 +52,6 @@ config PCI_DRA7XX_EP
>
> config PCIE_DW_PLAT
> bool "Platform bus based DesignWare PCIe Controller"
> - depends on PCI
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> ---help---
> @@ -65,7 +64,6 @@ config PCIE_DW_PLAT
>
> config PCI_EXYNOS
> bool "Samsung Exynos PCIe controller"
> - depends on PCI
> depends on SOC_EXYNOS5440 || COMPILE_TEST
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -73,7 +71,6 @@ config PCI_EXYNOS
>
> config PCI_IMX6
> bool "Freescale i.MX6 PCIe controller"
> - depends on PCI
> depends on SOC_IMX6Q || (ARM && COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -81,7 +78,6 @@ config PCI_IMX6
>
> config PCIE_SPEAR13XX
> bool "STMicroelectronics SPEAr PCIe controller"
> - depends on PCI
> depends on ARCH_SPEAR13XX || COMPILE_TEST
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -91,7 +87,6 @@ config PCIE_SPEAR13XX
>
> config PCI_KEYSTONE
> bool "TI Keystone PCIe controller"
> - depends on PCI
> depends on ARCH_KEYSTONE || (ARM && COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -104,7 +99,6 @@ config PCI_KEYSTONE
>
> config PCI_LAYERSCAPE
> bool "Freescale Layerscape PCIe controller"
> - depends on PCI
> depends on OF && (ARM || ARCH_LAYERSCAPE || COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select MFD_SYSCON
> @@ -115,7 +109,6 @@ config PCI_LAYERSCAPE
> config PCI_HISI
> depends on OF && (ARM64 || COMPILE_TEST)
> bool "HiSilicon Hip05 and Hip06 SoCs PCIe controllers"
> - depends on PCI
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> select PCIE_DW_HOST
> @@ -126,7 +119,6 @@ config PCI_HISI
>
> config PCIE_QCOM
> bool "Qualcomm PCIe controller"
> - depends on PCI
> depends on OF && (ARCH_QCOM || COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -138,7 +130,6 @@ config PCIE_QCOM
>
> config PCIE_ARMADA_8K
> bool "Marvell Armada-8K PCIe controller"
> - depends on PCI
> depends on ARCH_MVEBU || COMPILE_TEST
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> @@ -155,7 +146,7 @@ config PCIE_ARTPEC6
> config PCIE_ARTPEC6_HOST
> bool "Axis ARTPEC-6 PCIe controller Host Mode"
> depends on MACH_ARTPEC6 || COMPILE_TEST
> - depends on PCI && PCI_MSI_IRQ_DOMAIN
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> select PCIE_DW_HOST
> select PCIE_ARTPEC6
> @@ -177,7 +168,6 @@ config PCIE_KIRIN
> depends on OF && (ARM64 || COMPILE_TEST)
> bool "HiSilicon Kirin series SoCs PCIe controllers"
> depends on PCI_MSI_IRQ_DOMAIN
> - depends on PCI
> select PCIEPORTBUS
> select PCIE_DW_HOST
> help
> @@ -187,7 +177,6 @@ config PCIE_KIRIN
> config PCIE_HISI_STB
> bool "HiSilicon STB SoCs PCIe controllers"
> depends on ARCH_HISI || COMPILE_TEST
> - depends on PCI
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> select PCIE_DW_HOST
> --
> 2.15.0
next prev parent reply other threads:[~2018-03-24 14:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 14:42 [PATCH v2 00/10] PCI DT header refactoring and compile test improvements Lorenzo Pieralisi
2018-03-21 14:42 ` [PATCH v2 01/10] PCI: kirin: Remove unnecessary asm/compiler.h include Lorenzo Pieralisi
2018-03-21 14:42 ` [PATCH v2 02/10] PCI: iproc: Remove dependency on ARM specific struct pci_sys_data Lorenzo Pieralisi
2018-03-21 21:16 ` Bjorn Helgaas
2018-03-27 16:39 ` Rob Herring
2018-03-21 14:42 ` [PATCH v2 03/10] PCI: kirin: Fix missing dependency on PCI_MSI_IRQ_DOMAIN Lorenzo Pieralisi
2018-03-21 14:42 ` [PATCH v2 04/10] PCI: kirin: struct kirin_pcie_driver can be static Lorenzo Pieralisi
2018-03-27 17:44 ` Bjorn Helgaas
2018-03-21 14:42 ` [PATCH v2 05/10] PCI: faraday: struct faraday_pci_variant " Lorenzo Pieralisi
2018-03-22 10:46 ` Linus Walleij
2018-03-21 14:42 ` [PATCH v2 06/10] PCI: rcar: Fix semicolon.cocci warnings Lorenzo Pieralisi
2018-03-21 14:42 ` [PATCH v2 07/10] PCI: v3-semi: " Lorenzo Pieralisi
2018-03-22 10:27 ` Linus Walleij
2018-03-21 14:42 ` [PATCH v2 08/10] PCI: Improve host drivers compile test coverage Lorenzo Pieralisi
2018-03-21 17:58 ` Scott Branden
2018-03-21 14:42 ` [PATCH v2 09/10] PCI: dwc: Move CONFIG_PCI depends to menu Lorenzo Pieralisi
2018-03-24 14:03 ` Jingoo Han [this message]
2018-03-21 14:42 ` [PATCH v2 10/10] PCI: Move private DT related functions into private header Lorenzo Pieralisi
2018-03-24 14:07 ` Jingoo Han
2018-03-21 21:19 ` [PATCH v2 00/10] PCI DT header refactoring and compile test improvements Bjorn Helgaas
2018-03-27 16:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d3c378$e83efbd0$b8bcf370$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=fengguang.wu@intel.com \
--cc=jonmason@broadcom.com \
--cc=lftan@altera.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=songxiaowei@hisilicon.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.