RE: [PATCH 1/6] dt-bindings: media: Add bindings for imx335

["Martina Krasteva" <martinax.krasteva@linux.intel.com>]

Hi Rob,

Thank you for the review

> 
> On Tue, Mar 30, 2021 at 03:20:18PM +0100, Martina Krasteva wrote:
> > From: Martina Krasteva <martinax.krasteva@intel.com>
> >
> > - Add dt-bindings documentation for Sony imx335 sensor driver
> > - Add MAINTAINERS entry for Sony imx335 binding documentation
> >
> > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com>
> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com>
> > ---
> >  .../devicetree/bindings/media/i2c/sony,imx335.yaml | 90
> ++++++++++++++++++++++
> >  MAINTAINERS                                        |  8 ++
> >  2 files changed, 98 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> > b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> > new file mode 100644
> > index 000000000000..0e286226ad9b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> > @@ -0,0 +1,90 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(C) 2021 Intel Corporation %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx335.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony IMX335 Sensor
> > +
> > +maintainers:
> > +  - Paul J. Murphy <paul.j.murphy@intel.com>
> > +  - Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> > +
> > +description:
> > +  IMX335 sensor is a Sony CMOS active pixel digital image sensor with
> > +an active
> > +  array size of 2592H x 1944V. It is programmable through I2C
> > +interface. The
> > +  I2C client address is fixed to 0x1a as per sensor data sheet. Image
> > +data is
> > +  sent through MIPI CSI-2.
> > +
> > +properties:
> > +  compatible:
> > +    const: sony,imx335
> > +  reg:
> > +    description: I2C address
> > +    maxItems: 1
> > +
> > +  assigned-clocks: true
> > +  assigned-clock-parents: true
> > +  assigned-clock-rates: true
> > +
> > +  clocks:
> > +    description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: Reference to the GPIO connected to the XCLR pin, if
any.
> 
> Missed one thing. You need 'maxItems: 1' to define how many gpios.
> 
Will be added in next version :)
> > +
> > +  port:
> > +    additionalProperties: false
> > +    $ref: /schemas/graph.yaml#/properties/port
> > +
> > +    properties:
> > +      endpoint:
> > +        $ref: /schemas/media/video-interfaces.yaml#
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          data-lanes: true
> > +          link-frequencies: true
> > +
> > +        required:
> > +          - data-lanes
> > +          - link-frequencies
> > +
> > +    required:
> > +      - endpoint
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        camera@1a {
> > +            compatible = "sony,imx335";
> > +            reg = <0x1a>;
> > +            clocks = <&imx335_clk>;
> > +
> > +            assigned-clocks = <&imx335_clk>;
> > +            assigned-clock-parents = <&imx335_clk_parent>;
> > +            assigned-clock-rates = <24000000>;
> > +
> > +            port {
> > +                imx335: endpoint {
> > +                    remote-endpoint = <&cam>;
> > +                    data-lanes = <1 2 3 4>;
> > +                    link-frequencies = /bits/ 64 <594000000>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > cd988b258fe0..510e3c4a45b6 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16875,6 +16875,14 @@ T:	git git://linuxtv.org/media_tree.git
> >  F:	Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> >  F:	drivers/media/i2c/imx334.c
> >
> > +SONY IMX335 SENSOR DRIVER
> > +M:	Paul J. Murphy <paul.j.murphy@intel.com>
> > +M:	Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> > +L:	linux-media@vger.kernel.org
> > +S:	Maintained
> > +T:	git git://linuxtv.org/media_tree.git
> > +F:	Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> > +
> >  SONY IMX355 SENSOR DRIVER
> >  M:	Tianshu Qiu <tian.shu.qiu@intel.com>
> >  L:	linux-media@vger.kernel.org
> > --
> > 2.11.0
> >

Best Regards,
Martina