diff for duplicates of <000001d95249$52adea80$f809bf80$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index d34fc8a..1a36b49 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -267,152 +267,145 @@ > > correct, then I propose to leave it as minItems:1/maxItems:2 without > > defining the items here and... > > -> Agreed. That’s why I initially kept as minItems:1/maxItems:2. Will keep it -> now as it is. -> iommu-names: -> minItems: 1 -> maxItems: 2 -> > > + -> > > + power-domains: -> > > + maxItems: 1 -> > > + -> > > + memory-region: -> > > + minItems: 1 -> > > + maxItems: 2 -> > > + -> > > +required: -> > > + - compatible -> > > + - reg -> > > + - clocks -> > > + - clock-names -> > > + - interrupts -> > > + -> > > +additionalProperties: false -> > > + -> > > +allOf: -> > > + - if: -> > > + properties: -> > > + compatible: -> > > + contains: -> > > + enum: -> > > + - samsung,mfc-v5 -> > > + - samsung,exynos3250-mfc -> > > + then: -> > > + properties: -> > > + clocks: -> > > + maxItems: 2 -> > > + clock-names: -> > > + items: -> > > + - const: mfc -> > > + - const: sclk_mfc -> > -> > iommus: -> > maxItems: 1 -> > iommu-names: false -> > -> I am getting compilation errors with above property set and its breaking the -> bindings. -> If we see these two nodes in dtsi files. -> mfc: codec@13400000 { -> compatible = "samsung,mfc-v5"; .. -> iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>; -> iommu-names = "left", "right"; } And -> mfc: codec@13400000 { -> compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7"; -> reg = <0x13400000 0x10000>; ... -> iommus = <&sysmmu_mfc>; -> }; -> There is no iommu-names property for compatible "samsung,exynos3250- -> mfc, samsung,mfc-v7", that’s why I kept -> iommus: -> minItems: 1 -> maxItems: 2 -> I would even go with below if you agree? -> iommus: -> minItems: 1 -> maxItems: 2 -> iommus-names: false -> -Hi Krzysztof, -Any suggestions here? -> > > + -> > > + - if: -> > > + properties: -> > > + compatible: -> > > + contains: -> > > + enum: -> > > + - samsung,mfc-v6 -> > > + - samsung,mfc-v8 -> > > + then: -> > > + properties: -> > > + clocks: -> > > + maxItems: 1 -> > > + clock-names: -> > > + items: -> > > + - const: mfc -> > > + iommus: -> > > + maxItems: 2 -> > -> > ... and here: -> > iommu-names: -> > items: -> > - const: left -> > - const: right -> > -> Agreed. -> > > + -> > > + - if: -> > > + properties: -> > > + compatible: -> > > + contains: -> > > + enum: -> > > + - samsung,exynos5433-mfc -> > > + then: -> > > + properties: -> > > + clocks: -> > > + maxItems: 3 -> > > + clock-names: -> > > + items: -> > > + - const: pclk -> > > + - const: aclk -> > > + - const: aclk_xiu -> > > + iommus: -> > > + maxItems: 2 -> > -> > the same here -> > -> Agreed. -> > > + -> > > + - if: -> > > + properties: -> > > + compatible: -> > > + contains: -> > > + enum: -> > > + - samsung,mfc-v7 -> > > + then: -> > > + properties: -> > > + clocks: -> > > + minItems: 1 -> > > + maxItems: 2 -> > -> > iommus: -> > maxItems: 1 -> > iommu-names: false -> same explanation as above. Would prefer to go with -> iommus: -> minItems: 1 -> maxItems: 2 -> iommus-names: false -> > -> > -> > Best regards, -> > Krzysztof -> +> Agreed. That’s why I initially kept as minItems:1/maxItems:2. Will keep it\r +> now as it is.\r +> iommu-names:\r +> minItems: 1\r +> maxItems: 2\r +> > > +\r +> > > + power-domains:\r +> > > + maxItems: 1\r +> > > +\r +> > > + memory-region:\r +> > > + minItems: 1\r +> > > + maxItems: 2\r +> > > +\r +> > > +required:\r +> > > + - compatible\r +> > > + - reg\r +> > > + - clocks\r +> > > + - clock-names\r +> > > + - interrupts\r +> > > +\r +> > > +additionalProperties: false\r +> > > +\r +> > > +allOf:\r +> > > + - if:\r +> > > + properties:\r +> > > + compatible:\r +> > > + contains:\r +> > > + enum:\r +> > > + - samsung,mfc-v5\r +> > > + - samsung,exynos3250-mfc\r +> > > + then:\r +> > > + properties:\r +> > > + clocks:\r +> > > + maxItems: 2\r +> > > + clock-names:\r +> > > + items:\r +> > > + - const: mfc\r +> > > + - const: sclk_mfc\r +> >\r +> > iommus:\r +> > maxItems: 1\r +> > iommu-names: false\r +> >\r +> I am getting compilation errors with above property set and its breaking the\r +> bindings.\r +> If we see these two nodes in dtsi files.\r +> mfc: codec@13400000 {\r +> compatible = "samsung,mfc-v5"; ..\r +> iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\r +> iommu-names = "left", "right"; } And\r +> mfc: codec@13400000 {\r +> compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";\r +> reg = <0x13400000 0x10000>; ...\r +> iommus = <&sysmmu_mfc>;\r +> };\r +> There is no iommu-names property for compatible "samsung,exynos3250-\r +> mfc, samsung,mfc-v7", that’s why I kept\r +> iommus:\r +> minItems: 1\r +> maxItems: 2\r +> I would even go with below if you agree?\r +> iommus:\r +> minItems: 1\r +> maxItems: 2\r +> iommus-names: false\r +> \r +Hi Krzysztof,\r +Any suggestions here?\r +> > > +\r +> > > + - if:\r +> > > + properties:\r +> > > + compatible:\r +> > > + contains:\r +> > > + enum:\r +> > > + - samsung,mfc-v6\r +> > > + - samsung,mfc-v8\r +> > > + then:\r +> > > + properties:\r +> > > + clocks:\r +> > > + maxItems: 1\r +> > > + clock-names:\r +> > > + items:\r +> > > + - const: mfc\r +> > > + iommus:\r +> > > + maxItems: 2\r +> >\r +> > ... and here:\r +> > iommu-names:\r +> > items:\r +> > - const: left\r +> > - const: right\r +> >\r +> Agreed.\r +> > > +\r +> > > + - if:\r +> > > + properties:\r +> > > + compatible:\r +> > > + contains:\r +> > > + enum:\r +> > > + - samsung,exynos5433-mfc\r +> > > + then:\r +> > > + properties:\r +> > > + clocks:\r +> > > + maxItems: 3\r +> > > + clock-names:\r +> > > + items:\r +> > > + - const: pclk\r +> > > + - const: aclk\r +> > > + - const: aclk_xiu\r +> > > + iommus:\r +> > > + maxItems: 2\r +> >\r +> > the same here\r +> >\r +> Agreed.\r +> > > +\r +> > > + - if:\r +> > > + properties:\r +> > > + compatible:\r +> > > + contains:\r +> > > + enum:\r +> > > + - samsung,mfc-v7\r +> > > + then:\r +> > > + properties:\r +> > > + clocks:\r +> > > + minItems: 1\r +> > > + maxItems: 2\r +> >\r +> > iommus:\r +> > maxItems: 1\r +> > iommu-names: false\r +> same explanation as above. Would prefer to go with\r +> iommus:\r +> minItems: 1\r +> maxItems: 2\r +> iommus-names: false\r +> >\r +> >\r +> > Best regards,\r +> > Krzysztof\r +> \r > Thanks for the review. - - - -_______________________________________________ -linux-arm-kernel mailing list -linux-arm-kernel@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index e333df0..846e499 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -298,154 +298,147 @@ "> > correct, then I propose to leave it as minItems:1/maxItems:2 without\n" "> > defining the items here and...\n" "> >\n" - "> Agreed. That\342\200\231s why I initially kept as minItems:1/maxItems:2. Will keep it\n" - "> now as it is.\n" - "> iommu-names:\n" - "> minItems: 1\n" - "> maxItems: 2\n" - "> > > +\n" - "> > > + power-domains:\n" - "> > > + maxItems: 1\n" - "> > > +\n" - "> > > + memory-region:\n" - "> > > + minItems: 1\n" - "> > > + maxItems: 2\n" - "> > > +\n" - "> > > +required:\n" - "> > > + - compatible\n" - "> > > + - reg\n" - "> > > + - clocks\n" - "> > > + - clock-names\n" - "> > > + - interrupts\n" - "> > > +\n" - "> > > +additionalProperties: false\n" - "> > > +\n" - "> > > +allOf:\n" - "> > > + - if:\n" - "> > > + properties:\n" - "> > > + compatible:\n" - "> > > + contains:\n" - "> > > + enum:\n" - "> > > + - samsung,mfc-v5\n" - "> > > + - samsung,exynos3250-mfc\n" - "> > > + then:\n" - "> > > + properties:\n" - "> > > + clocks:\n" - "> > > + maxItems: 2\n" - "> > > + clock-names:\n" - "> > > + items:\n" - "> > > + - const: mfc\n" - "> > > + - const: sclk_mfc\n" - "> >\n" - "> > iommus:\n" - "> > maxItems: 1\n" - "> > iommu-names: false\n" - "> >\n" - "> I am getting compilation errors with above property set and its breaking the\n" - "> bindings.\n" - "> If we see these two nodes in dtsi files.\n" - "> mfc: codec@13400000 {\n" - "> compatible = \"samsung,mfc-v5\"; ..\n" - "> iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\n" - "> iommu-names = \"left\", \"right\"; } And\n" - "> mfc: codec@13400000 {\n" - "> compatible = \"samsung,exynos3250-mfc\", \"samsung,mfc-v7\";\n" - "> reg = <0x13400000 0x10000>; ...\n" - "> iommus = <&sysmmu_mfc>;\n" - "> };\n" - "> There is no iommu-names property for compatible \"samsung,exynos3250-\n" - "> mfc, samsung,mfc-v7\", that\342\200\231s why I kept\n" - "> iommus:\n" - "> minItems: 1\n" - "> maxItems: 2\n" - "> I would even go with below if you agree?\n" - "> iommus:\n" - "> minItems: 1\n" - "> maxItems: 2\n" - "> iommus-names: false\n" - "> \n" - "Hi Krzysztof,\n" - "Any suggestions here?\n" - "> > > +\n" - "> > > + - if:\n" - "> > > + properties:\n" - "> > > + compatible:\n" - "> > > + contains:\n" - "> > > + enum:\n" - "> > > + - samsung,mfc-v6\n" - "> > > + - samsung,mfc-v8\n" - "> > > + then:\n" - "> > > + properties:\n" - "> > > + clocks:\n" - "> > > + maxItems: 1\n" - "> > > + clock-names:\n" - "> > > + items:\n" - "> > > + - const: mfc\n" - "> > > + iommus:\n" - "> > > + maxItems: 2\n" - "> >\n" - "> > ... and here:\n" - "> > iommu-names:\n" - "> > items:\n" - "> > - const: left\n" - "> > - const: right\n" - "> >\n" - "> Agreed.\n" - "> > > +\n" - "> > > + - if:\n" - "> > > + properties:\n" - "> > > + compatible:\n" - "> > > + contains:\n" - "> > > + enum:\n" - "> > > + - samsung,exynos5433-mfc\n" - "> > > + then:\n" - "> > > + properties:\n" - "> > > + clocks:\n" - "> > > + maxItems: 3\n" - "> > > + clock-names:\n" - "> > > + items:\n" - "> > > + - const: pclk\n" - "> > > + - const: aclk\n" - "> > > + - const: aclk_xiu\n" - "> > > + iommus:\n" - "> > > + maxItems: 2\n" - "> >\n" - "> > the same here\n" - "> >\n" - "> Agreed.\n" - "> > > +\n" - "> > > + - if:\n" - "> > > + properties:\n" - "> > > + compatible:\n" - "> > > + contains:\n" - "> > > + enum:\n" - "> > > + - samsung,mfc-v7\n" - "> > > + then:\n" - "> > > + properties:\n" - "> > > + clocks:\n" - "> > > + minItems: 1\n" - "> > > + maxItems: 2\n" - "> >\n" - "> > iommus:\n" - "> > maxItems: 1\n" - "> > iommu-names: false\n" - "> same explanation as above. Would prefer to go with\n" - "> iommus:\n" - "> minItems: 1\n" - "> maxItems: 2\n" - "> iommus-names: false\n" - "> >\n" - "> >\n" - "> > Best regards,\n" - "> > Krzysztof\n" - "> \n" - "> Thanks for the review.\n" - "\n" - "\n" - "\n" - "_______________________________________________\n" - "linux-arm-kernel mailing list\n" - "linux-arm-kernel@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/linux-arm-kernel + "> Agreed. That\342\200\231s why I initially kept as minItems:1/maxItems:2. Will keep it\r\n" + "> now as it is.\r\n" + "> iommu-names:\r\n" + "> minItems: 1\r\n" + "> maxItems: 2\r\n" + "> > > +\r\n" + "> > > + power-domains:\r\n" + "> > > + maxItems: 1\r\n" + "> > > +\r\n" + "> > > + memory-region:\r\n" + "> > > + minItems: 1\r\n" + "> > > + maxItems: 2\r\n" + "> > > +\r\n" + "> > > +required:\r\n" + "> > > + - compatible\r\n" + "> > > + - reg\r\n" + "> > > + - clocks\r\n" + "> > > + - clock-names\r\n" + "> > > + - interrupts\r\n" + "> > > +\r\n" + "> > > +additionalProperties: false\r\n" + "> > > +\r\n" + "> > > +allOf:\r\n" + "> > > + - if:\r\n" + "> > > + properties:\r\n" + "> > > + compatible:\r\n" + "> > > + contains:\r\n" + "> > > + enum:\r\n" + "> > > + - samsung,mfc-v5\r\n" + "> > > + - samsung,exynos3250-mfc\r\n" + "> > > + then:\r\n" + "> > > + properties:\r\n" + "> > > + clocks:\r\n" + "> > > + maxItems: 2\r\n" + "> > > + clock-names:\r\n" + "> > > + items:\r\n" + "> > > + - const: mfc\r\n" + "> > > + - const: sclk_mfc\r\n" + "> >\r\n" + "> > iommus:\r\n" + "> > maxItems: 1\r\n" + "> > iommu-names: false\r\n" + "> >\r\n" + "> I am getting compilation errors with above property set and its breaking the\r\n" + "> bindings.\r\n" + "> If we see these two nodes in dtsi files.\r\n" + "> mfc: codec@13400000 {\r\n" + "> compatible = \"samsung,mfc-v5\"; ..\r\n" + "> iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\r\n" + "> iommu-names = \"left\", \"right\"; } And\r\n" + "> mfc: codec@13400000 {\r\n" + "> compatible = \"samsung,exynos3250-mfc\", \"samsung,mfc-v7\";\r\n" + "> reg = <0x13400000 0x10000>; ...\r\n" + "> iommus = <&sysmmu_mfc>;\r\n" + "> };\r\n" + "> There is no iommu-names property for compatible \"samsung,exynos3250-\r\n" + "> mfc, samsung,mfc-v7\", that\342\200\231s why I kept\r\n" + "> iommus:\r\n" + "> minItems: 1\r\n" + "> maxItems: 2\r\n" + "> I would even go with below if you agree?\r\n" + "> iommus:\r\n" + "> minItems: 1\r\n" + "> maxItems: 2\r\n" + "> iommus-names: false\r\n" + "> \r\n" + "Hi Krzysztof,\r\n" + "Any suggestions here?\r\n" + "> > > +\r\n" + "> > > + - if:\r\n" + "> > > + properties:\r\n" + "> > > + compatible:\r\n" + "> > > + contains:\r\n" + "> > > + enum:\r\n" + "> > > + - samsung,mfc-v6\r\n" + "> > > + - samsung,mfc-v8\r\n" + "> > > + then:\r\n" + "> > > + properties:\r\n" + "> > > + clocks:\r\n" + "> > > + maxItems: 1\r\n" + "> > > + clock-names:\r\n" + "> > > + items:\r\n" + "> > > + - const: mfc\r\n" + "> > > + iommus:\r\n" + "> > > + maxItems: 2\r\n" + "> >\r\n" + "> > ... and here:\r\n" + "> > iommu-names:\r\n" + "> > items:\r\n" + "> > - const: left\r\n" + "> > - const: right\r\n" + "> >\r\n" + "> Agreed.\r\n" + "> > > +\r\n" + "> > > + - if:\r\n" + "> > > + properties:\r\n" + "> > > + compatible:\r\n" + "> > > + contains:\r\n" + "> > > + enum:\r\n" + "> > > + - samsung,exynos5433-mfc\r\n" + "> > > + then:\r\n" + "> > > + properties:\r\n" + "> > > + clocks:\r\n" + "> > > + maxItems: 3\r\n" + "> > > + clock-names:\r\n" + "> > > + items:\r\n" + "> > > + - const: pclk\r\n" + "> > > + - const: aclk\r\n" + "> > > + - const: aclk_xiu\r\n" + "> > > + iommus:\r\n" + "> > > + maxItems: 2\r\n" + "> >\r\n" + "> > the same here\r\n" + "> >\r\n" + "> Agreed.\r\n" + "> > > +\r\n" + "> > > + - if:\r\n" + "> > > + properties:\r\n" + "> > > + compatible:\r\n" + "> > > + contains:\r\n" + "> > > + enum:\r\n" + "> > > + - samsung,mfc-v7\r\n" + "> > > + then:\r\n" + "> > > + properties:\r\n" + "> > > + clocks:\r\n" + "> > > + minItems: 1\r\n" + "> > > + maxItems: 2\r\n" + "> >\r\n" + "> > iommus:\r\n" + "> > maxItems: 1\r\n" + "> > iommu-names: false\r\n" + "> same explanation as above. Would prefer to go with\r\n" + "> iommus:\r\n" + "> minItems: 1\r\n" + "> maxItems: 2\r\n" + "> iommus-names: false\r\n" + "> >\r\n" + "> >\r\n" + "> > Best regards,\r\n" + "> > Krzysztof\r\n" + "> \r\n" + > Thanks for the review. -fdc12a152f9bce621b499136dc70ce80eb4acb68d37eef36d024039791fa998b +3919c0c8c6a706489d70f2225ffb98a624b02c336de4dc1542a91f577aa0a194
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.