From: "sandeep.cs" <sandeep.cs@samsung.com>
To: "'Jiri Kosina'" <jikos@kernel.org>
Cc: "'Benjamin Tissoires'" <benjamin.tissoires@redhat.com>,
<gaudium.lee@samsung.com>, <ih0923.kim@samsung.com>,
<suhyun_.kim@samsung.com>, <jitender.s21@samsung.com>,
<junwan.cho@samsung.com>, <linux-input@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [HID Patchsets for Samsung driver v3 3/6] HID: Samsung : Add Samsung wireless keyboard support.
Date: Thu, 25 Jan 2024 08:26:56 +0530 [thread overview]
Message-ID: <000001da4f3a$2ea1bce0$8be536a0$@samsung.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2401241917490.29548@cbobk.fhfr.pm>
>On Wed, 24 Jan 2024, Sandeep C S wrote:
>
> Add Support for samsung wireless keyboard with input mapping events.
>
> Device 7021 (Samsung wireless keyboard)
>
> Signed-off-by: Sandeep C S <sandeep.cs@samsung.com>
> Signed-off-by: Junwan Cho <junwan.cho@samsung.com>
> Signed-off-by: Jitender Sajwan <jitender.s21@samsung.com>
> ---
> drivers/hid/hid-ids.h | 2 +
> drivers/hid/hid-samsung.c | 108
> ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 110 insertions(+)
>[ ... snip ... ]
> +#ifdef CONFIG_HID_KK_UPGRADE
>
>Where is CONFIG_HID_KK_UPGRADE coming from, please? This is the first time
I
>am seeing it, and it's definitely not being introduced by your patchset.
>
>Thanks,
>
>--
>Jiri Kosina
>SUSE Labs
Hello
Sorry for oversight!
It is custom handling code for keyboard keys in Samsung driver for android
devices. As suggested I will exclude this macro from open source submission.
I will be sending v4 patchsets shortly.
Thank you
next prev parent reply other threads:[~2024-01-25 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240124161058epcas5p40b641fe9049630c2a9ce69cab17c40b9@epcas5p4.samsung.com>
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 0/6] Sandeep C S
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 1/6] HID Samsung : Broaden device compatibility in samsung driver Sandeep C S
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 2/6] HID: Samsung : Fix the checkpatch complain. Rewritten code using memcmp where applicable Sandeep C S
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 3/6] HID: Samsung : Add Samsung wireless keyboard support Sandeep C S
2024-01-24 18:19 ` Jiri Kosina
2024-01-25 1:51 ` sandeep.cs
2024-01-25 2:56 ` sandeep.cs [this message]
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 4/6] HID: Samsung : Add Samsung wireless gamepad support Sandeep C S
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 5/6] HID: Samsung : Add Samsung wireless action mouse support Sandeep C S
2024-01-24 16:10 ` [HID Patchsets for Samsung driver v3 6/6] HID: Samsung : Add Samsung wireless bookcover and universal keyboard support Sandeep C S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001da4f3a$2ea1bce0$8be536a0$@samsung.com' \
--to=sandeep.cs@samsung.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gaudium.lee@samsung.com \
--cc=ih0923.kim@samsung.com \
--cc=jikos@kernel.org \
--cc=jitender.s21@samsung.com \
--cc=junwan.cho@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suhyun_.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.