diff for duplicates of <000001dc1c02$cc89fda0$659df8e0$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 10031e6..0158e91 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -141,50 +141,57 @@ Hi Krzysztof, > > > Could you please help with an example from previous any commit or > > > some > > other patches? -> > > I understand that mentioning, “two clocks, two supplies etc" are\r -> > > part of schema, one may or may not capture that in the commit.\r -> > > However mentioning, “this hardware (SoC) contain a combo PHY which\r -> > supports usb3.1 and usb3.0" is not ok?\r -> >\r -> >\r -> > Maybe that's just language, but to me the commit msg did not describe\r -> > hardware after first sentence, but said what schema requires (some\r -> > clocks and supplies). Other examples:\r -> > 00399bbe02d2bb6fd8d6eb90573ec305616449f4\r -> > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\r -> >\r -> \r -> Thank you for the pointers, will refer the examples and update the commit\r -> messages accordingly.\r -\r -Can you please confirm, if below message looks fine?\r -\r -" \r -dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy\r -\r -The USBDRD31 5nm controller consists of Synopsys USB20 phy and \r -USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found\r -on combophy of the ExynosAutov920 SoC.\r -"\r -\r -> \r -> > and here another anti-pattern:\r -> > 23f793850e9ee7390584c0809f085d6c88de7d3f\r -> >\r -> > (and before you ask why above carries my Rb tag, then note that\r -> > Samsung's revenue is around 220 billion USD, so for sure it has a lot,\r -> > really a lot of resources to review patches internally and improve\r -> > their quality before posting).\r -> >\r -> > Best regards,\r -> > Krzysztof\r -> \r -> Thank you.\r -> \r -> Regards,\r -> Pritam\r -\r -Thank you. \r -\r -Regards,\r +> > > I understand that mentioning, “two clocks, two supplies etc" are +> > > part of schema, one may or may not capture that in the commit. +> > > However mentioning, “this hardware (SoC) contain a combo PHY which +> > supports usb3.1 and usb3.0" is not ok? +> > +> > +> > Maybe that's just language, but to me the commit msg did not describe +> > hardware after first sentence, but said what schema requires (some +> > clocks and supplies). Other examples: +> > 00399bbe02d2bb6fd8d6eb90573ec305616449f4 +> > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb +> > +> +> Thank you for the pointers, will refer the examples and update the commit +> messages accordingly. + +Can you please confirm, if below message looks fine? + +" +dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy + +The USBDRD31 5nm controller consists of Synopsys USB20 phy and +USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found +on combophy of the ExynosAutov920 SoC. +" + +> +> > and here another anti-pattern: +> > 23f793850e9ee7390584c0809f085d6c88de7d3f +> > +> > (and before you ask why above carries my Rb tag, then note that +> > Samsung's revenue is around 220 billion USD, so for sure it has a lot, +> > really a lot of resources to review patches internally and improve +> > their quality before posting). +> > +> > Best regards, +> > Krzysztof +> +> Thank you. +> +> Regards, +> Pritam + +Thank you. + +Regards, Pritam + + + +-- +linux-phy mailing list +linux-phy@lists.infradead.org +https://lists.infradead.org/mailman/listinfo/linux-phy diff --git a/a/content_digest b/N1/content_digest index b1cda67..0e6bdbd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -181,52 +181,59 @@ "> > > Could you please help with an example from previous any commit or\n" "> > > some\n" "> > other patches?\n" - "> > > I understand that mentioning, \342\200\234two clocks, two supplies etc\" are\r\n" - "> > > part of schema, one may or may not capture that in the commit.\r\n" - "> > > However mentioning, \342\200\234this hardware (SoC) contain a combo PHY which\r\n" - "> > supports usb3.1 and usb3.0\" is not ok?\r\n" - "> >\r\n" - "> >\r\n" - "> > Maybe that's just language, but to me the commit msg did not describe\r\n" - "> > hardware after first sentence, but said what schema requires (some\r\n" - "> > clocks and supplies). Other examples:\r\n" - "> > 00399bbe02d2bb6fd8d6eb90573ec305616449f4\r\n" - "> > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\r\n" - "> >\r\n" - "> \r\n" - "> Thank you for the pointers, will refer the examples and update the commit\r\n" - "> messages accordingly.\r\n" - "\r\n" - "Can you please confirm, if below message looks fine?\r\n" - "\r\n" - "\" \r\n" - "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy\r\n" - "\r\n" - "The USBDRD31 5nm controller consists of Synopsys USB20 phy and \r\n" - "USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found\r\n" - "on combophy of the ExynosAutov920 SoC.\r\n" - "\"\r\n" - "\r\n" - "> \r\n" - "> > and here another anti-pattern:\r\n" - "> > 23f793850e9ee7390584c0809f085d6c88de7d3f\r\n" - "> >\r\n" - "> > (and before you ask why above carries my Rb tag, then note that\r\n" - "> > Samsung's revenue is around 220 billion USD, so for sure it has a lot,\r\n" - "> > really a lot of resources to review patches internally and improve\r\n" - "> > their quality before posting).\r\n" - "> >\r\n" - "> > Best regards,\r\n" - "> > Krzysztof\r\n" - "> \r\n" - "> Thank you.\r\n" - "> \r\n" - "> Regards,\r\n" - "> Pritam\r\n" - "\r\n" - "Thank you. \r\n" - "\r\n" - "Regards,\r\n" - Pritam + "> > > I understand that mentioning, \342\200\234two clocks, two supplies etc\" are\n" + "> > > part of schema, one may or may not capture that in the commit.\n" + "> > > However mentioning, \342\200\234this hardware (SoC) contain a combo PHY which\n" + "> > supports usb3.1 and usb3.0\" is not ok?\n" + "> >\n" + "> >\n" + "> > Maybe that's just language, but to me the commit msg did not describe\n" + "> > hardware after first sentence, but said what schema requires (some\n" + "> > clocks and supplies). Other examples:\n" + "> > 00399bbe02d2bb6fd8d6eb90573ec305616449f4\n" + "> > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\n" + "> >\n" + "> \n" + "> Thank you for the pointers, will refer the examples and update the commit\n" + "> messages accordingly.\n" + "\n" + "Can you please confirm, if below message looks fine?\n" + "\n" + "\" \n" + "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy\n" + "\n" + "The USBDRD31 5nm controller consists of Synopsys USB20 phy and \n" + "USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found\n" + "on combophy of the ExynosAutov920 SoC.\n" + "\"\n" + "\n" + "> \n" + "> > and here another anti-pattern:\n" + "> > 23f793850e9ee7390584c0809f085d6c88de7d3f\n" + "> >\n" + "> > (and before you ask why above carries my Rb tag, then note that\n" + "> > Samsung's revenue is around 220 billion USD, so for sure it has a lot,\n" + "> > really a lot of resources to review patches internally and improve\n" + "> > their quality before posting).\n" + "> >\n" + "> > Best regards,\n" + "> > Krzysztof\n" + "> \n" + "> Thank you.\n" + "> \n" + "> Regards,\n" + "> Pritam\n" + "\n" + "Thank you. \n" + "\n" + "Regards,\n" + "Pritam\n" + "\n" + "\n" + "\n" + "-- \n" + "linux-phy mailing list\n" + "linux-phy@lists.infradead.org\n" + https://lists.infradead.org/mailman/listinfo/linux-phy -e82eccfb4168b20e03db5a2749a712abf3bf96434c84052e7ad32ba6fcbf3988 +5927fa94246f82cbf660482fe179d107784288aa73c6e7b06159b05e23bf03c3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.