From: "Matthew Leach" <matthew.leach@arm.com>
To: 'Simon Horman' <horms@verge.net.au>
Cc: kexec@lists.infradead.org, Will Deacon <Will.Deacon@arm.com>
Subject: RE: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM
Date: Thu, 6 Sep 2012 12:04:50 +0100 [thread overview]
Message-ID: <000101cd8c1f$6f758520$4e608f60$@leach@arm.com> (raw)
In-Reply-To: <20120906032901.GG6432@verge.net.au>
Hi Simon,
I have been having some issues using kexec with your dtb patches...
> Thanks. It was that part of the code that I spent the bulk of my time
> on.
> And although it is still has a few rough edges I would be happy for it
> to be used.
I have looked at the output from your generic fs2dt and compared
it to the original dts and all looks okay so I'm happy that this
part of your code works fine.
> I would prefer to avoid requiring kernel changes unless necessary -
> the kernels some of the boards I work with require DT since 3.5.
> However, I am happy to discuss this further, there certainly is
> merit to a clean implementation.
I believe that you are loading the dtb at an offset from the base
of 0x1000, this is where the problem lies in that the dtb can be
corrupted by the page tables of the decompressor.
Also, device trees can contain firmware and as such be on the
order of megabytes in size. This could potentially corrupt the
decompressor image depending upon the order that these two blobs
are written to memory.
I suggest that we put the DTB out of the way, perhaps just after
the initrd segment, or at the initrd_offset in the case that
there is no initrd. This would require a kernel change to set the
correct parameter to the relocate_new_kerenel function, but the
change is minimal.
If you are happy with this, I have a set of patches that does the
job.
Matt
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-09-06 11:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:43 [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 1/4] Fix an overflow bug with address comparison Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 2/4] Move libfdt to a generic location Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 3/4] Add the dtc for device-tree manipulation Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 4/4] Add device tree support to the ARM platform Matthew Leach
2012-09-05 12:38 ` [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM Simon Horman
2012-09-05 14:34 ` Matthew Leach
2012-09-06 3:29 ` Simon Horman
2012-09-06 9:01 ` Will Deacon
2012-09-06 9:09 ` Simon Horman
2012-09-06 9:14 ` Will Deacon
2012-09-06 22:03 ` Simon Horman
2012-09-06 11:04 ` Matthew Leach [this message]
2012-09-06 11:19 ` Will Deacon
2012-09-06 22:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101cd8c1f$6f758520$4e608f60$@leach@arm.com' \
--to=matthew.leach@arm.com \
--cc=Will.Deacon@arm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.