From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>
Cc: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
"'Jaehoon Chung'" <jh80.chung@samsung.com>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
<linux-phy@lists.infradead.org>
Subject: RE: [PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver
Date: Tue, 6 Jul 2021 08:57:50 +0900 [thread overview]
Message-ID: <000101d771f9$8fe64ff0$afb2efd0$@samsung.com> (raw)
In-Reply-To: <bb462ea1-7a94-b697-a716-218594439487@canonical.com>
> > - samsung,exynos7-ufs-phy
> > + - samsung,exynosauto-ufs-phy
>
> I would prefer real product ID (taken from registers or vendor kernel),
> not a marketing name "Auto" because it's too generic, unspecified, too
> much as wildcard.
>
> If vendor kernel does not define name or product ID is also not specific,
> then it should include a version - so "autov9".
"samsung,exynosautov9-ufs-phy" can be a full name which can describe the SoC.
> I know that Exynos7 UFS did it but it was wrong. Headers should not define
> structures. What if a header needs to be included in different
> objects/units?
>
> This should be probably a separate file (C file). Something like we did
> for Exynos PMU (drivers/soc/samsung/exynos-pmu.h).
It makes sense to me. I'll move the structures from "phy-exynos7-ufs.h"
to "phy-exynos7-ufs.c" and create "phy-exynosautov9-ufs.c".
Best Regards,
Chanho Park
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2021-07-05 23:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210705102339epcas2p2963b4eb64ad038315a7b8da304b37218@epcas2p2.samsung.com>
2021-07-05 10:23 ` [PATCH 0/2] Support exynosauto ufs phy driver Chanho Park
2021-07-05 10:23 ` [PATCH 1/2] phy: samsung-ufs: custom PHY_TRSV_CH_OFFSET support Chanho Park
2021-07-05 12:17 ` Krzysztof Kozlowski
2021-07-05 23:52 ` Chanho Park
2021-07-05 10:23 ` [PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver Chanho Park
2021-07-05 12:29 ` Krzysztof Kozlowski
2021-07-05 12:35 ` Krzysztof Kozlowski
2021-07-05 23:57 ` Chanho Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d771f9$8fe64ff0$afb2efd0$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-phy@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.