All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: irq: introduce entry and exit functions for chained handlers
Date: Mon, 14 Mar 2011 13:04:41 -0000	[thread overview]
Message-ID: <000201cbe248$622585a0$267090e0$@deacon@arm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1103112017500.2787@localhost6.localdomain6>

> > > That wants a comment that these functions are only dealing with
> > > fasteoi and level type flow control.
> > >
> > > Otherwise fine with me. Feel free to add my Acked-by.
> >
> > Thanks Thomas, reworded as followed:
> >
> >     ARM: irq: introduce entry and exit functions for chained handlers
> >
> >     Some chained IRQ handlers are written to cope with primary chips of
> >     potentially different flow types. Whether this a sensible thing to do
> >     is a point of contention.
> >
> >     This patch introduces entry/exit functions for chained handlers which
> >     infer the flow type of the primary chip as fasteoi or level-type by
> >     checking whether or not the ->irq_eoi function pointer is present and
> >     calling back to the primary chip as necessary. Other methods of flow
> >     control are not considered.
> >
> > I'll add your Ack and put this (patch 1) in Russell's patch system next
> > week.
> 
> Having it in the changelog is nice, but the code itself would like a
> comment as well.

Rightio, submitted to Russell's patch system with code comment as 6806/1.

Thanks,

Will

  reply	other threads:[~2011-03-14 13:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 17:13 [PATCH v3 0/7] Migrate GIC to fasteoi flow control Will Deacon
2011-03-08 17:13 ` [PATCH 1/7] ARM: irq: introduce entry and exit functions for chained handlers Will Deacon
2011-03-11 16:33   ` Thomas Gleixner
2011-03-11 16:56     ` Will Deacon
2011-03-11 19:19       ` Thomas Gleixner
2011-03-14 13:04         ` Will Deacon [this message]
2011-03-08 17:13 ` [PATCH 2/7] ARM: omap: update GPIO chained IRQ handler to use entry/exit functions Will Deacon
2011-03-08 17:13 ` [PATCH 3/7] ARM: tegra: " Will Deacon
2011-03-08 17:13 ` [PATCH 4/7] ARM: s5pv310: update IRQ combiner to use chained " Will Deacon
2011-03-08 17:13 ` [PATCH 5/7] ARM: msm: update GPIO chained IRQ handler to use " Will Deacon
2011-03-08 17:13 ` [PATCH 6/7] ARM: nmk: update GPIO chained IRQ handler to " Will Deacon
2011-03-08 17:13 ` [PATCH 7/7] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-03-11 15:59 ` [PATCH v3 0/7] Migrate GIC to fasteoi flow control Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000201cbe248$622585a0$267090e0$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.