All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seungwon Jeon <tgih.jun@samsung.com>
To: merez@codeaurora.org
Cc: linux-mmc@vger.kernel.org, 'Chris Ball' <cjb@laptop.org>,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device
Date: Fri, 01 Jun 2012 14:51:23 +0900	[thread overview]
Message-ID: <000201cd3fba$942df840$bc89e8c0$%jun@samsung.com> (raw)
In-Reply-To: <7155413ec18f57c1151a29992be32b1f.squirrel@www.codeaurora.org>

Maya Erez <merez@codeaurora.org> wrote:
> > @@ -1313,10 +1609,17 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue
> *mq, struct request *rqc)
> >  			 * A block was successfully transferred.
> >  			 */
> >  			mmc_blk_reset_success(md, type);
> > -			spin_lock_irq(&md->lock);
> > -			ret = __blk_end_request(req, 0,
> > +
> > +			if (mq_rq->packed_cmd != MMC_PACKED_NONE) {
> > +				ret = mmc_blk_end_packed_req(mq, mq_rq);
> If a specific request in the packed request consistantly fails, there is
> nothing to stop us from sending the same packed request in an endless
> loop.
There is various error case. This patch reused the existing error handling.
What is that case we need to consider?

Best regards,
Seungwon Jeon

> > +				break;
> 
> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2012-06-01  5:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 19:18 [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device merez
2012-06-01  5:51 ` Seungwon Jeon [this message]
2012-06-01 16:45   ` merez
2012-06-01 16:45     ` merez
2012-06-04 11:01     ` Seungwon Jeon
2012-06-05 20:05       ` merez
2012-06-05 20:05         ` merez
     [not found] <Ac00EUo+2nBqzILnT1exc3J2o9DRYg==>
2012-05-17  9:41 ` Seungwon Jeon
2012-05-20 11:32   ` merez
2012-05-20 11:32     ` merez
2012-05-31  8:01   ` S, Venkatraman
2012-06-01  5:48     ` Seungwon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000201cd3fba$942df840$bc89e8c0$%jun@samsung.com' \
    --to=tgih.jun@samsung.com \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=merez@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.