From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Date: Mon, 27 Nov 2017 18:06:30 +0000 Subject: Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob Message-Id: <000201d367aa$74511b10$5cf35130$@gmail.com> List-Id: References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> In-Reply-To: <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'SF Markus Elfring' , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Bartlomiej Zolnierkiewicz' Cc: kernel-janitors@vger.kernel.org, 'LKML' On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:00:16 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 5f4f696c2ecf..0914c973cbd9 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device > *pdev) > } > > sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL); > - if (!sfb) { > - dev_err(dev, "no memory for framebuffers\n"); > + if (!sfb) > return -ENOMEM; > - } > > dev_dbg(dev, "allocate new framebuffer %p\n", sfb); > > -- > 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() Date: Mon, 27 Nov 2017 13:06:30 -0500 Message-ID: <000201d367aa$74511b10$5cf35130$@gmail.com> References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9604F6E34C for ; Mon, 27 Nov 2017 18:06:33 +0000 (UTC) Received: by mail-qk0-x241.google.com with SMTP id o6so33570470qkh.3 for ; Mon, 27 Nov 2017 10:06:33 -0800 (PST) In-Reply-To: <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'SF Markus Elfring' , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Bartlomiej Zolnierkiewicz' Cc: kernel-janitors@vger.kernel.org, 'LKML' List-Id: dri-devel@lists.freedesktop.org T24gU3VuZGF5LCBOb3ZlbWJlciAyNiwgMjAxNyA5OjE3IEFNLCBTRiBNYXJrdXMgRWxmcmluZyB3 cm90ZToKPiAKPiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3Jn ZS5uZXQ+Cj4gRGF0ZTogU3VuLCAyNiBOb3YgMjAxNyAxNTowMDoxNiArMDEwMAo+IAo+IE9taXQg YW4gZXh0cmEgbWVzc2FnZSBmb3IgYSBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlIGluIHRoaXMg ZnVuY3Rpb24uCj4gCj4gVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2Np bmVsbGUgc29mdHdhcmUuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVsZnJp bmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgoKQWNrZWQtYnk6IEppbmdvbyBIYW4gPGppbmdvb2hh bjFAZ21haWwuY29tPgoKQmVzdCByZWdhcmRzLApKaW5nb28gSGFuCgo+IC0tLQo+ICBkcml2ZXJz L3ZpZGVvL2ZiZGV2L3MzYy1mYi5jIHwgNCArLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9m YmRldi9zM2MtZmIuYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvczNjLWZiLmMKPiBpbmRleCA1ZjRm Njk2YzJlY2YuLjA5MTRjOTczY2JkOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2 L3MzYy1mYi5jCj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRldi9zM2MtZmIuYwo+IEBAIC0xMzg0 LDEwICsxMzg0LDggQEAgc3RhdGljIGludCBzM2NfZmJfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZQo+ICpwZGV2KQo+ICAJfQo+IAo+ICAJc2ZiID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9m KHN0cnVjdCBzM2NfZmIpLCBHRlBfS0VSTkVMKTsKPiAtCWlmICghc2ZiKSB7Cj4gLQkJZGV2X2Vy cihkZXYsICJubyBtZW1vcnkgZm9yIGZyYW1lYnVmZmVyc1xuIik7Cj4gKwlpZiAoIXNmYikKPiAg CQlyZXR1cm4gLUVOT01FTTsKPiAtCX0KPiAKPiAgCWRldl9kYmcoZGV2LCAiYWxsb2NhdGUgbmV3 IGZyYW1lYnVmZmVyICVwXG4iLCBzZmIpOwo+IAo+IC0tCj4gMi4xNS4wCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbdK0SGh (ORCPT ); Mon, 27 Nov 2017 13:06:37 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:33114 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225AbdK0SGd (ORCPT ); Mon, 27 Nov 2017 13:06:33 -0500 X-Google-Smtp-Source: AGs4zMb6eQWtnRPIKQ8b/sjoX0CDyyB/tu7unKV08x6w99tkPRbT6mS97yrTOsQb0WvM3eXeJDhkGw== From: "Jingoo Han" To: "'SF Markus Elfring'" , , , "'Bartlomiej Zolnierkiewicz'" Cc: "'LKML'" , References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> In-Reply-To: <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net> Subject: Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() Date: Mon, 27 Nov 2017 13:06:30 -0500 Message-ID: <000201d367aa$74511b10$5cf35130$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQKhendjzDbQ5QEsTe4g6SvvMrwpmAJQAVGwoXnfe0A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:00:16 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 5f4f696c2ecf..0914c973cbd9 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device > *pdev) > } > > sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL); > - if (!sfb) { > - dev_err(dev, "no memory for framebuffers\n"); > + if (!sfb) > return -ENOMEM; > - } > > dev_dbg(dev, "allocate new framebuffer %p\n", sfb); > > -- > 2.15.0