All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Krystad" <pkrystad@codeaurora.org>
To: "'Andrei Emeltchenko'" <andrei.emeltchenko.news@gmail.com>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH 2/4] Add parsing of A2MP signals
Date: Wed, 26 Oct 2011 11:49:41 -0700	[thread overview]
Message-ID: <000301cc9410$05ae5340$110af9c0$@org> (raw)
In-Reply-To: <20111026133343.GE11385@aemeltch-MOBL1>


Hi Andrei,

> >
> > +static inline void amp_command_rej(int level, struct frame *frm)
> > +{
> > +	amp_cmd_rej_parms *h = frm->ptr;
> > +	uint16_t reason = btohs(h->reason);
> > +
> > +	if (p_filter(FILT_A2MP))
> > +		return;
> > +
> > +	printf("Command Reject: reason (%d)- ", reason);
> > +	p_indent(level + 1, frm);
> 
> This doesn't make sense to use p_indent if you print on the same line.
> Maybe you forgot "\n" ?
> 
> > +	printf("%s\n", ampreason2str(reason));
> > +}
> > +
> 

Will add a '\n'. 

I'll repost this patch set after the bluez header patchset is approved.

Peter.

--Peter Krystad
  Employee of Qualcomm Innovation Center, Inc.
  Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum



  reply	other threads:[~2011-10-26 18:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 23:29 [PATCH 0/4] Add parsing of BT 3.0+HS signalling Peter Krystad
2011-10-21 23:29 ` [PATCH 1/4] Add parsing of L2CAP Create/Move Channel signals Peter Krystad
2011-10-22  7:21   ` Marcel Holtmann
2011-10-21 23:30 ` [PATCH 2/4] Add parsing of A2MP signals Peter Krystad
2011-10-24  7:34   ` Andrei Emeltchenko
2011-10-26 13:33   ` Andrei Emeltchenko
2011-10-26 18:49     ` Peter Krystad [this message]
2011-10-21 23:30 ` [PATCH 3/4] Add parsing of L2CAP Fixed Channel list Peter Krystad
2011-10-24  7:51   ` Andrei Emeltchenko
2011-10-21 23:30 ` [PATCH 4/4] Minor cleanup of indentation in output Peter Krystad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000301cc9410$05ae5340$110af9c0$@org' \
    --to=pkrystad@codeaurora.org \
    --cc=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.