From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH] f2fs: remove the own bi_private allocation Date: Mon, 02 Dec 2013 16:59:28 +0800 Message-ID: <000301ceef3c$ecee00a0$c6ca01e0$@samsung.com> References: <1385776085-21163-1-git-send-email-jaegeuk.kim@samsung.com> <000201ceef25$e145cec0$a3d16c40$@samsung.com> <1385972094.2417.104.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VnPMi-0003hr-VG for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Dec 2013 09:00:29 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-MD5:128) (Exim 4.76) id 1VnPMg-0000aP-R6 for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Dec 2013 09:00:28 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MX60058490I47D0@mailout4.samsung.com> for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Dec 2013 18:00:18 +0900 (KST) In-reply-to: <1385972094.2417.104.camel@kjgkr> Content-language: zh-cn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: jaegeuk.kim@samsung.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net SGkgS2ltLAoKPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphZWdldWsgS2lt IFttYWlsdG86amFlZ2V1ay5raW1Ac2Ftc3VuZy5jb21dCj4gU2VudDogTW9uZGF5LCBEZWNlbWJl ciAwMiwgMjAxMyA0OjE1IFBNCj4gVG86IENoYW8gWXUKPiBDYzogbGludXgtZnNkZXZlbEB2Z2Vy Lmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWYyZnMtZGV2 ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0OyDosK3lp50KPiBTdWJqZWN0OiBSRTogW2YyZnMtZGV2 XSBbUEFUQ0hdIGYyZnM6IHJlbW92ZSB0aGUgb3duIGJpX3ByaXZhdGUgYWxsb2NhdGlvbgo+IAo+ IDIwMTMtMTItMDIgKOyblCksIDE0OjE0ICswODAwLCBDaGFvIFl1Ogo+ID4gSGkgS2ltLAo+ID4K PiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+ID4gRnJvbTogSmFlZ2V1ayBLaW0g W21haWx0bzpqYWVnZXVrLmtpbUBzYW1zdW5nLmNvbV0KPiA+ID4gU2VudDogU2F0dXJkYXksIE5v dmVtYmVyIDMwLCAyMDEzIDk6NDggQU0KPiA+ID4gQ2M6IGxpbnV4LWZzZGV2ZWxAdmdlci5rZXJu ZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1mMmZzLWRldmVsQGxp c3RzLnNvdXJjZWZvcmdlLm5ldAo+ID4gPiBTdWJqZWN0OiBbZjJmcy1kZXZdIFtQQVRDSF0gZjJm czogcmVtb3ZlIHRoZSBvd24gYmlfcHJpdmF0ZSBhbGxvY2F0aW9uCj4gPiA+Cj4gPiA+IFByZXZp b3VzbHkgZjJmcyBhbGxvY2F0ZXMgaXRzIG93biBiaV9wcml2YXRlIGRhdGEgc3RydWN0dXJlIGFs bCB0aGUgdGltZSBldmVuCj4gPiA+IHRob3VnaCB3ZSBkb24ndCB1c2UgaXQuIEJ1dCwgY2FuIHdl IHJlbW92ZSB0aGlzIGJpX3ByaXZhdGUgYWxsb2NhdGlvbj8KPiA+ID4KPiA+ID4gVGhpcyBwYXRj aCByZW1vdmVzIHN1Y2ggdGhlIGFkZGl0aW9uYWwgYmlfcHJpdmF0ZSBhbGxvY2F0aW9uLgo+ID4g Pgo+ID4gPiAxLiBSZXRyaWV2ZSBmMmZzX3NiX2luZm8gZnJvbSBpdHMgcGFnZS0+bWFwcGluZy0+ aG9zdC0+aV9zYi4KPiA+ID4gIC0gVGhpcyByZW1vdmVzIHRoZSB1c2VjYXNlcyBvZiBiaV9wcml2 YXRlIGluIGVuZF9pby4KPiA+ID4KPiA+ID4gMi4gVXNlIGJpX3ByaXZhdGUgb25seSB3aGVuIHdl IHJlYWxseSBuZWVkIGl0Lgo+ID4gPiAgLSBUaGUgYmlfcHJpdmF0ZSBpcyB1c2VkIG9ubHkgd2hl biB0aGUgY2hlY2twb2ludCBwcm9jZWR1cmUgaXMgY29uZHVjdGVkLgo+ID4gPiAgLSBXaGVuIGNv bmR1Y3RpbmcgdGhlIGNoZWNrcG9pbnQsIGYyZnMgc3VibWl0cyBhIE1FVEFfRkxVU0ggYmlvIHRv IHdhaXQgaXRzIGJpbwo+ID4gPiBjb21wbGV0aW9uLgo+ID4gPiAgLSBTaW5jZSB3ZSBoYXZlIG5v IGRlcGVuZGFuY2llcyB0byByZW1vdmUgYmlfcHJpdmF0ZSBub3csIGxldCdzIGp1c3QgdXNlCj4g PiA+ICBiaV9wcml2YXRlIHBvaW50ZXIgYXMgdGhlIGNvbXBsZXRpb24gcG9pbnRlci4KPiA+ID4K PiA+ID4gU2lnbmVkLW9mZi1ieTogSmFlZ2V1ayBLaW0gPGphZWdldWsua2ltQHNhbXN1bmcuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGZzL2YyZnMvc2VnbWVudC5jIHwgNDMgKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgZnMvZjJmcy9zZWdtZW50LmggfCAg NyAtLS0tLS0tCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDM0IGRl bGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9zZWdtZW50LmMgYi9m cy9mMmZzL3NlZ21lbnQuYwo+ID4gPiBpbmRleCAwMzg3ODYzLi4wZGI0MDI3IDEwMDY0NAo+ID4g PiAtLS0gYS9mcy9mMmZzL3NlZ21lbnQuYwo+ID4gPiArKysgYi9mcy9mMmZzL3NlZ21lbnQuYwo+ ID4gPiBAQCAtNzkxLDcgKzc5MSw3IEBAIHN0YXRpYyB2b2lkIGYyZnNfZW5kX2lvX3dyaXRlKHN0 cnVjdCBiaW8gKmJpbywgaW50IGVycikKPiA+ID4gIHsKPiA+ID4gIAljb25zdCBpbnQgdXB0b2Rh dGUgPSB0ZXN0X2JpdChCSU9fVVBUT0RBVEUsICZiaW8tPmJpX2ZsYWdzKTsKPiA+ID4gIAlzdHJ1 Y3QgYmlvX3ZlYyAqYnZlYyA9IGJpby0+YmlfaW9fdmVjICsgYmlvLT5iaV92Y250IC0gMTsKPiA+ ID4gLQlzdHJ1Y3QgYmlvX3ByaXZhdGUgKnAgPSBiaW8tPmJpX3ByaXZhdGU7CgoJCWYyZnNfYnVn X29uKHVubGlrZWx5KCFidmVjLT5idl9wYWdlLT5tYXBwaW5nKSk7Cgo+ID4gPiArCXN0cnVjdCBm MmZzX3NiX2luZm8gKnNiaSA9IEYyRlNfU0IoYnZlYy0+YnZfcGFnZS0+bWFwcGluZy0+aG9zdC0+ aV9zYik7Cj4gPgo+ID4gSSdtIG5vdCBzdXJlIHdoZXRoZXIgYnZlYy0+YnZfcGFnZS0+bWFwcGlu ZyB3aWxsIGJlIHNldCB0byBOVUxMIGluIHRoZSBmbG93Cj4gPiB3aGVyZSBtYXkgbm90IGNoZWNr IFdSSVRFQkFDSyBmbGFnIG9mIHBhZ2UuIElzIGl0IHBvc3NpYmxlPwo+IAo+IFRoZSBtYXBwaW5n IHNob3VsZCBiZSBub3QgTlVMTCBjYXVzZSBpdCBpcyBhIHdyaXRlYmFja2luZyBwYWdlLgo+IE90 aGVyd2lzZSwgaXQncyBhIGJ1Zy4KCklmIHNvLCBzaG91bGQgd2UgYWRkIGFkZGl0aW9uYWwgY29k ZSBhcyBhYm92ZT8KClJlZ2FyZHMsCll1Cgo+IFRoYW5rcywKPiAKPiAtLQo+IEphZWdldWsgS2lt Cj4gU2Ftc3VuZwoKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpSYXBpZGx5IHRyb3VibGVzaG9vdCBw cm9ibGVtcyBiZWZvcmUgdGhleSBhZmZlY3QgeW91ciBidXNpbmVzcy4gTW9zdCBJVCAKb3JnYW5p emF0aW9ucyBkb24ndCBoYXZlIGEgY2xlYXIgcGljdHVyZSBvZiBob3cgYXBwbGljYXRpb24gcGVy Zm9ybWFuY2UgCmFmZmVjdHMgdGhlaXIgcmV2ZW51ZS4gV2l0aCBBcHBEeW5hbWljcywgeW91IGdl dCAxMDAlIHZpc2liaWxpdHkgaW50byB5b3VyIApKYXZhLC5ORVQsICYgUEhQIGFwcGxpY2F0aW9u LiBTdGFydCB5b3VyIDE1LWRheSBGUkVFIFRSSUFMIG9mIEFwcER5bmFtaWNzIFBybyEKaHR0cDov L3B1YmFkcy5nLmRvdWJsZWNsaWNrLm5ldC9nYW1wYWQvY2xrP2lkPTg0MzQ5MzUxJml1PS80MTQw L29zdGcuY2xrdHJrCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMu c291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3Rp bmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664Ab3LBJAV (ORCPT ); Mon, 2 Dec 2013 04:00:21 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:29053 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170Ab3LBJAU convert rfc822-to-8bit (ORCPT ); Mon, 2 Dec 2013 04:00:20 -0500 X-AuditID: cbfee61b-b7f166d000007a34-80-529c4c2223d1 From: Chao Yu To: jaegeuk.kim@samsung.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, =?UTF-8?B?J+iwreWnnSc=?= References: <1385776085-21163-1-git-send-email-jaegeuk.kim@samsung.com> <000201ceef25$e145cec0$a3d16c40$@samsung.com> <1385972094.2417.104.camel@kjgkr> In-reply-to: <1385972094.2417.104.camel@kjgkr> Subject: RE: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation Date: Mon, 02 Dec 2013 16:59:28 +0800 Message-id: <000301ceef3c$ecee00a0$c6ca01e0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-index: AQGX/9NZphYaRjZNa5uMOVNLOkn7OgIOjC1XAgEHCL2ajfqOEA== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsVy+t9jQV0lnzlBBrOWyFtc3/WXyeLSIneL PXtPslhc3jWHzaJ14XlmB1aP3Qs+M3n0bVnF6PF5k1wAcxSXTUpqTmZZapG+XQJXxqY5PYwF 10Urdv1fw97AuF6wi5GTQ0LAROLOrV8sELaYxIV769lAbCGB6YwSv7fLQNg/GCUm96eC2GwC KhLLO/4zgdgiAtISsz7NA+tlFpjNKLF5tmMXIxdQ/UxGiZd/esASnAJ6Egs61zCD2MICXhIN p96xg9gsAqoSPW+vgMV5BSwlmu98Y4OwBSV+TL4HNVRdYtK8RcwQtrbEk3cXWCEOVZDYcfY1 I8QRThK7/syCqheX2HjkFssERqFZSEbNQjJqFpJRs5C0LGBkWcUomlqQXFCclJ5rpFecmFtc mpeul5yfu4kRHAPPpHcwrmqwOMQowMGoxMN74cTsICHWxLLiytxDjBIczEoivCx/gUK8KYmV ValF+fFFpTmpxYcYpTlYlMR5D7ZaBwoJpCeWpGanphakFsFkmTg4pRoYS1arr5yx9qdAcPtf I07psqMvnvkxC5g+VJUxiqpxN7I0uVXw7Jy7491ogQeyrsXJ+WfDq6p6Vx1eYhIScLMrYInu tL0ai/wZU3e27YzVVf65ZDqXUfWMU3qfFDJrIiTS7nDFqW/i8rLe+/fyBdtjfI/6L/zUrat6 w3/W3emQBNOx9eyXNKOVWIozEg21mIuKEwHLwIq+fQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kim, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk.kim@samsung.com] > Sent: Monday, December 02, 2013 4:15 PM > To: Chao Yu > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; 谭姝 > Subject: RE: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation > > 2013-12-02 (월), 14:14 +0800, Chao Yu: > > Hi Kim, > > > > > -----Original Message----- > > > From: Jaegeuk Kim [mailto:jaegeuk.kim@samsung.com] > > > Sent: Saturday, November 30, 2013 9:48 AM > > > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > > > Subject: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation > > > > > > Previously f2fs allocates its own bi_private data structure all the time even > > > though we don't use it. But, can we remove this bi_private allocation? > > > > > > This patch removes such the additional bi_private allocation. > > > > > > 1. Retrieve f2fs_sb_info from its page->mapping->host->i_sb. > > > - This removes the usecases of bi_private in end_io. > > > > > > 2. Use bi_private only when we really need it. > > > - The bi_private is used only when the checkpoint procedure is conducted. > > > - When conducting the checkpoint, f2fs submits a META_FLUSH bio to wait its bio > > > completion. > > > - Since we have no dependancies to remove bi_private now, let's just use > > > bi_private pointer as the completion pointer. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > fs/f2fs/segment.c | 43 ++++++++++++++++--------------------------- > > > fs/f2fs/segment.h | 7 ------- > > > 2 files changed, 16 insertions(+), 34 deletions(-) > > > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > > index 0387863..0db4027 100644 > > > --- a/fs/f2fs/segment.c > > > +++ b/fs/f2fs/segment.c > > > @@ -791,7 +791,7 @@ static void f2fs_end_io_write(struct bio *bio, int err) > > > { > > > const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); > > > struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; > > > - struct bio_private *p = bio->bi_private; f2fs_bug_on(unlikely(!bvec->bv_page->mapping)); > > > + struct f2fs_sb_info *sbi = F2FS_SB(bvec->bv_page->mapping->host->i_sb); > > > > I'm not sure whether bvec->bv_page->mapping will be set to NULL in the flow > > where may not check WRITEBACK flag of page. Is it possible? > > The mapping should be not NULL cause it is a writebacking page. > Otherwise, it's a bug. If so, should we add additional code as above? Regards, Yu > Thanks, > > -- > Jaegeuk Kim > Samsung