From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLWwp-0007RE-2w for qemu-devel@nongnu.org; Wed, 11 Feb 2015 08:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLWwl-0005Uf-UC for qemu-devel@nongnu.org; Wed, 11 Feb 2015 08:03:19 -0500 Received: from mail.ispras.ru ([83.149.199.45]:47516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLWwl-0005UL-NG for qemu-devel@nongnu.org; Wed, 11 Feb 2015 08:03:15 -0500 From: "Pavel Dovgaluk" References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <20150122085300.5276.19453.stgit@PASHA-ISP.def.inno> <54CB61B1.8060507@redhat.com> In-Reply-To: <54CB61B1.8060507@redhat.com> Date: Wed, 11 Feb 2015 16:03:14 +0300 Message-ID: <000301d045fb$19acfea0$4d06fbe0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v8 16/21] replay: bottom halves List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces bottom half event for replay queue. It saves the events > > into the queue and process them at the checkpoints and instructions execution. > > Which bottom halves must _not_ go through aio/qemu_bh_new_replay? The block layer and migration internal ones. They should not be replayed because are used for simulator purposes and not for VM execution. > > > +QEMUBH *aio_bh_new_replay(AioContext *ctx, QEMUBHFunc *cb, void *opaque, > > + uint64_t id) > > id is superfluous, it can always be replay_get_current_step(). > > It seems to me that the device models can always use qemu_bh_new_replay. > There are few if any uses of qemu_bh_new outside device models. > Perhaps convert those to aio_bh_new, and make qemu_bh_new always do > special replay treatment? I've created some kind of design document. Then I'll probably leave these changes until that document review. Pavel Dovgalyuk