From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>
Cc: 'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>,
'Linux PM list' <linux-pm@vger.kernel.org>
Subject: RE: [PATCH v2] cpufreq: intel_pstate: Generic governors support
Date: Thu, 17 Nov 2016 09:27:15 -0800 [thread overview]
Message-ID: <000301d240f7$d86604b0$89320e10$@net> (raw)
In-Reply-To: 6pwucKlLvdmHH6pwzcpEkV
On 2016.11.15 18:35 Rafael J. Wysocki wrote:
> -> v2:
> Notice that intel_cpufreq_target() generally can be called on a CPU
> different from the target one, so it needs to ensure that the right
> MSR will be written, so update the code accordingly. This makes
> the performance and powersave governors work with this driver as
> expected (at least).
With V2 I did the exact same tests with the ondemand, powersave,
and performance governors as I did with the previous versions
of this patch. Now everything works fine and as expected.
Thanks.
Also from this previous reply to
"[RFC/RFT][PATCH] cpufreq: intel_pstate: Generic governors support":
On 2016.11.01 17:14 Srinivas Pandruvada wrote:
> On Tue, 2016-11-01 at 14:11 -0700, Doug Smythies wrote:
>> On 2016.10.22 17:17 Rafael J. Wysocki wrote:
>>
>> It is not clear to me why users that currently use
>> intel_pstate=disable on the kernel command line would benefit from
>> this change.
> Two reasons I think:
> - We have a big turbo zone, where current acpi-cpufreq can't select any
> target frequency even if controllable.
>
> - We can still target ACPI-CPPC compatible devices in legacy mode and
> later in non-legacy mode.
V2 also fixes the test results (I was using clock modulation as
my test case), that caused me to erroneously think there would
be no benefit from intel_pstate=passive over intel_pstate=disable
in cases where the user has to use disable for proper operation.
... Doug
next reply other threads:[~2016-11-17 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 17:27 Doug Smythies [this message]
2016-11-17 21:06 ` [PATCH v2] cpufreq: intel_pstate: Generic governors support Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2016-11-16 2:35 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301d240f7$d86604b0$89320e10$@net' \
--to=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.