From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Date: Mon, 27 Nov 2017 18:07:15 +0000 Subject: Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() Message-Id: <000301d367aa$8efbbc40$acf334c0$@gmail.com> List-Id: References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> In-Reply-To: <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'SF Markus Elfring' , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Bartlomiej Zolnierkiewicz' Cc: kernel-janitors@vger.kernel.org, 'LKML' On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:03:03 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 0914c973cbd9..8c7623d63eb1 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev) > return -EINVAL; > } > > - sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL); > + sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL); > if (!sfb) > return -ENOMEM; > > -- > 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() Date: Mon, 27 Nov 2017 13:07:15 -0500 Message-ID: <000301d367aa$8efbbc40$acf334c0$@gmail.com> References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3F226E34A for ; Mon, 27 Nov 2017 18:07:18 +0000 (UTC) Received: by mail-qk0-x241.google.com with SMTP id o6so33573869qkh.3 for ; Mon, 27 Nov 2017 10:07:18 -0800 (PST) In-Reply-To: <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'SF Markus Elfring' , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Bartlomiej Zolnierkiewicz' Cc: kernel-janitors@vger.kernel.org, 'LKML' List-Id: dri-devel@lists.freedesktop.org T24gU3VuZGF5LCBOb3ZlbWJlciAyNiwgMjAxNyA5OjE4IEFNLCBTRiBNYXJrdXMgRWxmcmluZyB3 cm90ZToKPiAKPiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3Jn ZS5uZXQ+Cj4gRGF0ZTogU3VuLCAyNiBOb3YgMjAxNyAxNTowMzowMyArMDEwMAo+IAo+IFJlcGxh Y2UgdGhlIHNwZWNpZmljYXRpb24gb2YgYSBkYXRhIHN0cnVjdHVyZSBieSBhIHBvaW50ZXIgZGVy ZWZlcmVuY2UKPiBhcyB0aGUgcGFyYW1ldGVyIGZvciB0aGUgb3BlcmF0b3IgInNpemVvZiIgdG8g bWFrZSB0aGUgY29ycmVzcG9uZGluZyBzaXplCj4gZGV0ZXJtaW5hdGlvbiBhIGJpdCBzYWZlciBh Y2NvcmRpbmcgdG8gdGhlIExpbnV4IGNvZGluZyBzdHlsZSBjb252ZW50aW9uLgo+IAo+IFRoaXMg aXNzdWUgd2FzIGRldGVjdGVkIGJ5IHVzaW5nIHRoZSBDb2NjaW5lbGxlIHNvZnR3YXJlLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdl Lm5ldD4KCkFja2VkLWJ5OiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KCkJlc3Qg cmVnYXJkcywKSmluZ29vIEhhbgoKPiAtLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi9zM2MtZmIu YyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvczNjLWZiLmMgYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L3MzYy1mYi5jCj4gaW5kZXggMDkxNGM5NzNjYmQ5Li44Yzc2MjNkNjNlYjEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi9zM2MtZmIuYwo+ICsrKyBiL2RyaXZl cnMvdmlkZW8vZmJkZXYvczNjLWZiLmMKPiBAQCAtMTM4Myw3ICsxMzgzLDcgQEAgc3RhdGljIGlu dCBzM2NfZmJfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0KPiAKPiAtCXNmYiA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZihzdHJ1 Y3QgczNjX2ZiKSwgR0ZQX0tFUk5FTCk7Cj4gKwlzZmIgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXpl b2YoKnNmYiksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFzZmIpCj4gIAkJcmV0dXJuIC1FTk9NRU07 Cj4gCj4gLS0KPiAyLjE1LjAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbdK0SHU (ORCPT ); Mon, 27 Nov 2017 13:07:20 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:38377 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225AbdK0SHS (ORCPT ); Mon, 27 Nov 2017 13:07:18 -0500 X-Google-Smtp-Source: AGs4zMatbdjQpr0DQaDTPkCkbYX/NbXYBsFV6CAUWwA7x3/X06cPQJ+6V2O0okQ7fCf1xtF8ovYGRA== From: "Jingoo Han" To: "'SF Markus Elfring'" , , , "'Bartlomiej Zolnierkiewicz'" Cc: "'LKML'" , References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> In-Reply-To: <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> Subject: Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() Date: Mon, 27 Nov 2017 13:07:15 -0500 Message-ID: <000301d367aa$8efbbc40$acf334c0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQKhendjzDbQ5QEsTe4g6SvvMrwpmAJXCYfNoXmnqXA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:03:03 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 0914c973cbd9..8c7623d63eb1 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev) > return -EINVAL; > } > > - sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL); > + sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL); > if (!sfb) > return -ENOMEM; > > -- > 2.15.0