From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Artem Labazov'" <123321artyom@gmail.com>
Cc: <stable@vger.kernel.org>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] exfat: Avoid allocating upcase table using kcalloc()
Date: Mon, 7 Dec 2020 13:32:34 +0900 [thread overview]
Message-ID: <000301d6cc51$fc2b6d10$f4824730$@samsung.com> (raw)
In-Reply-To: <20201204133348.555024-1-123321artyom@gmail.com>
> The table for Unicode upcase conversion requires an order-5 allocation, which may fail on a highly-
> fragmented system:
>
> pool-udisksd: page allocation failure: order:5, mode:0x40dc0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO),
> nodemask=(null),cpuset=/,mems_allowed=0
> CPU: 4 PID: 3756880 Comm: pool-udisksd Tainted: G U 5.8.10-200.fc32.x86_64 #1
> Hardware name: Dell Inc. XPS 13 9360/0PVG6D, BIOS 2.13.0 11/14/2019 Call Trace:
> dump_stack+0x6b/0x88
> warn_alloc.cold+0x75/0xd9
> ? _cond_resched+0x16/0x40
> ? __alloc_pages_direct_compact+0x144/0x150
> __alloc_pages_slowpath.constprop.0+0xcfa/0xd30
> ? __schedule+0x28a/0x840
> ? __wait_on_bit_lock+0x92/0xa0
> __alloc_pages_nodemask+0x2df/0x320
> kmalloc_order+0x1b/0x80
> kmalloc_order_trace+0x1d/0xa0
> exfat_create_upcase_table+0x115/0x390 [exfat]
> exfat_fill_super+0x3ef/0x7f0 [exfat]
> ? sget_fc+0x1d0/0x240
> ? exfat_init_fs_context+0x120/0x120 [exfat]
> get_tree_bdev+0x15c/0x250
> vfs_get_tree+0x25/0xb0
> do_mount+0x7c3/0xaf0
> ? copy_mount_options+0xab/0x180
> __x64_sys_mount+0x8e/0xd0
> do_syscall_64+0x4d/0x90
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Make the driver use vzalloc() to eliminate the issue.
>
> Cc: stable@vger.kernel.org # v5.7+
> Signed-off-by: Artem Labazov <123321artyom@gmail.com>
> ---
> v2: replace vmalloc with vzalloc to avoid uninitialized memory access
Applied.
Thanks for your work!
prev parent reply other threads:[~2020-12-07 4:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201124194858epcas1p49cacda6a9b4877ff125f25f4dc5fcadf@epcas1p4.samsung.com>
2020-11-24 19:47 ` [PATCH] exfat: Avoid allocating upcase table using kcalloc() Artem Labazov
2020-11-24 22:17 ` David Laight
2020-12-02 4:58 ` Sungjong Seo
2020-12-04 12:57 ` Artem Labazov
2020-12-07 6:23 ` Sungjong Seo
2020-12-07 9:34 ` [PATCH v3] " Artem Labazov
2020-12-08 2:22 ` Sungjong Seo
2020-12-04 13:33 ` [PATCH v2] " Artem Labazov
2020-12-07 4:32 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301d6cc51$fc2b6d10$f4824730$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=123321artyom@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.