From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, "'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Simon Horman'" <horms@kernel.org>,
"'Russell King \(Oracle\)'" <rmk+kernel@armlinux.org.uk>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next 2/3] net: txgbe: optimize the flow to setup PHY for AML devices
Date: Fri, 10 Oct 2025 15:48:57 +0800 [thread overview]
Message-ID: <000301dc39ba$55739250$005ab6f0$@trustnetic.com> (raw)
In-Reply-To: <20250929183946.0426153d@kernel.org>
On Tue, Sep 30, 2025 9:40 AM, Jakub Kicinski wrote:
> On Sun, 28 Sep 2025 17:39:22 +0800 Jiawen Wu wrote:
> > To adapt to new firmware for AML devices, the driver should send the
> > "SET_LINK_CMD" to the firmware only once when switching PHY interface
> > mode. And the unknown link speed is permitted in the mailbox buffer. The
> > firmware will configure the PHY completely when the conditions are met.
>
> Could you mention what the TXGBE_GPIOBIT_3 does, since you're removing
> it all over the place?
Okay. It is used for RX signal, which indicate that PHY should be re-configured.
Now we remove it from the driver, let the firmware to configure PHY completely.
next prev parent reply other threads:[~2025-10-10 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 9:39 [PATCH net-next 0/3] TXGBE feat new AML firmware Jiawen Wu
2025-09-28 9:39 ` [PATCH net-next 1/3] net: txgbe: expend SW-FW mailbox buffer size to identify QSFP module Jiawen Wu
2025-09-29 13:52 ` Simon Horman
2025-10-10 7:42 ` Jiawen Wu
2025-10-10 13:52 ` Andrew Lunn
2025-10-11 1:57 ` Jiawen Wu
2025-10-11 14:20 ` Andrew Lunn
2025-09-28 9:39 ` [PATCH net-next 2/3] net: txgbe: optimize the flow to setup PHY for AML devices Jiawen Wu
2025-09-30 1:39 ` Jakub Kicinski
2025-10-10 7:48 ` Jiawen Wu [this message]
2025-10-10 13:51 ` Andrew Lunn
2025-10-11 1:53 ` Jiawen Wu
2025-09-28 9:39 ` [PATCH net-next 3/3] net: txgbe: rename txgbe_get_phy_link() Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301dc39ba$55739250$005ab6f0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.