From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rjw@rjwysocki.net>
Cc: "'Peter Zijlstra'" <peterz@infradead.org>,
"'Daniel Lezcano'" <daniel.lezcano@linaro.org>,
"'Linux PM'" <linux-pm@vger.kernel.org>
Subject: RE: [RFC][PATCH] cpuidle: Use nanoseconds as the unit of time
Date: Fri, 20 Sep 2019 09:14:57 -0700 [thread overview]
Message-ID: <000401d56fce$8bcb4bc0$a361e340$@net> (raw)
In-Reply-To: <4106941.QTENAb3AiO@kreacher>
Hi Rafael,
To be able to try this patch (and the idle disable consolidation one),
I simply waited until it would apply properly in the main git tree, which it now does.
However it does not compile:
On 2019.09.05 09:35 Rafael J. Wysocki wrote:
...
> In addition to that, change
> cpuidle_governor_latency_req() to return the idle state exit
> latency constraint in nanoseconds.
...
> Index: linux-pm/drivers/cpuidle/governors/menu.c
...
> @@ -388,13 +390,13 @@ static int menu_select(struct cpuidle_dr
> * closest timer event, select this one to avoid getting
> * stuck in the shallow one for too long.
> */
> - if (drv->states[idx].target_residency < TICK_USEC &&
> - s->target_residency <= ktime_to_us(delta_next))
> + if (drv->states[idx].target_residency_ns < TICK_NSEC &&
> + s->target_residency_ns <= delta_next)
> idx = i;
>
> return idx;
> }
> - if (s->exit_latency > latency_req)
> + if (s->exit_latency_ns > latency_req_ns)
^^^^^^^^^^^^^^^
Should be (I think):
+ if (s->exit_latency_ns > latency_req)
prev parent reply other threads:[~2019-09-20 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:34 [RFC][PATCH] cpuidle: Use nanoseconds as the unit of time Rafael J. Wysocki
2019-09-05 18:07 ` Peter Zijlstra
2019-09-20 16:14 ` Doug Smythies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401d56fce$8bcb4bc0$a361e340$@net' \
--to=dsmythies@telus.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.