diff for duplicates of <000601cbd71d$080cc870$18265950$@com> diff --git a/a/1.txt b/N1/1.txt index fe3f50e..9dff506 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,41 +8,41 @@ S.B. Kim 2011/2/26 Linus Walleij <linux.walleij@linaro.org> wrote: > -----Original Message----- -> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc- -> owner@vger.kernel.org] On Behalf Of Linus Walleij +> From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc- +> owner at vger.kernel.org] On Behalf Of Linus Walleij > Sent: Saturday, February 26, 2011 6:34 PM > To: Sangbeom Kim -> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- -> soc@vger.kernel.org; kgene.kim@samsung.com; ben-linux@fluff.org +> Cc: linux-arm-kernel at lists.infradead.org; linux-samsung- +> soc at vger.kernel.org; kgene.kim at samsung.com; ben-linux at fluff.org > Subject: Re: [PATCH 1/3] ARM: S5P: Add s5p_timer support for HRT > > 2011/2/26 Sangbeom Kim <sbkim73@samsung.com>: > > (...) > > +static void s5p_clockevent_init(void) > > +{ -> > + unsigned long pclk; -> > + unsigned long clock_rate; -> > + unsigned int irq_number; -> > + struct clk *tscaler; +> > + ? ? ? unsigned long pclk; +> > + ? ? ? unsigned long clock_rate; +> > + ? ? ? unsigned int irq_number; +> > + ? ? ? struct clk *tscaler; > > + -> > + pclk = clk_get_rate(timerclk); +> > + ? ? ? pclk = clk_get_rate(timerclk); > > + -> > + tscaler = clk_get_parent(tdiv_event); +> > + ? ? ? tscaler = clk_get_parent(tdiv_event); > > + -> > + clk_set_rate(tscaler, pclk / 2); -> > + clk_set_rate(tdiv_event, pclk / 2); -> > + clk_set_parent(tin_event, tdiv_event); +> > + ? ? ? clk_set_rate(tscaler, pclk / 2); +> > + ? ? ? clk_set_rate(tdiv_event, pclk / 2); +> > + ? ? ? clk_set_parent(tin_event, tdiv_event); > > + -> > + clock_rate = clk_get_rate(tin_event); -> > + clock_count_per_tick = clock_rate / HZ; +> > + ? ? ? clock_rate = clk_get_rate(tin_event); +> > + ? ? ? clock_count_per_tick = clock_rate / HZ; > > + -> > + time_event_device.mult = -> > + div_sc(clock_rate, NSEC_PER_SEC, +> > + ? ? ? time_event_device.mult = +> > + ? ? ? ? ? ? ? div_sc(clock_rate, NSEC_PER_SEC, time_event_device.shift); -> > + time_event_device.max_delta_ns = -> > + clockevent_delta2ns(-1, &time_event_device); -> > + time_event_device.min_delta_ns = -> > + clockevent_delta2ns(1, &time_event_device); +> > + ? ? ? time_event_device.max_delta_ns = +> > + ? ? ? ? ? ? ? clockevent_delta2ns(-1, &time_event_device); +> > + ? ? ? time_event_device.min_delta_ns = +> > + ? ? ? ? ? ? ? clockevent_delta2ns(1, &time_event_device); > > This is a very complicated and inprecise way of doing this nowadays. > Skip hardcoding the shift value and calculating mult like that and use @@ -56,21 +56,21 @@ time_event_device.shift); > > (...) > > +static void s5p_clocksource_init(void) > > +{ -> > + unsigned long pclk; -> > + unsigned long clock_rate; +> > + ? ? ? unsigned long pclk; +> > + ? ? ? unsigned long clock_rate; > > + -> > + pclk = clk_get_rate(timerclk); +> > + ? ? ? pclk = clk_get_rate(timerclk); > > + -> > + clk_set_rate(tdiv_source, pclk / 2); -> > + clk_set_parent(tin_source, tdiv_source); +> > + ? ? ? clk_set_rate(tdiv_source, pclk / 2); +> > + ? ? ? clk_set_parent(tin_source, tdiv_source); > > + -> > + clock_rate = clk_get_rate(tin_source); +> > + ? ? ? clock_rate = clk_get_rate(tin_source); > > + -> > + s5p_time_setup(timer_source.source_id, TCNT_MAX); -> > + s5p_time_start(timer_source.source_id, PERIODIC); +> > + ? ? ? s5p_time_setup(timer_source.source_id, TCNT_MAX); +> > + ? ? ? s5p_time_start(timer_source.source_id, PERIODIC); > > + -> > + if (clocksource_register_hz(&time_clocksource, clock_rate)) -> > + panic("%s: can't register clocksource\n", +> > + ? ? ? if (clocksource_register_hz(&time_clocksource, clock_rate)) +> > + ? ? ? ? ? ? ? panic("%s: can't register clocksource\n", > time_clocksource.name); > > +} > @@ -90,5 +90,5 @@ time_event_device.shift); > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung- > soc" in -> the body of a message to majordomo@vger.kernel.org +> the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f800d26..0ef897e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,10 @@ "ref\01298688357-20775-1-git-send-email-sbkim73@samsung.com\0" "ref\01298688357-20775-2-git-send-email-sbkim73@samsung.com\0" "ref\0AANLkTinCyXm_z8tcjRHCYEvi79ifj+joKK7E8Kzboi2G@mail.gmail.com\0" - "From\0Sangbeom Kim <sbkim73@samsung.com>\0" - "Subject\0RE: [PATCH 1/3] ARM: S5P: Add s5p_timer support for HRT\0" + "From\0sbkim73@samsung.com (Sangbeom Kim)\0" + "Subject\0[PATCH 1/3] ARM: S5P: Add s5p_timer support for HRT\0" "Date\0Mon, 28 Feb 2011 16:56:35 +0900\0" - "To\0'Linus Walleij' <linus.walleij@linaro.org>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - linux-samsung-soc@vger.kernel.org - kgene.kim@samsung.com - " ben-linux@fluff.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Dear Walleij,\n" @@ -21,41 +17,41 @@ "\n" "2011/2/26 Linus Walleij <linux.walleij@linaro.org> wrote:\n" "> -----Original Message-----\n" - "> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-\n" - "> owner@vger.kernel.org] On Behalf Of Linus Walleij\n" + "> From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc-\n" + "> owner at vger.kernel.org] On Behalf Of Linus Walleij\n" "> Sent: Saturday, February 26, 2011 6:34 PM\n" "> To: Sangbeom Kim\n" - "> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-\n" - "> soc@vger.kernel.org; kgene.kim@samsung.com; ben-linux@fluff.org\n" + "> Cc: linux-arm-kernel at lists.infradead.org; linux-samsung-\n" + "> soc at vger.kernel.org; kgene.kim at samsung.com; ben-linux at fluff.org\n" "> Subject: Re: [PATCH 1/3] ARM: S5P: Add s5p_timer support for HRT\n" "> \n" "> 2011/2/26 Sangbeom Kim <sbkim73@samsung.com>:\n" "> > (...)\n" "> > +static void s5p_clockevent_init(void)\n" "> > +{\n" - "> > + \302\240 \302\240 \302\240 unsigned long pclk;\n" - "> > + \302\240 \302\240 \302\240 unsigned long clock_rate;\n" - "> > + \302\240 \302\240 \302\240 unsigned int irq_number;\n" - "> > + \302\240 \302\240 \302\240 struct clk *tscaler;\n" + "> > + ? ? ? unsigned long pclk;\n" + "> > + ? ? ? unsigned long clock_rate;\n" + "> > + ? ? ? unsigned int irq_number;\n" + "> > + ? ? ? struct clk *tscaler;\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 pclk = clk_get_rate(timerclk);\n" + "> > + ? ? ? pclk = clk_get_rate(timerclk);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 tscaler = clk_get_parent(tdiv_event);\n" + "> > + ? ? ? tscaler = clk_get_parent(tdiv_event);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 clk_set_rate(tscaler, pclk / 2);\n" - "> > + \302\240 \302\240 \302\240 clk_set_rate(tdiv_event, pclk / 2);\n" - "> > + \302\240 \302\240 \302\240 clk_set_parent(tin_event, tdiv_event);\n" + "> > + ? ? ? clk_set_rate(tscaler, pclk / 2);\n" + "> > + ? ? ? clk_set_rate(tdiv_event, pclk / 2);\n" + "> > + ? ? ? clk_set_parent(tin_event, tdiv_event);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 clock_rate = clk_get_rate(tin_event);\n" - "> > + \302\240 \302\240 \302\240 clock_count_per_tick = clock_rate / HZ;\n" + "> > + ? ? ? clock_rate = clk_get_rate(tin_event);\n" + "> > + ? ? ? clock_count_per_tick = clock_rate / HZ;\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 time_event_device.mult =\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 div_sc(clock_rate, NSEC_PER_SEC,\n" + "> > + ? ? ? time_event_device.mult =\n" + "> > + ? ? ? ? ? ? ? div_sc(clock_rate, NSEC_PER_SEC,\n" "time_event_device.shift);\n" - "> > + \302\240 \302\240 \302\240 time_event_device.max_delta_ns =\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 clockevent_delta2ns(-1, &time_event_device);\n" - "> > + \302\240 \302\240 \302\240 time_event_device.min_delta_ns =\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 clockevent_delta2ns(1, &time_event_device);\n" + "> > + ? ? ? time_event_device.max_delta_ns =\n" + "> > + ? ? ? ? ? ? ? clockevent_delta2ns(-1, &time_event_device);\n" + "> > + ? ? ? time_event_device.min_delta_ns =\n" + "> > + ? ? ? ? ? ? ? clockevent_delta2ns(1, &time_event_device);\n" "> \n" "> This is a very complicated and inprecise way of doing this nowadays.\n" "> Skip hardcoding the shift value and calculating mult like that and use\n" @@ -69,21 +65,21 @@ "> > (...)\n" "> > +static void s5p_clocksource_init(void)\n" "> > +{\n" - "> > + \302\240 \302\240 \302\240 unsigned long pclk;\n" - "> > + \302\240 \302\240 \302\240 unsigned long clock_rate;\n" + "> > + ? ? ? unsigned long pclk;\n" + "> > + ? ? ? unsigned long clock_rate;\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 pclk = clk_get_rate(timerclk);\n" + "> > + ? ? ? pclk = clk_get_rate(timerclk);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 clk_set_rate(tdiv_source, pclk / 2);\n" - "> > + \302\240 \302\240 \302\240 clk_set_parent(tin_source, tdiv_source);\n" + "> > + ? ? ? clk_set_rate(tdiv_source, pclk / 2);\n" + "> > + ? ? ? clk_set_parent(tin_source, tdiv_source);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 clock_rate = clk_get_rate(tin_source);\n" + "> > + ? ? ? clock_rate = clk_get_rate(tin_source);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 s5p_time_setup(timer_source.source_id, TCNT_MAX);\n" - "> > + \302\240 \302\240 \302\240 s5p_time_start(timer_source.source_id, PERIODIC);\n" + "> > + ? ? ? s5p_time_setup(timer_source.source_id, TCNT_MAX);\n" + "> > + ? ? ? s5p_time_start(timer_source.source_id, PERIODIC);\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 if (clocksource_register_hz(&time_clocksource, clock_rate))\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 panic(\"%s: can't register clocksource\\n\",\n" + "> > + ? ? ? if (clocksource_register_hz(&time_clocksource, clock_rate))\n" + "> > + ? ? ? ? ? ? ? panic(\"%s: can't register clocksource\\n\",\n" "> time_clocksource.name);\n" "> > +}\n" "> \n" @@ -103,7 +99,7 @@ "> --\n" "> To unsubscribe from this list: send the line \"unsubscribe linux-samsung-\n" "> soc\" in\n" - "> the body of a message to majordomo@vger.kernel.org\n" + "> the body of a message to majordomo at vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -349c73e5c88104abbcac370500856e5d2054efe8c71af24941fac1ed66aae674 +3b295c40343e108e930cda8f965b7390460ff7dc6d835c1472f0bf4f0d508f5d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.