From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: "'Alex Bennée'" <alex.bennee@linaro.org>
Cc: pbonzini@redhat.com, boost.lists@gmail.com,
pavel.dovgaluk@ispras.ru, cota@braap.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes
Date: Thu, 11 May 2017 14:23:17 +0300 [thread overview]
Message-ID: <000601d2ca48$fd051330$f70f3990$@ru> (raw)
In-Reply-To: <87efvw91m0.fsf@linaro.org>
> From: Alex Bennée [mailto:alex.bennee@linaro.org]
> Pavel Dovgalyuk <dovgaluk@ispras.ru> writes:
>
> > Guest Windows XP doesn't boot with these patches.
>
> I'm guessing there is hardware attached to that machine?
Only mouse, keyboard and hdd.
> Did the asserts catch double locking?
No, they didn't.
The emulation also became much slower.
Maybe Windows boots, but with huge slowdown?
> As I said there are still changes to be made to
> the hardware emulation that saves async events with the device data.
What devices do you mean?
> But the real question is do you think that re-purposing replay_lock to
> give the sequential guarantees that the BQL used to is the right
> approach?
This approach seems to be ok - you raised the lock and io/cpu threads are now synchronized.
This is how BQL worked before.
Pavel Dovgalyuk
next prev parent reply other threads:[~2017-05-11 11:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 10:38 [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes Alex Bennée
2017-05-05 10:38 ` [RFC PATCH v1 1/9] target/arm/arm-powertctl: drop BQL assertions Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] " Alex Bennée
2017-05-05 10:38 ` [RFC PATCH v1 2/9] cpus: push BQL lock to qemu_*_wait_io_event Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] " Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 3/9] cpus: only take BQL for sleeping threads Alex Bennée
2017-05-05 15:15 ` Paolo Bonzini
2017-05-05 15:28 ` Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 4/9] replay/replay-internal.c: track holding of replay_lock Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 5/9] replay: make locking visible outside replay code Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 6/9] replay: push replay_mutex_lock up the call tree Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 7/9] scripts/qemu-gdb: add simple tcg lock status helper Alex Bennée
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events Alex Bennée
2017-05-05 15:17 ` Paolo Bonzini
2017-05-05 15:59 ` Alex Bennée
2017-05-06 8:19 ` Paolo Bonzini
2017-05-08 17:52 ` Stefan Hajnoczi
2017-05-09 13:50 ` Alex Bennée
2017-05-09 13:55 ` Paolo Bonzini
2017-05-05 10:38 ` [Qemu-devel] [RFC PATCH v1 9/9] scripts/analyse-locks-simpletrace.py: script to analyse lock times Alex Bennée
2017-05-05 15:38 ` [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes no-reply
2017-05-10 13:51 ` Pavel Dovgalyuk
2017-05-10 15:24 ` Alex Bennée
2017-05-11 11:23 ` Pavel Dovgalyuk [this message]
2017-06-05 10:52 ` Pavel Dovgalyuk
2017-06-06 9:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601d2ca48$fd051330$f70f3990$@ru' \
--to=dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=boost.lists@gmail.com \
--cc=cota@braap.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.