From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=yong.b.li@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43LV9P3vddzDqtR for ; Fri, 21 Dec 2018 11:38:29 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 16:38:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,379,1539673200"; d="scan'208,217";a="109006963" Received: from yongli3-mobl.ccr.corp.intel.com (HELO yongli3MOBL) ([10.239.196.10]) by fmsmga007.fm.intel.com with ESMTP; 20 Dec 2018 16:38:25 -0800 From: "Yong Li" To: , Cc: "Li, Yong B" Subject: journal log messages are missing with latest version Date: Fri, 21 Dec 2018 08:38:24 +0800 Message-ID: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0007_01D49908.8A70E6B0" X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdSYxXmiiblQVz+yQrqj86VrunkBvg== Content-Language: en-us x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjA1Y2M5ODctZTViMC00YjM2LWJiYzMtNGQ0MzBjNDczYTAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidEVsZFgyWkdjZDl3OXk4a3Bvd05vSjVCWUFmWUpkVzlQK0RHY2lGYmhaQjJTNW1LYkR0eFFrcWR3Z1pVZ3lvMyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 00:38:34 -0000 This is a multipart message in MIME format. ------=_NextPart_000_0007_01D49908.8A70E6B0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Patrick, I encountered a problem after upgrade to the latest opnebmc version: These log messages in ipmid are missing with the "journalctl -f". My tests shows that the blow change is related, after I revert it, I can get these log messages. Did you meet such issue, or any suggestions/comments to narrow down this issue? https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6f3711c 88d6a3b9a5c4d49 add sdjournal interface to inject tests Thanks, Yong ------=_NextPart_000_0007_01D49908.8A70E6B0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi = Patrick,

I encountered a problem after upgrade to the latest = opnebmc version:

These log = messages in ipmid are missing with the “journalctl = -f”.

My tests shows that the blow change is related, after = I revert it, I can get these log messages.

Did you meet = such issue, or any suggestions/comments to narrow down this = issue?

https://github.com/openbmc/phosphor-logging/c= ommit/59a6b1f27e83066baa6f3711c88d6a3b9a5c4d49

add sdjournal interface = to inject tests

Thanks,

Yong

------=_NextPart_000_0007_01D49908.8A70E6B0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::52f; helo=mail-pg1-x52f.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="pBa+ZdWQ"; dkim-atps=neutral Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43VLFv1ssHzDqCR for ; Thu, 3 Jan 2019 06:09:38 +1100 (AEDT) Received: by mail-pg1-x52f.google.com with SMTP id c25so14957872pgb.4 for ; Wed, 02 Jan 2019 11:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=13f0fijVTooVPnevDiVGjWmfNWCLjL+vqflID10cg/Y=; b=pBa+ZdWQPekmf5+J1Q4gSmJPr1kye6l+7y7NeCA8cRnHnQn9POnBR85kJEvUow/FMP 9JiIToNzAmYZra5H+C9/igtoRxJBaUfPU9GdzeQbtbkyaiU6EF8OKEiMjd++HkKf7wm2 FYpqv596dCETW0AWgn8BFbinZXYfZ6qiFF02m0+EXkxKiCo0APBbAMc60g2+KrXMP/vx QlyBZkisRX/Cp+J1miaSFZjKi/JBfxzaAcPktaX48zPt0Tv4GNforvQ+8UFVPpeH5fxO VC+0G+WSN2NAvCnerBXKuPOxcC2HcckleVDsAebwQO/ngbl+EXD9RGrkKB9PAQGZnMjg /g/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=13f0fijVTooVPnevDiVGjWmfNWCLjL+vqflID10cg/Y=; b=jMr9rwuDAZyjGkZWXfF3nDRD5qMk2NJk1k2W7CD+OVZSCn88rrmQ3F674Ias8PujgD w2bX4LITq7gjJTQJLxJMUEXAULkglRmd5e/KgFvprV+FXjknKk29G0PU6Hsqb5QCfgNY r6Mg5/uGIt3tXj4pkoc7zp5Uw7RnaMM0dTV57R8cRPcUkW8KvFv08DXGQb6/IQTkpldS UmnFZd8oPJOCjSEwOYN9uUQaWKFmQMPYeqQtcU/Fv+kafpQtH+hYP2LSiCjrBz9zZpHf 8rWlJCq4XzrzAgViTvSZ8relFA/017N1W8cifenyWH+8XKDGSeEWikurL5lfXwTCmywZ sQEw== X-Gm-Message-State: AJcUukcH9nbcZHQ/GNIjG690aUyQsPU/t75a127pUPxS/7sHTqj0BF+l fHxf8rPip5V7aRO0rfg8IKVv75fCbVGDm/fslkYzWg== X-Google-Smtp-Source: ALg8bN6Lue21e+meP00I10piYBGt+5thOSklcQTrAEmgpR9WG756sbrRRe+cRyP0OXn+Pzj0hp+pViJELeX5LQJolE0= X-Received: by 2002:a63:4d:: with SMTP id 74mr14787459pga.248.1546456176258; Wed, 02 Jan 2019 11:09:36 -0800 (PST) MIME-Version: 1.0 References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> In-Reply-To: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> From: Patrick Venture Date: Wed, 2 Jan 2019 11:09:24 -0800 Message-ID: Subject: Re: journal log messages are missing with latest version To: Yong Li Cc: OpenBMC Maillist , "Li, Yong B" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 19:09:40 -0000 On Thu, Dec 20, 2018 at 4:38 PM Yong Li wrote: > > > > Hi Patrick, > > > > I encountered a problem after upgrade to the latest opnebmc version: > > > > These log messages in ipmid are missing with the =E2=80=9Cjournalctl -f= =E2=80=9D. Which log messages? > > > > My tests shows that the blow change is related, after I revert it, I can = get these log messages. > > > > Did you meet such issue, or any suggestions/comments to narrow down this = issue? > > https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6f37= 11c88d6a3b9a5c4d49 > > add sdjournal interface to inject tests There were some follow-on patches for phosphor-logging that you shouldn't need -- it's What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? (so I know what version of that is in use by you). Checking the HEAD version of https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.am, I see it's including the proper libs to get the full phosphor-logging objects. > > > > Thanks, > > Yong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=mspinler@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43Vwr12p9GzDqDf for ; Fri, 4 Jan 2019 05:07:41 +1100 (AEDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x03I4XPu011138 for ; Thu, 3 Jan 2019 13:07:39 -0500 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0a-001b2d01.pphosted.com with ESMTP id 2psq1srxaf-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 03 Jan 2019 13:07:39 -0500 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Jan 2019 18:07:38 -0000 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 3 Jan 2019 18:07:35 -0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x03I7YVA18219070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 18:07:34 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AE91178069; Thu, 3 Jan 2019 18:07:34 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F7CE7805E; Thu, 3 Jan 2019 18:07:34 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.16.170.189]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 3 Jan 2019 18:07:34 +0000 (GMT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 03 Jan 2019 12:12:38 -0600 From: Matt Spinler To: Patrick Venture Cc: Yong Li , OpenBMC Maillist Subject: Re: journal log messages are missing with latest version In-Reply-To: References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> X-Sender: mspinler@linux.vnet.ibm.com User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 19010318-0012-0000-0000-000016F350FB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010338; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000272; SDB=6.01141235; UDB=6.00593942; IPR=6.00921460; MB=3.00024956; MTD=3.00000008; XFM=3.00000015; UTC=2019-01-03 18:07:37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19010318-0013-0000-0000-000055ACFEFB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-03_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901030159 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 18:07:45 -0000 On 2019-01-02 13:09, Patrick Venture wrote: > On Thu, Dec 20, 2018 at 4:38 PM Yong Li > wrote: >> >> >> >> Hi Patrick, >> >> >> >> I encountered a problem after upgrade to the latest opnebmc version: >> >> >> >> These log messages in ipmid are missing with the “journalctl -f”. > > Which log messages? This showed up on all of our systems too, anything logged using phosphor-logging is missing from the journal. I even ended up using a git bisect to also narrow it down to: phosphor-logging: srcrev bump 30047bf964..31552c05e2 Patrick Venture (5): add sdjournal interface to inject tests test: use only one main library bugfix: add fixes to mock class bugfix: rename method to match implementation test: add test to force building of sdjournal mock > >> >> >> >> My tests shows that the blow change is related, after I revert it, I >> can get these log messages. >> >> >> >> Did you meet such issue, or any suggestions/comments to narrow down >> this issue? >> >> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6f3711c88d6a3b9a5c4d49 >> >> add sdjournal interface to inject tests > > There were some follow-on patches for phosphor-logging that you > shouldn't need -- it's > > What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? > (so I know what version of that is in use by you). > > Checking the HEAD version of > https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.am, > I see it's including the proper libs to get the full phosphor-logging > objects. > >> >> >> >> Thanks, >> >> Yong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::535; helo=mail-pg1-x535.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="gEowZLC6"; dkim-atps=neutral Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43VyQr6NYNzDqGB for ; Fri, 4 Jan 2019 06:19:32 +1100 (AEDT) Received: by mail-pg1-x535.google.com with SMTP id w7so16374428pgp.13 for ; Thu, 03 Jan 2019 11:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=O2sXdAhcdM4HGbxC3rSU/+QlJQB4sezqHIjBYnUfmwc=; b=gEowZLC6PGjl+4yKMHW+Os5Ze456C4dTBg4ifAiObv/f/jz1gKS1mRYo03lRIS1bKm uQqOu8uRIR0V3qEobODU/y1CnTGgnvqutETxuouTJcEjRpwc0mJv/QdXdAnIlPJ9mq87 +ixZ0p492ZTNOC8c9SxbyPPUM3PmAF13qM3BI8mG1ONZpGpnzRRTAYJsZv/AEIseJDjC DutDMUWfNYTjSJ5Qi2f0/hxtR0hynz6xQr1edljDukpM1rzdJRh/6NRdVxlvf8MG+dGO 8a9vJ+SlsysdSjX1ugzme/XKoq+647Ajl3mcugszG38XGt++kL2DQf3VEhPkcBFHcZ0J 5RfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O2sXdAhcdM4HGbxC3rSU/+QlJQB4sezqHIjBYnUfmwc=; b=gr4KwEZZXnsyW2fDhgq1IgXCDZSGj240AvVlMtNvvYitbbzqSAOMtO7CqsI8xU3qBe qwaTOPqqPtLyVMdzKgMkK+ofvXxsncVFldr3Np081EcES15dTFHB5KRqK95ZTPFkA8Tj eviFkheMMNEMXkL6nILUNaNiKnWvWpIZ98kTMTECfUoCvhAZ6p22LMGgnoyBJrM4zYVK LpvvM66vU8NJtpxM0/DQECOKgRCpwOr7V1UFIZ49gRp/UP+sAyE2hoxwV07YDdRdVXaZ lQ0PqiPqLIUVf7hguXn3GmEab2RxzlZOJ1Xoi2ZAGVduLz5SvooBcrUAl9YNJN5pfJJC Ln5Q== X-Gm-Message-State: AJcUukcRirHG9zbs07inEBymmnANIYAxK3cmTCv22Y0XKaDCFb/B4OrZ AysSUExSax0XTptwAlrubWXmUdzISFTuliI9W2y53Q== X-Google-Smtp-Source: ALg8bN4KQO3wOMey/t/1F10qGU0rBx0lFKFSbmE9GfmYVJA0t3rTqf/Z4cxqx9GnSjZ2AFsBf+uYh1EdBI9EYRbuVs8= X-Received: by 2002:a63:955a:: with SMTP id t26mr18237587pgn.449.1546543170306; Thu, 03 Jan 2019 11:19:30 -0800 (PST) MIME-Version: 1.0 References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> In-Reply-To: From: Patrick Venture Date: Thu, 3 Jan 2019 11:19:19 -0800 Message-ID: Subject: Re: journal log messages are missing with latest version To: Matt Spinler , William Kennington Cc: Yong Li , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 19:19:34 -0000 On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler wrote: > > On 2019-01-02 13:09, Patrick Venture wrote: > > On Thu, Dec 20, 2018 at 4:38 PM Yong Li > > wrote: > >> > >> > >> > >> Hi Patrick, > >> > >> > >> > >> I encountered a problem after upgrade to the latest opnebmc version: > >> > >> > >> > >> These log messages in ipmid are missing with the =E2=80=9Cjournalctl -= f=E2=80=9D. > > > > Which log messages? > > > This showed up on all of our systems too, anything logged using > phosphor-logging > is missing from the journal. I even ended up using a git bisect to also > narrow > it down to: > > phosphor-logging: srcrev bump 30047bf964..31552c05e2 > > Patrick Venture (5): > add sdjournal interface to inject tests > test: use only one main library > bugfix: add fixes to mock class > bugfix: rename method to match implementation > test: add test to force building of sdjournal mock > William, you've been digging into sdbus a lot recently, can you take a deep look at the patchset above and see what I may have messed up? The phosphor-logging unit-tests were broken until I got it "working." Which lead me to believe that it's not correct -- and the daemons that have unit-tests that hit the log message are seeing the calls. > > > > >> > >> > >> > >> My tests shows that the blow change is related, after I revert it, I > >> can get these log messages. > >> > >> > >> > >> Did you meet such issue, or any suggestions/comments to narrow down > >> this issue? > >> > >> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6= f3711c88d6a3b9a5c4d49 > >> > >> add sdjournal interface to inject tests > > > > There were some follow-on patches for phosphor-logging that you > > shouldn't need -- it's > > > > What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? > > (so I know what version of that is in use by you). > > > > Checking the HEAD version of > > https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.am, > > I see it's including the proper libs to get the full phosphor-logging > > objects. > > > >> > >> > >> > >> Thanks, > >> > >> Yong > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::432; helo=mail-pf1-x432.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="AXooALt9"; dkim-atps=neutral Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43W2dK6FkLzDqHn for ; Fri, 4 Jan 2019 09:28:53 +1100 (AEDT) Received: by mail-pf1-x432.google.com with SMTP id y126so17308935pfb.4 for ; Thu, 03 Jan 2019 14:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XSmWh953+CLMa9Vnze4e75uJsqrW59O8Q2ygzw9xSaI=; b=AXooALt9yNuHTJ719I6d/RVRL2wsaBix1+o2YSrWTvjCND0CtM6zB/MHvLyQfFkhod byXIQZpO/EGCETqcsGOVzCy892YtjKAOwWVKDVQQAFHfVSXjr3TvpOKauesoxJIRNFsG Siq0nkpImw+wMgXdtZmvYHto0SHn6130A96K8nyEHQKYm4TdmhCIRV2hFakRTF4aSabM o7dSu9NKVwsElTRGww3gHhav35cjfk8NJ8+AxUUi1Ck44Sm9JsAjTg48ebtMJMRFHADW ZfaIZMK9pg8iXTb/FH+Jq2bqN+Jum11kzg2wOTLcw1k4rkFy8dSBk8V1h6t591ejaKjN sJSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XSmWh953+CLMa9Vnze4e75uJsqrW59O8Q2ygzw9xSaI=; b=Vb4e1TknWzXBAgc5eM+6wOPFK6SikfM6eIl7Sh0Trf91RJAhfv6kISTYGOzfiMEazs vYENxv2UjepthFCV47HtIFGSwlOcwUJ0xZNrqkW3L3jv/+p3B4PVppbKU5AlTtiCh+fX YBQypwNHSSEqcUfxJOIwQMPHgWLm9EFaIOtS7P8F2kvtqxm48iwx8/YL3yskw33IUcMX VuGiMU/q9xTl6cvtYTWmIjjVUVRHcaVavm4W5wx0dhjNV7ZGgmpIWMyjLO301ZJoLYPR fxV8KVhX+65+c45HXlxH+oqjXJgqz1uLl5puKW74b83gUOfFwgJcky0gVRam3T9htkOP sTbA== X-Gm-Message-State: AJcUukcqMFPLBvtC7kLdAMhuj/b1h0twCbrNOJORFoX4/298+femVXcx yalC3UwBD5o+C8YyRXp43mXf/cItYLR2hJj8wTrRbw== X-Google-Smtp-Source: ALg8bN5nWpepTU2M6SRlFchHWl62zkhPIkiJGzvfzFrpH6wmLRGOcvjfh9qynf/l41Jq2sp5zc4A7nreXMmJNkiyNjE= X-Received: by 2002:a63:fc49:: with SMTP id r9mr18175659pgk.209.1546554530765; Thu, 03 Jan 2019 14:28:50 -0800 (PST) MIME-Version: 1.0 References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com>

In-Reply-To: From: Patrick Venture Date: Thu, 3 Jan 2019 14:28:39 -0800 Message-ID: Subject: Re: journal log messages are missing with latest version To: Matt Spinler , William Kennington Cc: Yong Li , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 22:28:54 -0000 On Thu, Jan 3, 2019 at 11:19 AM Patrick Venture wrote: > > On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler > wrote: > > > > On 2019-01-02 13:09, Patrick Venture wrote: > > > On Thu, Dec 20, 2018 at 4:38 PM Yong Li > > > wrote: > > >> > > >> > > >> > > >> Hi Patrick, > > >> > > >> > > >> > > >> I encountered a problem after upgrade to the latest opnebmc version: > > >> > > >> > > >> > > >> These log messages in ipmid are missing with the =E2=80=9Cjournalctl= -f=E2=80=9D. > > > > > > Which log messages? > > > > > > This showed up on all of our systems too, anything logged using > > phosphor-logging > > is missing from the journal. I even ended up using a git bisect to als= o > > narrow > > it down to: > > > > phosphor-logging: srcrev bump 30047bf964..31552c05e2 > > > > Patrick Venture (5): > > add sdjournal interface to inject tests > > test: use only one main library > > bugfix: add fixes to mock class > > bugfix: rename method to match implementation > > test: add test to force building of sdjournal mock > > > > William, you've been digging into sdbus a lot recently, can you take a > deep look at the patchset above and see what I may have messed up? > The phosphor-logging unit-tests were broken until I got it "working." > Which lead me to believe that it's not correct -- and the daemons that > have unit-tests that hit the log message are seeing the calls. >From reading more into the var_args pass-through, that may be the issue. One cannot pass the var args down directly like this. I propose to initially snip out this extra call and then revisit so that it'll resume working. The problem is that sd_journal_send doesn't expect a va_list argument, but rather strictly var args, which aren't the same. > > > > > > > > >> > > >> > > >> > > >> My tests shows that the blow change is related, after I revert it, I > > >> can get these log messages. > > >> > > >> > > >> > > >> Did you meet such issue, or any suggestions/comments to narrow down > > >> this issue? > > >> > > >> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066ba= a6f3711c88d6a3b9a5c4d49 > > >> > > >> add sdjournal interface to inject tests > > > > > > There were some follow-on patches for phosphor-logging that you > > > shouldn't need -- it's > > > > > > What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? > > > (so I know what version of that is in use by you). > > > > > > Checking the HEAD version of > > > https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.a= m, > > > I see it's including the proper libs to get the full phosphor-logging > > > objects. > > > > > >> > > >> > > >> > > >> Thanks, > > >> > > >> Yong > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::529; helo=mail-pg1-x529.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="mZnZ2Pem"; dkim-atps=neutral Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43W2l43HCNzDqBL for ; Fri, 4 Jan 2019 09:33:52 +1100 (AEDT) Received: by mail-pg1-x529.google.com with SMTP id d72so16572127pga.9 for ; Thu, 03 Jan 2019 14:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MAEOnpQQd8O1W9SSDU6N/gIHmNjNlo+SWgV6wUVKr28=; b=mZnZ2PemzRcFzLlH1nIMMvHK2H01+7LsiBXqqu3V6uE28jnQZ4aCiiIVwu6EQCpuBJ y9tIL/g5GFO/dOjEbFWYJelhEH8fHMOS2vJPBxFGY0jEhaVpukpouYHvurMUaAtHqJL1 0VN1Z21HEoYDVum68cXLsql1sKWbzbt2RgwmAU9No01201PRyNZiSOrpVbe7243ozdM5 LArAmkIPmWZMkW/GtDUHiHrgERJpX9c8iPgGgj1pYHXJkr3uMRy2XXJqpz1ykOKknShO wn+hFOR3pJzGEWGo6RFFzSfJNcYjllrN4I198XdF6f1fs/5d/BygZI2X68X5GbRwCbLp VzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MAEOnpQQd8O1W9SSDU6N/gIHmNjNlo+SWgV6wUVKr28=; b=RNY8buKCTjMoVf8PqRa8F8tViCBHiDWGuAFxjKYGUfzgz43qVe80xq1839/SSw8mni 8k8QdP4FSGIWFbsTpFkVdZ+8R4dkmuazpFrJZloZXvRiMFqrEPs1E3DcJMLvSZIM+VSi 3xbH4SqOFDq7hLSnlG7dAI+z5b5NXQ0DxOVjr0yMhQB9f/yaLvOLhOVu9RSaI4aCg19A GcA1fAZAHePBpN8W7g/oFXMb1AVNAWN3TI8TUVTmccS8K7P5VN5p388wzYy3Oj5O6Icz srqTAoKveywBEX2SDouJx6JmozbtvgvGtHotvA3E8H5KLRd2OkOWGOXKKDEU6eoNsdxV 7IZA== X-Gm-Message-State: AJcUukdkCb8PHD4febEbACNGKLnRrnMEmNpc8W68ymdw/2MMMFUTcA/5 xYk5dqAHem/rKsdyvN27IAYruwLifJwmpcAZY00lIg== X-Google-Smtp-Source: ALg8bN6WJHtdW77nWbY5ySEKqFTaXm8dHPdklvdbtjBmDEHhQLMt/veRFZkR+rKXs3RUZbUfUpMZ8QZ0z+YjHDlf30Y= X-Received: by 2002:a63:955a:: with SMTP id t26mr18735142pgn.449.1546554829995; Thu, 03 Jan 2019 14:33:49 -0800 (PST) MIME-Version: 1.0 References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com>

In-Reply-To: From: Patrick Venture Date: Thu, 3 Jan 2019 14:33:38 -0800 Message-ID: Subject: Re: journal log messages are missing with latest version To: Matt Spinler , William Kennington Cc: Yong Li , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 22:33:53 -0000 On Thu, Jan 3, 2019 at 2:28 PM Patrick Venture wrote: > > On Thu, Jan 3, 2019 at 11:19 AM Patrick Venture wrot= e: > > > > On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler > > wrote: > > > > > > On 2019-01-02 13:09, Patrick Venture wrote: > > > > On Thu, Dec 20, 2018 at 4:38 PM Yong Li > > > > wrote: > > > >> > > > >> > > > >> > > > >> Hi Patrick, > > > >> > > > >> > > > >> > > > >> I encountered a problem after upgrade to the latest opnebmc versio= n: > > > >> > > > >> > > > >> > > > >> These log messages in ipmid are missing with the =E2=80=9Cjournalc= tl -f=E2=80=9D. > > > > > > > > Which log messages? > > > > > > > > > This showed up on all of our systems too, anything logged using > > > phosphor-logging > > > is missing from the journal. I even ended up using a git bisect to a= lso > > > narrow > > > it down to: > > > > > > phosphor-logging: srcrev bump 30047bf964..31552c05e2 > > > > > > Patrick Venture (5): > > > add sdjournal interface to inject tests > > > test: use only one main library > > > bugfix: add fixes to mock class > > > bugfix: rename method to match implementation > > > test: add test to force building of sdjournal mock > > > > > > > William, you've been digging into sdbus a lot recently, can you take a > > deep look at the patchset above and see what I may have messed up? > > The phosphor-logging unit-tests were broken until I got it "working." > > Which lead me to believe that it's not correct -- and the daemons that > > have unit-tests that hit the log message are seeing the calls. > > From reading more into the var_args pass-through, that may be the > issue. One cannot pass the var args down directly like this. I > propose to initially snip out this extra call and then revisit so that > it'll resume working. https://gerrit.openbmc-project.xyz/17054 > > The problem is that sd_journal_send doesn't expect a va_list argument, > but rather strictly var args, which aren't the same. > > > > > > > > > > > > > >> > > > >> > > > >> > > > >> My tests shows that the blow change is related, after I revert it,= I > > > >> can get these log messages. > > > >> > > > >> > > > >> > > > >> Did you meet such issue, or any suggestions/comments to narrow dow= n > > > >> this issue? > > > >> > > > >> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066= baa6f3711c88d6a3b9a5c4d49 > > > >> > > > >> add sdjournal interface to inject tests > > > > > > > > There were some follow-on patches for phosphor-logging that you > > > > shouldn't need -- it's > > > > > > > > What SHA is for your https://github.com/openbmc/phosphor-host-ipmid= ? > > > > (so I know what version of that is in use by you). > > > > > > > > Checking the HEAD version of > > > > https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile= .am, > > > > I see it's including the proper libs to get the full phosphor-loggi= ng > > > > objects. > > > > > > > >> > > > >> > > > >> > > > >> Thanks, > > > >> > > > >> Yong > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=yong.b.li@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43W6RZ1lWtzDqGl for ; Fri, 4 Jan 2019 12:20:41 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 17:20:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,437,1539673200"; d="scan'208";a="131393207" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 03 Jan 2019 17:20:38 -0800 Received: from [10.239.197.33] (yongli3-mobl.ccr.corp.intel.com [10.239.197.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 5E7DC58028E; Thu, 3 Jan 2019 17:20:37 -0800 (PST) Subject: Re: journal log messages are missing with latest version To: Patrick Venture , Matt Spinler , William Kennington Cc: OpenBMC Maillist References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com>

From: "Li, Yong B" Message-ID: <3a1d3ae9-e067-c166-96cd-b91f984de3d5@linux.intel.com> Date: Fri, 4 Jan 2019 09:20:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 01:20:43 -0000 Thanks Patrick for your mails. Will test https://gerrit.openbmc-project.xyz/17054, and update the results. On 1/4/2019 6:33 AM, Patrick Venture wrote: > On Thu, Jan 3, 2019 at 2:28 PM Patrick Venture wrote: >> On Thu, Jan 3, 2019 at 11:19 AM Patrick Venture wrote: >>> On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler >>> wrote: >>>> On 2019-01-02 13:09, Patrick Venture wrote: >>>>> On Thu, Dec 20, 2018 at 4:38 PM Yong Li >>>>> wrote: >>>>>> >>>>>> >>>>>> Hi Patrick, >>>>>> >>>>>> >>>>>> >>>>>> I encountered a problem after upgrade to the latest opnebmc version: >>>>>> >>>>>> >>>>>> >>>>>> These log messages in ipmid are missing with the “journalctl -f”. >>>>> Which log messages? >>>> >>>> This showed up on all of our systems too, anything logged using >>>> phosphor-logging >>>> is missing from the journal. I even ended up using a git bisect to also >>>> narrow >>>> it down to: >>>> >>>> phosphor-logging: srcrev bump 30047bf964..31552c05e2 >>>> >>>> Patrick Venture (5): >>>> add sdjournal interface to inject tests >>>> test: use only one main library >>>> bugfix: add fixes to mock class >>>> bugfix: rename method to match implementation >>>> test: add test to force building of sdjournal mock >>>> >>> William, you've been digging into sdbus a lot recently, can you take a >>> deep look at the patchset above and see what I may have messed up? >>> The phosphor-logging unit-tests were broken until I got it "working." >>> Which lead me to believe that it's not correct -- and the daemons that >>> have unit-tests that hit the log message are seeing the calls. >> From reading more into the var_args pass-through, that may be the >> issue. One cannot pass the var args down directly like this. I >> propose to initially snip out this extra call and then revisit so that >> it'll resume working. > https://gerrit.openbmc-project.xyz/17054 >> The problem is that sd_journal_send doesn't expect a va_list argument, >> but rather strictly var args, which aren't the same. >> >>>>>> >>>>>> >>>>>> My tests shows that the blow change is related, after I revert it, I >>>>>> can get these log messages. >>>>>> >>>>>> >>>>>> >>>>>> Did you meet such issue, or any suggestions/comments to narrow down >>>>>> this issue? >>>>>> >>>>>> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6f3711c88d6a3b9a5c4d49 >>>>>> >>>>>> add sdjournal interface to inject tests >>>>> There were some follow-on patches for phosphor-logging that you >>>>> shouldn't need -- it's >>>>> >>>>> What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? >>>>> (so I know what version of that is in use by you). >>>>> >>>>> Checking the HEAD version of >>>>> https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.am, >>>>> I see it's including the proper libs to get the full phosphor-logging >>>>> objects. >>>>> >>>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Yong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::533; helo=mail-pg1-x533.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="FlnY9N6d"; dkim-atps=neutral Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43WSZt6jPMzDqLw for ; Sat, 5 Jan 2019 01:58:14 +1100 (AEDT) Received: by mail-pg1-x533.google.com with SMTP id v28so17602566pgk.10 for ; Fri, 04 Jan 2019 06:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vKhbnSKWENnQpHNBghJtpHZLIAsnblYy4KXVJZ4rtHY=; b=FlnY9N6dl0tHKUnsrMcY7ztMlcK/U/KNunVawvG8YAD2EVMldUNYgAUN70Vh8A37KN wIX2rt+MmGY1c4VyeuioAGYzOqJjpPEs8ox3HPL2oABfaA8RfBVasGujcTqS2zxvUIV6 M1kuGyuzAWab8LAUV+xF6D5YcRV6eQLw+nr/uq5NEe7h7CZ87qF9L3o4RYf9WbVISxWk l2R5Ix9Rl1MAUoiuOV+xRx1k57gnHqpAZae3XKGFW4SrEzJi9A1+y+MIcpJfp1RBdH0P 46SzhBLI4mkhK1azWijWIu0G8U3IKsh2VCgx1HNIvHVfgtiWOHm4C3IK5Gqy8iMU1BuU IWAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vKhbnSKWENnQpHNBghJtpHZLIAsnblYy4KXVJZ4rtHY=; b=iTxAD9ouPGY9tF957beIZCbW+GVaGWUle3lnZRGOUhZL839Lg3VLpwpRkzKD2pHEhz hHZ9Tu4OW1hdaBUj8M2Gdaxh/pu6Jh6WM6Gv9CDu1cYeZtSkO8nkVgXiyJLNp0RdXCxZ uP6kwNZniQvQNW4YoMvFT+lG3nJhOJbphc9okr1On+w1wz2RJtl4JGToE5sVPOpYzViF X5FEX41gsMi9lHmjWFMxZd0DthKIoI7SiYzBvOA6YqVjnZdi50jV13L7rJ+IBzhzusv2 0T7H/z+tND9Q89bBxSaLHHNk06v5NQPlrSjHa1lyAUIkN2UFYXW1omMsip8zytLvyLeJ L5Yw== X-Gm-Message-State: AJcUukcGuE1kX+v+20MkhKdcOLjHeA71M99V4QBhhhctf4cYGVLYm4dl i2xCvBqW1tXjDhAt+BXFAsfAfxejIuvYKsjsL500PQ== X-Google-Smtp-Source: ALg8bN4ELjHK+Z1kH5bTYcX1BE6VGs8pIHRdXUgW4r1E9dex6gd+SIlq8D6bl6Z/VZ5uLVSy85gbblYi4b5Oax47338= X-Received: by 2002:a62:178f:: with SMTP id 137mr52089109pfx.226.1546613892058; Fri, 04 Jan 2019 06:58:12 -0800 (PST) MIME-Version: 1.0 References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com>

<3a1d3ae9-e067-c166-96cd-b91f984de3d5@linux.intel.com> In-Reply-To: <3a1d3ae9-e067-c166-96cd-b91f984de3d5@linux.intel.com> From: Patrick Venture Date: Fri, 4 Jan 2019 06:58:00 -0800 Message-ID: Subject: Re: journal log messages are missing with latest version To: "Li, Yong B" Cc: Matt Spinler , William Kennington , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 14:58:16 -0000 On Thu, Jan 3, 2019 at 5:20 PM Li, Yong B wrote= : > > Thanks Patrick for your mails. > > Will test https://gerrit.openbmc-project.xyz/17054, and update the result= s. > > On 1/4/2019 6:33 AM, Patrick Venture wrote: > > On Thu, Jan 3, 2019 at 2:28 PM Patrick Venture wro= te: > >> On Thu, Jan 3, 2019 at 11:19 AM Patrick Venture w= rote: > >>> On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler > >>> wrote: > >>>> On 2019-01-02 13:09, Patrick Venture wrote: > >>>>> On Thu, Dec 20, 2018 at 4:38 PM Yong Li > >>>>> wrote: > >>>>>> > >>>>>> > >>>>>> Hi Patrick, > >>>>>> > >>>>>> > >>>>>> > >>>>>> I encountered a problem after upgrade to the latest opnebmc versio= n: > >>>>>> > >>>>>> > >>>>>> > >>>>>> These log messages in ipmid are missing with the =E2=80=9Cjournalc= tl -f=E2=80=9D. > >>>>> Which log messages? > >>>> > >>>> This showed up on all of our systems too, anything logged using > >>>> phosphor-logging > >>>> is missing from the journal. I even ended up using a git bisect to = also > >>>> narrow > >>>> it down to: > >>>> > >>>> phosphor-logging: srcrev bump 30047bf964..31552c05e2 > >>>> > >>>> Patrick Venture (5): > >>>> add sdjournal interface to inject tests > >>>> test: use only one main library > >>>> bugfix: add fixes to mock class > >>>> bugfix: rename method to match implementation > >>>> test: add test to force building of sdjournal mock > >>>> > >>> William, you've been digging into sdbus a lot recently, can you take = a > >>> deep look at the patchset above and see what I may have messed up? > >>> The phosphor-logging unit-tests were broken until I got it "working." > >>> Which lead me to believe that it's not correct -- and the daemons tha= t > >>> have unit-tests that hit the log message are seeing the calls. > >> From reading more into the var_args pass-through, that may be the > >> issue. One cannot pass the var args down directly like this. I > >> propose to initially snip out this extra call and then revisit so that > >> it'll resume working. > > https://gerrit.openbmc-project.xyz/17054 > >> The problem is that sd_journal_send doesn't expect a va_list argument, > >> but rather strictly var args, which aren't the same. I generally try to avoid copying implementations, but an approach to this that would work and allow testing would be to use sd_journal_sendv() and have the interface call walk the parameters and build a list of iovec structures and then pass that. This is effectively what is done by sd_journal_send, which just processes the input and sends to sd_journal_sendv. We could also pass to sd_journal_print which takes a va_list, however, the behavior isn't identical for structured log entries. So my question is, if we lift the code from systemd and make it work, that'll presumably add another license piece to phosphor-logging --- and I'm not really sure how that works. > >> > >>>>>> > >>>>>> > >>>>>> My tests shows that the blow change is related, after I revert it,= I > >>>>>> can get these log messages. > >>>>>> > >>>>>> > >>>>>> > >>>>>> Did you meet such issue, or any suggestions/comments to narrow dow= n > >>>>>> this issue? > >>>>>> > >>>>>> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066= baa6f3711c88d6a3b9a5c4d49 > >>>>>> > >>>>>> add sdjournal interface to inject tests > >>>>> There were some follow-on patches for phosphor-logging that you > >>>>> shouldn't need -- it's > >>>>> > >>>>> What SHA is for your https://github.com/openbmc/phosphor-host-ipmid= ? > >>>>> (so I know what version of that is in use by you). > >>>>> > >>>>> Checking the HEAD version of > >>>>> https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile= .am, > >>>>> I see it's including the proper libs to get the full phosphor-loggi= ng > >>>>> objects. > >>>>> > >>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> > >>>>>> Yong >