All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
	<linux-pci@vger.kernel.org>
Cc: "'Pratyush Anand'" <pratyush.anand@gmail.com>,
	"'Arnd Bergmann'" <arnd@arndb.de>,
	"'Bjorn Helgaas'" <bhelgaas@google.com>,
	"'Gabriele Paoloni'" <gabriele.paoloni@huawei.com>,
	"'Zhou Wang'" <wangzhou1@hisilicon.com>,
	"'Jingoo Han'" <jingoohan1@gmail.com>
Subject: Re: [PATCH 2/2] drivers: pci: host: designware: remove PCI_PROBE_ONLY handling
Date: Sun, 31 Jan 2016 21:34:40 +0900	[thread overview]
Message-ID: <000701d15c23$c67963f0$536c2bd0$@com> (raw)
In-Reply-To: <1454066972-3609-2-git-send-email-lorenzo.pieralisi@arm.com>

On Friday, January 29, 2016 8:30 PM, Lorenzo Pieralisi wrote:
> 
> The PCIe designware host driver is not used in system configurations
> requiring the PCI_PROBE_ONLY flag to be set to prevent resources
> assignment, therefore the driver code handling the flag can be
> removed from the kernel.
> 
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Jingoo Han <jingoohan1@gmail.com>

Acked-by: Jingoo Han Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>
> Cc: Zhou Wang <wangzhou1@hisilicon.com>
> ---
>  drivers/pci/host/pcie-designware.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 2171682..a445083 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -551,13 +551,11 @@ int dw_pcie_host_init(struct pcie_port *pp)
>  	pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
>  #endif
> 
> -	if (!pci_has_flag(PCI_PROBE_ONLY)) {
> -		pci_bus_size_bridges(bus);
> -		pci_bus_assign_resources(bus);
> +	pci_bus_size_bridges(bus);
> +	pci_bus_assign_resources(bus);
> 
> -		list_for_each_entry(child, &bus->children, node)
> -			pcie_bus_configure_settings(child);
> -	}
> +	list_for_each_entry(child, &bus->children, node)
> +		pcie_bus_configure_settings(child);
> 
>  	pci_bus_add_devices(bus);
>  	return 0;
> --
> 2.5.1


  parent reply	other threads:[~2016-01-31 12:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 11:29 [PATCH 1/2] drivers: pci: host: rcar: remove PCI_PROBE_ONLY handling Lorenzo Pieralisi
2016-01-29 11:29 ` [PATCH 2/2] drivers: pci: host: designware: " Lorenzo Pieralisi
2016-01-29 12:13   ` Gabriele Paoloni
2016-01-29 16:16   ` Pratyush Anand
2016-01-31 12:34   ` Jingoo Han [this message]
2016-02-05 20:28   ` Bjorn Helgaas
2016-02-05  0:27 ` [PATCH 1/2] drivers: pci: host: rcar: " Bjorn Helgaas
2016-02-05  9:35   ` Simon Horman
2016-02-05 20:27 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701d15c23$c67963f0$536c2bd0$@com' \
    --to=jingoohan1@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=gabriele.paoloni@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=pratyush.anand@gmail.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.