From: "Doug Smythies" <dsmythies@telus.net>
To: 'Viresh Kumar' <viresh.kumar@linaro.org>
Cc: "'Rafael J. Wysocki'" <rafael@kernel.org>,
'Andy Tang' <andy.tang@nxp.com>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
'Linux PM' <linux-pm@vger.kernel.org>
Subject: RE: Ask for help on governor
Date: Wed, 13 Dec 2017 08:13:42 -0800 [thread overview]
Message-ID: <000701d3742d$5948f420$0bdadc60$@net> (raw)
In-Reply-To: P0Mmegy2kTqmMP0MoeccOV
On 2017.12.12 22:18 Viresh Kumar wrote:
> On 12-12-17, 19:10, Doug Smythies wrote:
>> Thanks for the suggestion. It was so very close, the problem commit is the very
>> next one, aa7519af450d.
>>
>> Bisect result:
>>
>> aa7519af450d3c62a057aece24877c34562fa25a is the first bad commit
>> commit aa7519af450d3c62a057aece24877c34562fa25a
>> Author: Viresh Kumar <viresh.kumar@linaro.org>
>> Date: Wed Jul 19 15:42:42 2017 +0530
>>
>> cpufreq: Use transition_delay_us for legacy governors as well
>>
>> The policy->transition_delay_us field is used only by the schedutil
>> governor currently, and this field describes how fast the driver wants
>> the cpufreq governor to change CPUs frequency. It should rather be a
>> common thing across all governors, as it doesn't have any schedutil
>> dependency here.
>>
>> Create a new helper cpufreq_policy_transition_delay_us() to get the
>> transition delay across all governors.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> What has changed for intel-pstate after this patch ?
>
> sampling_rate for conservative and ondemand is 500 us now, which was 20000 us
> earlier. So we reevaluate load very frequently now, but in case load isn't over
> 80% then we wouldn't increase the frequency.
>
> @Doug/Andy: Can you please try following:
>
> - Checkout 4.14 or mainline (the broken kernels).
> - Set governor to conservative.
> - Monitor /sys/devices/system/cpu/cpufreq/policy*/stats/total_trans (to check if
> frequency is getting changed or not).
I do not have a stats directory. I am now using kernel 4.15-rc3
> - Run some dummy load, I did this:
>
> perf bench sched messaging --pipe --thread --group 8
>
> This should result in frequency updates, so its not that we aren't changing
> frequency at all now with conservative.
>
> Then do this:
>
> echo 20000 > /sys/devices/system/cpu/cpufreq/conservative/sampling_rate
>
> and this should take you back to the original behavior which was there pre-4.14.
Yes, that works.
The breakpoint is <2000 (on my system, at least). 1999 doesn't work, but one can observe that it is trying.
2000 works, but seems to struggle a little.
... Doug
next prev parent reply other threads:[~2017-12-13 16:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HE1PR0402MB282866171A847AE244A9F76CF3340@HE1PR0402MB2828.eurprd04.prod.outlook.com>
2017-12-12 7:30 ` Ask for help on governor Viresh Kumar
2017-12-12 16:18 ` Doug Smythies
2017-12-12 16:51 ` Rafael J. Wysocki
2017-12-13 3:10 ` Doug Smythies
2017-12-13 6:17 ` Viresh Kumar
2017-12-13 6:22 ` Andy Tang
2017-12-13 6:55 ` Viresh Kumar
2017-12-13 16:13 ` Doug Smythies
2017-12-14 1:21 ` Doug Smythies
2017-12-14 2:42 ` Andy Tang
2017-12-14 18:25 ` Stratos Karafotis
2017-12-15 1:29 ` Doug Smythies
2017-12-15 1:30 ` Doug Smythies
2017-12-15 1:56 ` Andy Tang
2017-12-15 7:37 ` Doug Smythies
2017-12-15 9:00 ` Andy Tang
2017-12-15 14:26 ` Rafael J. Wysocki
2017-12-15 15:53 ` Rafael J. Wysocki
2017-12-15 18:27 ` Doug Smythies
2017-12-15 23:53 ` Rafael J. Wysocki
2017-12-18 1:15 ` [PATCH] cpufreq: governor: Ensure sufficiently large sampling intervals Rafael J. Wysocki
2017-12-18 2:59 ` Andy Tang
2017-12-18 4:38 ` Viresh Kumar
2017-12-18 16:11 ` Doug Smythies
2017-12-18 17:42 ` Rafael J. Wysocki
2017-12-13 16:13 ` Doug Smythies [this message]
2017-12-13 16:49 ` Ask for help on governor Doug Smythies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701d3742d$5948f420$0bdadc60$@net' \
--to=dsmythies@telus.net \
--cc=andy.tang@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.