From: "Dedy Lansky" <dlansky@codeaurora.org>
To: "'Johannes Berg'" <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Cc: "'Florian Westphal'" <fw@strlen.de>,
"'Johannes Berg'" <johannes.berg@intel.com>
Subject: RE: [EXT] [RFC/RFT] cfg80211: decouple us from the RTNL
Date: Mon, 5 Aug 2019 18:20:05 +0300 [thread overview]
Message-ID: <000701d54ba1$48ea2520$dabe6f60$@codeaurora.org> (raw)
In-Reply-To: <20190731220848.1045-1-johannes@sipsolutions.net>
From: linux-wireless-owner@vger.kernel.org
<linux-wireless-owner@vger.kernel.org> On Behalf Of Johannes Berg
Sent: Thursday, August 1, 2019 1:09 AM
> Fix that by re-adding a mutex to each wiphy/rdev as we had at
> some point, so we have locking for the wireless_dev lists and
> all the other things in there, and also so that drivers still
> don't have to worry too much about it (they still won't get
> parallel calls for a single device).
Sounds good.
> Then, we can restrict the RTNL to a few cases where we add or
> remove interfaces and really need the added protection. Some
> of the global list management still also uses the RTNL, since
> we need to have it anyway for netdev management.
> TODO:
> - use wiphy_lock()/wiphy_unlock() in all drivers as the code
> changed in mac80211 does
I guess this change breaks existing drivers because some drivers assume RTNL
is locked when their cfg callbacks are executed. Is that correct?
Would there be any simple rules for drivers when to use each one of the
locking API: rtnl vs wiphy vs wdev ?
Thanks,
Dedy.
next prev parent reply other threads:[~2019-08-05 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 22:08 [RFC/RFT] cfg80211: decouple us from the RTNL Johannes Berg
2019-08-01 3:59 ` Sid Hayn
2019-08-05 15:20 ` Dedy Lansky [this message]
2019-08-05 20:41 ` [EXT] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701d54ba1$48ea2520$dabe6f60$@codeaurora.org' \
--to=dlansky@codeaurora.org \
--cc=fw@strlen.de \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.