All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
	<linux-scsi@vger.kernel.org>, <alim.akhtar@samsung.com>,
	<avri.altman@wdc.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <beanhuo@micron.com>,
	<asutoshd@codeaurora.org>, <cang@codeaurora.org>,
	<grant.jung@samsung.com>, <sc.suh@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>
Subject: RE: [RFC PATCH v3 1/2] ufs: support various values per device
Date: Mon, 6 Jul 2020 15:43:33 +0900	[thread overview]
Message-ID: <000701d65360$c496eec0$4dc4cc40$@samsung.com> (raw)
In-Reply-To: <b2a0f977-8155-a947-d883-626c1c7762bb@acm.org>

> On 2020-07-02 22:30, Kiwoong Kim wrote:
> > +static const struct ufs_dev_value ufs_dev_values[] = {
> > +	{0, 0, 0, 0, false},
> > +};
> 
> A minor stylistic request: please change "{0, 0, 0, 0, false}" into "{ }".
> The C language requires that structure members that have not been
> specified are zero-initialized.
> 
> Thanks,
> 
> Bart.

Got it and I experienced the tool chain to show warning messages for not specifying details in there.

Thanks.
Kiwoong Kim


  reply	other threads:[~2020-07-06  6:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200703053755epcas2p23adbc614d9a72cf3335ed1e6223709f3@epcas2p2.samsung.com>
2020-07-03  5:30 ` [RFC PATCH v3 0/2] ufs: support various values per device Kiwoong Kim
2020-07-03  5:30   ` [RFC PATCH v3 1/2] " Kiwoong Kim
2020-07-05 11:14     ` Avri Altman
2020-07-06 11:35       ` Grant Jung
2020-07-15  8:03       ` Kiwoong Kim
2020-07-05 15:07     ` Bart Van Assche
2020-07-06  6:43       ` Kiwoong Kim [this message]
2020-07-06 17:52         ` Bart Van Assche
2020-07-03  5:30   ` [RFC PATCH v3 2/2] ufs: change the way to complete fDeviceInit Kiwoong Kim
2020-07-05 10:53     ` Avri Altman
2020-07-15  8:09       ` Kiwoong Kim
2020-07-19  6:46         ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701d65360$c496eec0$4dc4cc40$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=grant.jung@samsung.com \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.