All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Doug Smythies" <dsmythies@telus.net>
To: "'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>,
	"'Rafael J. Wysocki'" <rafael@kernel.org>
Cc: "'Linux PM'" <linux-pm@vger.kernel.org>
Subject: cpufreq: intel_pstate: EPB with performance governor
Date: Fri, 10 Jul 2020 06:33:57 -0700	[thread overview]
Message-ID: <000701d656be$c48083e0$4d818ba0$@net> (raw)

Hi Srinivas and/or Rafael,

Can you please confirm or deny that an older
commit:

commit 8442885fca09b2d26375b9fe507759879a6f661e
cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode

has been superseded by:

arch/x86/kernel/cpu/intel_epb.c

and that now there is no way to have some default EPB (say 6) for
governors other than performance, while still getting an EPB of 0
for the performance governor.

... Doug

Additional notes:
Both my test computers have EPB as 0 upon startup,
But I also tried this:

diff --git a/arch/x86/kernel/cpu/intel_epb.c b/arch/x86/kernel/cpu/intel_epb.c
index f4dd73396f28..b536e381cd56 100644
--- a/arch/x86/kernel/cpu/intel_epb.c
+++ b/arch/x86/kernel/cpu/intel_epb.c
@@ -74,7 +74,8 @@ static int intel_epb_save(void)

 static void intel_epb_restore(void)
 {
-       u64 val = this_cpu_read(saved_epb);
+//     u64 val = this_cpu_read(saved_epb);
+       u64 val = 6;
        u64 epb;

        rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);

which did get rid of this message:
kernel: [    0.102158] ENERGY_PERF_BIAS: Set to 'normal', was 'performance'



             reply	other threads:[~2020-07-10 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 13:33 Doug Smythies [this message]
2020-07-15 16:46 ` cpufreq: intel_pstate: EPB with performance governor Rafael J. Wysocki
2020-07-15 22:43   ` Doug Smythies
2020-07-16 12:00     ` Rafael J. Wysocki
2020-07-17 21:22       ` Doug Smythies
2020-07-19 11:22         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701d656be$c48083e0$4d818ba0$@net' \
    --to=dsmythies@telus.net \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.