All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: fix compiling error due to debug_info change
Date: Mon, 7 Mar 2011 10:42:38 -0000	[thread overview]
Message-ID: <000801cbdcb4$612bde40$23839ac0$@deacon@arm.com> (raw)
In-Reply-To: <1299493870-8217-1-git-send-email-bryan.wu@canonical.com>

Hi Bryan,

> Subject: [PATCH 1/2] ARM: fix compiling error due to debug_info change

Is there a patch 2/2 as well? (I only received this one).
 
> This bug was introduced by "ARM: 6668/1: ptrace: remove single-step emulation code" from Will Deacon
> 
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
>  arch/arm/include/asm/a.out-core.h |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/include/asm/a.out-core.h b/arch/arm/include/asm/a.out-core.h
> index 93d04ac..639f5c8 100644
> --- a/arch/arm/include/asm/a.out-core.h
> +++ b/arch/arm/include/asm/a.out-core.h
> @@ -32,12 +32,6 @@ static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump)
>  	dump->u_dsize = (tsk->mm->brk - tsk->mm->start_data + PAGE_SIZE - 1) >> PAGE_SHIFT;
>  	dump->u_ssize = 0;
> 
> -	dump->u_debugreg[0] = tsk->thread.debug.bp[0].address;
> -	dump->u_debugreg[1] = tsk->thread.debug.bp[1].address;
> -	dump->u_debugreg[2] = tsk->thread.debug.bp[0].insn.arm;
> -	dump->u_debugreg[3] = tsk->thread.debug.bp[1].insn.arm;
> -	dump->u_debugreg[4] = tsk->thread.debug.nsaved;
> -
>  	if (dump->start_stack < 0x04000000)
>  		dump->u_ssize = (0x04000000 - dump->start_stack) >> PAGE_SHIFT;

Damn, looks like I forgot to update this code. I think it might be better
to memset zero the u_debugreg array rather than ignore the assignment and
also add a comment to struct user to explain that thie field is no longer
used.

Will

  reply	other threads:[~2011-03-07 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 10:31 [PATCH 1/2] ARM: fix compiling error due to debug_info change Bryan Wu
2011-03-07 10:42 ` Will Deacon [this message]
     [not found] ` <-6991351870718115910@unknownmsgid>
2011-03-10  3:41   ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000801cbdcb4$612bde40$23839ac0$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.