From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Z4Oao-00038I-2F
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Z4Oak-0004wM-Si
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:14:01 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:61218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Z4Oak-0004w7-NV
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:13:58 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout3.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NPZ00KFU5F7TP10@mailout3.w1.samsung.com> for
	qemu-devel@nongnu.org; Mon, 15 Jun 2015 08:13:55 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <02f601d0a1e6$90c7d630$b2578290$@samsung.com>
	<CAFEAcA_XSZruYsKLHZCu4NoebxJEaQCUVvGeAWa9XctEC9SD8A@mail.gmail.com>
In-reply-to: <CAFEAcA_XSZruYsKLHZCu4NoebxJEaQCUVvGeAWa9XctEC9SD8A@mail.gmail.com>
Date: Mon, 15 Jun 2015 10:13:54 +0300
Message-id: <000801d0a73a$d6fbeac0$84f3c040$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'QEMU Developers' <qemu-devel@nongnu.org>

 Hello!

> > +int arm_cpus_per_cluster =3D 8;
>=20
> This doesn't need to be global, it doesn't need to be exposed in
> a header file, and it definitely doesn't need to be non-constant.
> I suggest
> #define ARM_CPUS_PER_CLUSTER 8

 It was a #define in v3, but i decided to change this in order to allow =
machine models to request different topology as Igor suggested. Of =
course you can revert to #define if you strictly want to.

> These are minor nits so I plan to just fix them as I apply
> this to target-arm.next, unless you object.

 No, i don't object and of course i'm waiting for the PULL.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia