All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rico Bachmann <bachmann@tofwerk.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add package subversion
Date: Mon, 29 Apr 2013 13:23:07 +0200	[thread overview]
Message-ID: <000901ce44cb$ecc77eb0$c6567c10$@com> (raw)
In-Reply-To: <20130429110301.GB25186@sapphire.tkos.co.il>

Hi Baruch

> -----Urspr?ngliche Nachricht-----
> Von: Baruch Siach [mailto:baruch at tkos.co.il]
> Gesendet: Montag, 29. April 2013 13:03
> An: Rico Bachmann
> Cc: buildroot at uclibc.org
> Betreff: Re: [Buildroot] [PATCH] Add package subversion
> 
> Hi Rico,
> 
> On Mon, Apr 29, 2013 at 12:35:46PM +0200, Rico Bachmann wrote:
> > Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> > ---
> 
> [snip]
> 
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_SUBVERSION
> > +	bool "subversion"
> > +	select BR2_PACKAGE_APR_UTIL
> 
> select BR2_PACKAGE_EXPAT

I add this line in a new patch version

> 
> > +	# apr really needs shared library support
> > +	depends on !BR2_PREFER_STATIC_LIB
> > +	help
> > +	  Subversion is an open source version control system
> > +
> > +	  http://subversion.apache.org/
> 
> [snip]
> 
> > +SUBVERSION_VERSION = 1.7.9
> > +SUBVERSION_SITE = http://archive.apache.org/dist/subversion
> > +SUBVERSION_DEPENDENCIES = apr apr-util expat SUBVERSION_CONF_OPT = \
> > +	--with-expat=$(STAGING_DIR)/usr:$(STAGING_DIR)/usr:expat \
> 
> The ":$(STAGING_DIR)/usr:expat" part looks wrong. Are you sure this is
> needed?

I check if the ":$(STAGING_DIR)/usr:expat" part is really needed, before I
send the new patch version.

> 
> > +	--with-apr=$(BUILD_DIR)/apr-$(APR_VERSION) \
> > +	--with-apr-util=$(BUILD_DIR)/apr-util-$(APR_UTIL_VERSION)
> 
> [snip]
> 
> baruch
> 
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo----------
> --{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

I'll send the new patch version during this day.

Greez
Rico

  reply	other threads:[~2013-04-29 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 10:35 [Buildroot] [PATCH] Add package subversion Rico Bachmann
2013-04-29 11:03 ` Baruch Siach
2013-04-29 11:23   ` Rico Bachmann [this message]
2013-04-30 13:53   ` Rico Bachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901ce44cb$ecc77eb0$c6567c10$@com' \
    --to=bachmann@tofwerk.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.