RE: [PATCH v4] wireless-drivers: Dynamically allocate struct station_info

["Dedy Lansky" <dlansky@codeaurora.org>]

Hi Toke,

Thanks for taking care of wil6210 part. See comment below.

> @@ -824,7 +824,7 @@ static void wmi_evt_connect(struct wil6210_vif =
*vif, int id, void *d, int len)
>  	struct wireless_dev *wdev =3D vif_to_wdev(vif);
>  	struct wmi_connect_event *evt =3D d;
>  	int ch; /* channel number */
> -	struct station_info sinfo;
> +	struct station_info *sinfo;
>  	u8 *assoc_req_ie, *assoc_resp_ie;
>  	size_t assoc_req_ielen, assoc_resp_ielen;
>  	/* capinfo(u16) + listen_interval(u16) + IEs */ @@ -940,6 +940,11 @@ =
static void wmi_evt_connect(struct wil6210_vif *vif, int id, void *d, =
int len)
>  		vif->bss =3D NULL;
>  	} else if ((wdev->iftype =3D=3D NL80211_IFTYPE_AP) ||
>  		   (wdev->iftype =3D=3D NL80211_IFTYPE_P2P_GO)) {
> +
> +		sinfo =3D kzalloc(sizeof(*sinfo), GFP_KERNEL);
> +		if (!sinfo)
> +			rc =3D -ENOMEM;
> +
>  		if (rc) {
>  			if (disable_ap_sme)
>  				/* notify new_sta has failed */
> @@ -947,16 +952,16 @@ static void wmi_evt_connect(struct wil6210_vif =
*vif, int id, void *d, int len)
>  			goto out;

Need to kfree sinfo here. I suggest instead to move the kzalloc below =
the whole "if (rc)"


>  		}
> =20
> -		memset(&sinfo, 0, sizeof(sinfo));
> -
> -		sinfo.generation =3D wil->sinfo_gen++;
> +		sinfo->generation =3D wil->sinfo_gen++;

Thanks,
 Dedy.