All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Avri Altman'" <Avri.Altman@wdc.com>,
	<linux-scsi@vger.kernel.org>, <alim.akhtar@samsung.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<beanhuo@micron.com>, <asutoshd@codeaurora.org>,
	<cang@codeaurora.org>, <bvanassche@acm.org>,
	<grant.jung@samsung.com>, <sc.suh@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>
Subject: RE: [RESEND RFC PATCH v4 3/3] ufs: exynos: implement dbg_register_dump
Date: Sat, 11 Jul 2020 14:43:43 +0900	[thread overview]
Message-ID: <000901d65746$3cd27100$b6775300$@samsung.com> (raw)
In-Reply-To: <BYAPR04MB46294F9AA905B811900BB48AFC640@BYAPR04MB4629.namprd04.prod.outlook.com>

> > +static void exynos_ufs_dbg_register_dump(struct ufs_hba *hba) {
> > +       struct exynos_ufs *ufs = ufshcd_get_variant(hba);
> > +       unsigned long flags;
> > +
> > +       spin_lock_irqsave(&ufs->dbg_lock, flags);
> > +       if (ufs->under_dump == 0)
> If you would use test_and_set_bit it would save you both under_dump and
> dbg_lock ?


Great. Got it.

Thanks.
Kiwoong Kim


  reply	other threads:[~2020-07-11  5:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200708023153epcas2p1fc18ee2920c5defa2896af34dd62865f@epcas2p1.samsung.com>
2020-07-08  2:23 ` [RESEND RFC PATCH v4 0/3] ufs: exynos: introduce the way to get cmd info Kiwoong Kim
2020-07-08  2:23   ` [RESEND RFC PATCH v4 1/3] ufs: introduce a callback to get info of command completion Kiwoong Kim
2020-07-09 12:06     ` Avri Altman
2020-07-11  5:43       ` Kiwoong Kim
2020-07-08  2:24   ` [RESEND RFC PATCH v4 2/3] ufs: exynos: introduce command history Kiwoong Kim
2020-07-09 13:27     ` Avri Altman
2020-07-11  5:53       ` Kiwoong Kim
2020-07-11  5:58       ` Kiwoong Kim
2020-07-08  2:24   ` [RESEND RFC PATCH v4 3/3] ufs: exynos: implement dbg_register_dump Kiwoong Kim
2020-07-09 12:30     ` Avri Altman
2020-07-11  5:43       ` Kiwoong Kim [this message]
2020-07-17 16:14     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901d65746$3cd27100$b6775300$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=grant.jung@samsung.com \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.