From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Date: Tue, 22 Dec 2015 21:26:52 +0900 Message-ID: <000a01d13cb4$0f81f510$2e85df30$@com> References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450238257-3274-1-git-send-email-ykk@rock-chips.com> Content-Language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'Yakir Yang' , 'Inki Dae' , 'Mark Yao' , 'Heiko Stuebner' Cc: devicetree@vger.kernel.org, 'Krzysztof Kozlowski' , linux-samsung-soc@vger.kernel.org, 'Russell King' , linux-rockchip@lists.infradead.org, 'Jingoo Han' , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Kishon Vijay Abraham I' , javier@osg.samsung.com, 'Rob Herring' , 'Andy Yan' , 'Thierry Reding' , 'Gustavo Padovan' , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gV2VkbmVzZGF5LCBEZWNlbWJlciAxNiwgMjAxNSAxMjo1OCBQTSwgWWFraXIgWWFuZyB3cm90 ZToKPiAKPiBBZnRlciB0ZXN0IG9uIHJvY2tjaGlvcCBwbGF0Zm9ybSwgaSBmb3VuZCBzb21ldGlt cyBkcml2ZXIgd291bGQgZmFpbGVkCj4gYXQgcmVhZGluZyBFRElEIG1lc3NhZ2UuIEFmdGVyIGRl YnVnZ2luZyBtb3JlLCBpIGZvdW5kIHRoYXQgaXQncyBva2F5Cj4gdG8gcmVhZF9hIGJ5dGUgZnJv bSBpMmMsIGJ1dCBpdCB3b3VsZCBmYWlsZWQgYXQgQVVYIHRyYW5zY2F0aW9uIGlmIHdlCj4gdHJ5 IHRvIHJlYWR5IG11bHRpLWJ5dGVzIGZyb20gaTJjLgo+IAo+IERyaXZlciBqdXN0IGNhbid0IHJl Y2VpdmVkIHRoZSBBVVggQ0ggcmVwbHkgY29tbWFuZCwgZXZlbiBubyBBVVggZXJyb3IKPiBjb2Rl LiBJIG1heSBndWVzcyB0aGF0IHRoZSBBVVggd2FpdCB0aW1lIGlzIG5vdCBlbm91Z2gsIHNvIEkg dHJ5IHRvCj4gZXhwYW5kIHRoZSBBVVggd2FpdCB0aW1lLCBhbmQgaSBkbyBzZWUgdGhpcyBjb3Vs ZCBmaXggdGhlIEVESUQgcmVhZAo+IGZhaWxlZCBhdCByb2NrY2hpcCBwbGF0Zm9ybS4KPiAKPiBB bmQgSSB0aG91Z2h0IHRoYXQgZXhwYW5kIHRoZSB3YWl0IHRpbWUgd29uJ3QgaHVydCBFeHlub3Mg cGxhdGZvcm0gdG9vCj4gbXVjaCwgY2F1c2UgRXh5bm9zIGRpZG4ndCBoYXZlIHRoaXMgcHJvYmxl bSwgdGhlbiBkcml2ZXIgd291bGQgcmVjZWl2ZWQKPiB0aGUgcmVwbHkgY29tbWFuZCB2ZXJ5IHNv b24sIHNvIG5vIG1vcmUgYWRkaXRpb25hbCB3YWl0IHRpbWUgd291bGQgYnJpbmcKPiB0byBFeHlu b3MgcGxhdGZvcm0uCj4gCj4gU2lnbmVkLW9mZi1ieTogWWFraXIgWWFuZyA8eWtrQHJvY2stY2hp cHMuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4gdjExOiBOb25lCj4gQ2hhbmdlcyBpbiB2MTA6IE5v bmUKPiBDaGFuZ2VzIGluIHY5OiBOb25lCj4gQ2hhbmdlcyBpbiB2ODogTm9uZQo+IENoYW5nZXMg aW4gdjc6IE5vbmUKPiBDaGFuZ2VzIGluIHY2OiBOb25lCj4gQ2hhbmdlcyBpbiB2NTogTm9uZQo+ IENoYW5nZXMgaW4gdjQ6IE5vbmUKPiBDaGFuZ2VzIGluIHYzOiBOb25lCj4gQ2hhbmdlcyBpbiB2 MjogTm9uZQo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2Rw X3JlZy5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9h bmFsb2dpeF9kcF9yZWcuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFs b2dpeF9kcF9yZWcuYwo+IGluZGV4IGM3ZTI5NTkuLmRjMzc2YmQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmMKPiBAQCAtNDgy LDcgKzQ4Miw3IEBAIGludCBhbmFsb2dpeF9kcF9zdGFydF9hdXhfdHJhbnNhY3Rpb24oc3RydWN0 IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApCj4gIAlyZWcgPSByZWFkbChkcC0+cmVnX2Jhc2UgKyBB TkFMT0dJWF9EUF9JTlRfU1RBKTsKPiAgCXdoaWxlICghKHJlZyAmIFJQTFlfUkVDRUlWKSkgewo+ ICAJCXRpbWVvdXRfbG9vcCsrOwo+IC0JCWlmIChEUF9USU1FT1VUX0xPT1BfQ09VTlQgPCB0aW1l b3V0X2xvb3ApIHsKPiArCQlpZiAoRFBfVElNRU9VVF9MT09QX0NPVU5UICogMTAgPCB0aW1lb3V0 X2xvb3ApIHsKCk5vLCBJIGhhdGUgdGhpcyBjb2RpbmcuCmFuYWxvZ2l4X2RwX3JlZy5jIGlzIHRo ZSBjb21tb24gY29kZSB0aGF0IGNhbiBiZSBzaGFyZWQgYnkgdmFyaW91cyBTb0NzLgpQbGVhc2Us IGZpbmQgYW5vdGhlciB3YXkuCgpCZXN0IHJlZ2FyZHMsCkppbmdvbyBIYW4KCgo+ICAJCQlkZXZf ZXJyKGRwLT5kZXYsICJBVVggQ0ggY29tbWFuZCByZXBseSBmYWlsZWQhXG4iKTsKPiAgCQkJcmV0 dXJuIC1FVElNRURPVVQ7Cj4gIAkJfQo+IC0tCj4gMS45LjEKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: jingoohan1@gmail.com (Jingoo Han) Date: Tue, 22 Dec 2015 21:26:52 +0900 Subject: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply In-Reply-To: <1450238257-3274-1-git-send-email-ykk@rock-chips.com> References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> Message-ID: <000a01d13cb4$0f81f510$2e85df30$@com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: > > After test on rockchiop platform, i found sometims driver would failed > at reading EDID message. After debugging more, i found that it's okay > to read_a byte from i2c, but it would failed at AUX transcation if we > try to ready multi-bytes from i2c. > > Driver just can't received the AUX CH reply command, even no AUX error > code. I may guess that the AUX wait time is not enough, so I try to > expand the AUX wait time, and i do see this could fix the EDID read > failed at rockchip platform. > > And I thought that expand the wait time won't hurt Exynos platform too > much, cause Exynos didn't have this problem, then driver would received > the reply command very soon, so no more additional wait time would bring > to Exynos platform. > > Signed-off-by: Yakir Yang > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index c7e2959..dc376bd 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); > while (!(reg & RPLY_RECEIV)) { > timeout_loop++; > - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { > + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { No, I hate this coding. analogix_dp_reg.c is the common code that can be shared by various SoCs. Please, find another way. Best regards, Jingoo Han > dev_err(dp->dev, "AUX CH command reply failed!\n"); > return -ETIMEDOUT; > } > -- > 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbbLVM1E (ORCPT ); Tue, 22 Dec 2015 07:27:04 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35760 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbbLVM1B (ORCPT ); Tue, 22 Dec 2015 07:27:01 -0500 From: "Jingoo Han" To: "'Yakir Yang'" , "'Inki Dae'" , "'Mark Yao'" , "'Heiko Stuebner'" Cc: "'Thierry Reding'" , "'Krzysztof Kozlowski'" , "'Rob Herring'" , "'Russell King'" , , "'Gustavo Padovan'" , "'Kishon Vijay Abraham I'" , , "'Andy Yan'" , , , , , , , "'Jingoo Han'" References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1450238257-3274-1-git-send-email-ykk@rock-chips.com> Subject: Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Date: Tue, 22 Dec 2015 21:26:52 +0900 Message-ID: <000a01d13cb4$0f81f510$2e85df30$@com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdE3tjVnJ7o1B42HQEuMhF3Dd8r7sQE/XqOg Content-Language: ko Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: > > After test on rockchiop platform, i found sometims driver would failed > at reading EDID message. After debugging more, i found that it's okay > to read_a byte from i2c, but it would failed at AUX transcation if we > try to ready multi-bytes from i2c. > > Driver just can't received the AUX CH reply command, even no AUX error > code. I may guess that the AUX wait time is not enough, so I try to > expand the AUX wait time, and i do see this could fix the EDID read > failed at rockchip platform. > > And I thought that expand the wait time won't hurt Exynos platform too > much, cause Exynos didn't have this problem, then driver would received > the reply command very soon, so no more additional wait time would bring > to Exynos platform. > > Signed-off-by: Yakir Yang > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index c7e2959..dc376bd 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); > while (!(reg & RPLY_RECEIV)) { > timeout_loop++; > - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { > + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { No, I hate this coding. analogix_dp_reg.c is the common code that can be shared by various SoCs. Please, find another way. Best regards, Jingoo Han > dev_err(dp->dev, "AUX CH command reply failed!\n"); > return -ETIMEDOUT; > } > -- > 1.9.1