From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=yong.b.li@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 454Dmx6g5HzDqV3 for ; Thu, 16 May 2019 11:46:55 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 18:46:52 -0700 X-ExtLoop1: 1 Received: from yongli3-mobl.ccr.corp.intel.com (HELO yongli3MOBL) ([10.239.196.32]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2019 18:46:51 -0700 From: "Yong Li" To: , "'OpenBMC Maillist'" Cc: "Li, Yong B" Subject: Cannot find the submit button after "+2" Date: Thu, 16 May 2019 09:46:50 +0800 Message-ID: <000d01d50b89$3beb7750$b3c265f0$@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_000E_01D50BCC.4A1212B0" X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdULhzRkW295JbmARneLbKVH8H9hQA== Content-Language: en-us x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBiNzQ2ZWMtNGY2MC00NThmLTk4OTAtMGFjMGI3NjMyOWZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlZJdjVuaEZ2a1dCaDY4QXdITFZqZmphN2tKOUtuNUtsZkJtbGk4eGtYQ2p1M2s1RlhtWWFibFc3ZFNGNFRIeCJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2019 01:46:59 -0000 This is a multipart message in MIME format. ------=_NextPart_000_000E_01D50BCC.4A1212B0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Brad, On the below code review I submitted, there are "+2" already, but I cannot find the submit button on the web page, Do I need to apply for other permissions or groups? https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/, Thanks, Yong ------=_NextPart_000_000E_01D50BCC.4A1212B0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Brad,

On the below = code review I submitted, there are “+2” already, but I = cannot find the submit button on the web page,

Do I need to = apply for other permissions or groups?

https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17= 234/,

Thanks,

Yong

------=_NextPart_000_000E_01D50BCC.4A1212B0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=fuzziesquirrel.com (client-ip=173.167.31.197; helo=bajor.fuzziesquirrel.com; envelope-from=bradleyb@fuzziesquirrel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fuzziesquirrel.com Received: from bajor.fuzziesquirrel.com (mail.fuzziesquirrel.com [173.167.31.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4570CB3vLzzDqDr for ; Mon, 20 May 2019 23:30:45 +1000 (AEST) X-Virus-Scanned: amavisd-new at fuzziesquirrel.com Date: Mon, 20 May 2019 09:31:30 -0400 From: Brad Bishop To: Yong Li Cc: 'OpenBMC Maillist' , "Li, Yong B" Subject: Re: Cannot find the submit button after "+2" Message-ID: <20190520133130.ifmq4x2utuqqdzva@thinkpad.dyn.fuzziesquirrel.com> References: <000d01d50b89$3beb7750$b3c265f0$@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <000d01d50b89$3beb7750$b3c265f0$@linux.intel.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 13:30:47 -0000 On Thu, May 16, 2019 at 09:46:50AM +0800, Yong Li wrote: >Hi Brad, > > > >On the below code review I submitted, there are "+2" already, but I cannot >find the submit button on the web page, > > > >Do I need to apply for other permissions or groups? > > > >https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/, > > > >Thanks, > >Yong > Hi Yong Whether or not the patch author clicks submit or the maintainer clicks submit is a matter of maintainer preference. I prefer to oversee the merging of changes into the repositories I maintain. I know that other maintainers perfer to approve the change but delegate the actual submission to the patch author (and that is fine). I'm working on assigning the owner permission to refs/* to the current repository maintainer for each openbmc repository. This would allow each repository maintainer to enable this (or not) as they see fit. Thanks - brad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=yong.b.li@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 457Hcd03StzDqCX for ; Tue, 21 May 2019 11:05:19 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 18:05:16 -0700 X-ExtLoop1: 1 Received: from yongli3-mobl.ccr.corp.intel.com (HELO yongli3MOBL) ([10.239.196.238]) by fmsmga008.fm.intel.com with ESMTP; 20 May 2019 18:05:15 -0700 From: "Yong Li" To: "'Brad Bishop'" Cc: "'OpenBMC Maillist'" , "'Li, Yong B'" References: <000d01d50b89$3beb7750$b3c265f0$@linux.intel.com> <20190520133130.ifmq4x2utuqqdzva@thinkpad.dyn.fuzziesquirrel.com> In-Reply-To: <20190520133130.ifmq4x2utuqqdzva@thinkpad.dyn.fuzziesquirrel.com> Subject: RE: Cannot find the submit button after "+2" Date: Tue, 21 May 2019 09:05:14 +0800 Message-ID: <000a01d50f71$3ff660d0$bfe32270$@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQDmuazrM1JlGaniODV1kpxZewuVIQDD62RMqEtPgMA= Content-Language: en-us x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDNmNGYzY2MtYjdmYy00YTMzLTlkYWUtMDgyNGRhNzY0NmQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRXl0QjZyeGZiWGd3XC9PU1VFeHdlMWxHN2VWaHVvcFRMSXJFb3F2R2k2YmhIMWVjVVdVSmNZeVlNamNrMHYzbnQifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2019 01:05:22 -0000 Thanks Brad! Will contact the maintainers to merge my changes Thanks, Yong -----Original Message----- From: openbmc On Behalf Of Brad Bishop Sent: Monday, May 20, 2019 9:32 PM To: Yong Li Cc: 'OpenBMC Maillist' ; Li, Yong B Subject: Re: Cannot find the submit button after "+2" On Thu, May 16, 2019 at 09:46:50AM +0800, Yong Li wrote: >Hi Brad, > > > >On the below code review I submitted, there are "+2" already, but I >cannot find the submit button on the web page, > > > >Do I need to apply for other permissions or groups? > > > >https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/, > > > >Thanks, > >Yong > Hi Yong Whether or not the patch author clicks submit or the maintainer clicks submit is a matter of maintainer preference. I prefer to oversee the merging of changes into the repositories I maintain. I know that other maintainers perfer to approve the change but delegate the actual submission to the patch author (and that is fine). I'm working on assigning the owner permission to refs/* to the current repository maintainer for each openbmc repository. This would allow each repository maintainer to enable this (or not) as they see fit. Thanks - brad