From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Jitendra Kalsaria' <jitendra.kalsaria@qlogic.com>,
'Ron Mercer' <ron.mercer@qlogic.com>
Subject: [PATCH 05/15] net: qla3xxx: remove unnecessary pci_set_drvdata()
Date: Tue, 22 Oct 2013 13:16:37 +0900 [thread overview]
Message-ID: <000b01cecedd$8052b000$80f81000$%han@samsung.com> (raw)
In-Reply-To: <000601cecedd$1981e300$4c85a900$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 91a8fcd..0758b94 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -3916,7 +3916,6 @@ err_out_free_regions:
pci_release_regions(pdev);
err_out_disable_pdev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
err_out:
return err;
}
@@ -3939,7 +3938,6 @@ static void ql3xxx_remove(struct pci_dev *pdev)
iounmap(qdev->mem_map_registers);
pci_release_regions(pdev);
- pci_set_drvdata(pdev, NULL);
free_netdev(ndev);
}
--
1.7.10.4
next prev parent reply other threads:[~2013-10-22 4:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-22 6:07 ` Olof Johansson
2013-10-22 4:15 ` [PATCH 02/15] net: netxen: " Jingoo Han
2013-10-22 4:15 ` [PATCH 03/15] net: qlge: " Jingoo Han
2013-10-22 4:16 ` [PATCH 04/15] net: qlcnic: " Jingoo Han
2013-10-22 4:16 ` Jingoo Han [this message]
2013-10-22 4:17 ` [PATCH 06/15] net: r6040: " Jingoo Han
2013-10-22 4:17 ` [PATCH 07/15] net: 8139cp: " Jingoo Han
2013-10-22 4:17 ` [PATCH 08/15] net: 8139too: " Jingoo Han
2013-10-22 4:18 ` [PATCH 09/15] net: r8169: " Jingoo Han
2013-10-22 4:18 ` [PATCH 10/15] net: sis190: " Jingoo Han
2013-10-22 4:19 ` [PATCH 11/15] net: epic100: " Jingoo Han
2013-10-22 4:19 ` [PATCH 12/15] net: smsc9420: " Jingoo Han
2013-10-22 4:20 ` [PATCH 13/15] net: stmmac: " Jingoo Han
2013-10-22 4:20 ` [PATCH 14/15] net: sunhme: " Jingoo Han
2013-10-22 4:21 ` [PATCH 15/15] net: cassini: " Jingoo Han
2013-10-22 6:13 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01cecedd$8052b000$80f81000$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.