From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1YDB3J-0004J3-Qj
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1YDB3F-0002TT-QG
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:29 -0500
Received: from mail.ispras.ru ([83.149.199.45]:59043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1YDB3F-0002T2-JM
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:25 -0500
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <20150112115944.3504.66763.stgit@PASHA-ISP>
	<20150112120054.3504.35220.stgit@PASHA-ISP>
	<54B3BA89.6080705@redhat.com>
	<000501d02f12$61177b30$23467190$@Dovgaluk@ispras.ru>
	<54B4E79C.5010201@redhat.com>
	<000101d03162$f2d2ed50$d878c7f0$@Dovgaluk@ispras.ru>
	<54BCEFD1.5040702@redhat.com>
In-Reply-To: <54BCEFD1.5040702@redhat.com>
Date: Mon, 19 Jan 2015 15:03:23 +0300
Message-ID: <000c01d033df$ece29420$c6a7bc60$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and
	replaying clock ticks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com

> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 16/01/2015 09:03, Pavel Dovgaluk wrote:
> > There is one problem with protecting log file inside the replay code.
> > We probably should have the following sequence of calls:
> >
> > lock_replay_mutex
> > replay_save_events
> >     replay_run_event
> > unlock_replay_mutex
> >
> > But replay_run_event can also generate some log events and we will have deadlock here.
> > That is why we rely on global mutex.
> 
> I think replay_run_event should run with the lock _not_ taken, that is:
> 
>     qemu_mutex_lock(&lock);
>     while (!QTAILQ_EMPTY(&events_list)) {
>         Event *event = QTAILQ_FIRST(&events_list);
>         QTAILQ_REMOVE(&events_list, event, events);
>         qemu_mutex_unlock(&lock);
>         replay_run_event(event);
>         g_free(event);
>         qemu_mutex_lock(&lock);
>     }
>     qemu_mutex_unlock(&lock);

It will work for protecting the events list (I've already did this).
But that will not work for protecting the log file.
replay_run_event can write some data to the log. And also some other function like replay_checkpoint
can also write to the log simultaneously (if we will remove the global mutex).
That's why we cannot simply replace the global mutex with some kind of local one.

Pavel Dovgalyuk