Re: Vicam/3com homeconnect usb camera driver

["John Tyner" <jtyner@cs.ucr.edu>]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

> > The second one turns on the LED. I didn't check it because I figured the
> > LED actually turning on was not a big deal. Though, I suppose that if an
> > error occurred, that could be indicative of some other problem.
>
> Exactly.

Fixed.

> But usbcore will happily call probe if  HOTPLUG is not defined and AFAICT
> usb will compile without HOTPLUG.

I thought HOTPLUG affected the user's ability to add and remove USB devices
while the kernel is running. It would seem that I misunderstood (or, in less
formal terms, was wrong :)).

Attached is a patch against 2.5.40 with __dev* uses removed and the error
checking in the open routine fixed.

Let me know if the ordering of the video_unregister_device and tasklet_kill
is still an issue.

Thanks,
John

[-- Attachment #2: vicam-2.5.40.patch.gz --]
[-- Type: application/x-gzip, Size: 16778 bytes --]