From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>,
"'Randall S. Becker'" <randall.s.becker@rogers.com>
Cc: "'Eric Sunshine'" <sunshine@sunshineco.us>,
"'Git List'" <git@vger.kernel.org>
Subject: RE: [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.
Date: Fri, 28 Dec 2018 15:33:23 -0500 [thread overview]
Message-ID: <000f01d49eec$973d8990$c5b89cb0$@nexbridge.com> (raw)
In-Reply-To: <xmqqa7kpmmtj.fsf@gitster-ct.c.googlers.com>
On December 28, 2018 15:07, Junio C Hamano
> "Randall S. Becker" <randall.s.becker@rogers.com> writes:
>
> > On December 27, 2018 12:03, Eric Sunshine wrote:
> >> On Wed, Dec 26, 2018 at 6:05 PM <randall.s.becker@rogers.com> wrote:
> >> > A number of configuration options are not automatically detected by
> >> > configure mechanisms, including the location of Perl and Python.
> >> > [...]
> >> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> >> > ---
> >> > diff --git a/config.mak.uname b/config.mak.uname @@ -441,26
> +441,45
> >> @@
> >> > ifeq ($(uname_S),NONSTOP_KERNEL)
> >> > # Our's are in ${prefix}/bin (perl might also be in
/usr/bin/perl).
> >> > - PERL_PATH = ${prefix}/bin/perl
> >> > - PYTHON_PATH = ${prefix}/bin/python
> >> > + PERL_PATH = /usr/bin/perl
> >> > + PYTHON_PATH = /usr/bin/python
> >>
> >> Is the in-code comment about ${prefix} still applicable after this
change?
> >
> > The ${prefix} is not applicable on this platform for perl and python.
> > Those locations must be in /usr/bin and are managed by the Operating
> > System vendor not by customers. The change is wrapped in an IF so is
> > only applicable to NonStop.
>
> So the answer is "Our's are in ${prefix}/bin..." is no longer correct? If
so, this
> patch must remove that stale comment at the same time, no?
Yessir. Fixed at v3 (now at v4).
next prev parent reply other threads:[~2018-12-28 20:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 23:05 [PATCH v1 0/4] HPE NonStop Port Commits randall.s.becker
2018-12-26 23:05 ` [PATCH v1 1/4] transport-helper: use xread instead of read randall.s.becker
2018-12-28 20:10 ` Junio C Hamano
2018-12-28 20:38 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config randall.s.becker
2018-12-27 17:02 ` Eric Sunshine
2018-12-27 17:44 ` Randall S. Becker
2018-12-28 20:07 ` Junio C Hamano
2018-12-28 20:33 ` Randall S. Becker [this message]
2018-12-26 23:05 ` [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop randall.s.becker
2018-12-27 12:10 ` Derrick Stolee
2018-12-27 15:55 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop randall.s.becker
2018-12-27 12:12 ` [PATCH v1 0/4] HPE NonStop Port Commits Derrick Stolee
2018-12-27 16:01 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01d49eec$973d8990$c5b89cb0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=randall.s.becker@rogers.com \
--cc=sunshine@sunshineco.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.